From 51cdd0800c919c80baca6d3fbe852ce74dc63a58 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Tue, 15 Sep 2015 17:19:03 -0400
Subject: [PATCH] simplified calculatePostIndices

---
 src/topics.js       | 10 +++-------
 src/topics/posts.js | 20 ++++++--------------
 2 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/src/topics.js b/src/topics.js
index fc7c1f49e9..45b066b3e1 100644
--- a/src/topics.js
+++ b/src/topics.js
@@ -274,17 +274,13 @@ var async = require('async'),
 				if (!posts.length) {
 					return next(null, []);
 				}
-
+				var replies = posts;
 				if (topic.mainPid) {
 					posts[0].index = 0;
+					replies = posts.slice(1);
 				}
 
-				var indices = Topics.calculatePostIndices(start, stop, topic.postcount, reverse);
-				for (var i=1; i<posts.length; ++i) {
-					if (posts[i]) {
-						posts[i].index = indices[i - 1];
-					}
-				}
+				Topics.calculatePostIndices(replies, start, stop, topic.postcount, reverse);
 
 				Topics.addPostData(posts, uid, next);
 			}
diff --git a/src/topics/posts.js b/src/topics/posts.js
index f0265e7048..217c91284a 100644
--- a/src/topics/posts.js
+++ b/src/topics/posts.js
@@ -44,12 +44,7 @@ module.exports = function(Topics) {
 				return callback(err);
 			}
 
-			var indices = Topics.calculatePostIndices(start, stop, results.postCount, reverse);
-			results.posts.forEach(function(post, index) {
-				if (post) {
-					post.index = indices[index];
-				}
-			});
+			Topics.calculatePostIndices(results.posts, start, stop, results.postCount, reverse);
 
 			Topics.addPostData(results.posts, uid, callback);
 		});
@@ -151,17 +146,14 @@ module.exports = function(Topics) {
 		});
 	};
 
-	Topics.calculatePostIndices = function(start, stop, postCount, reverse) {
-		var indices = [];
-		var count = stop - start + 1;
-		for(var i=0; i<count; ++i) {
+	Topics.calculatePostIndices = function(posts, start, stop, postCount, reverse) {
+		posts.forEach(function(post, index) {
 			if (reverse) {
-				indices.push(postCount - (start + i + 1));
+				post.index = postCount - (start + index + 1);
 			} else {
-				indices.push(start + i + 1);
+				post.index = start + index + 1;
 			}
-		}
-		return indices;
+		});
 	};
 
 	Topics.getLatestUndeletedPid = function(tid, callback) {