From 51b7eca1194e29e41dac3ec1ae3d375670105843 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Thu, 12 Nov 2020 22:23:50 -0500 Subject: [PATCH] fix: run every hour, dont show message if average_time is 0 --- src/controllers/authentication.js | 4 +++- src/user/approval.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/controllers/authentication.js b/src/controllers/authentication.js index 7836f8fe17..2bf8f59d2f 100644 --- a/src/controllers/authentication.js +++ b/src/controllers/authentication.js @@ -121,7 +121,9 @@ async function addToApprovalQueue(req, userData) { let message = '[[register:registration-added-to-queue]]'; if (meta.config.showAverageApprovalTime) { const average_time = await db.getObjectField('registration:queue:approval:times', 'average'); - message += ` [[register:registration-queue-average-time, ${Math.floor(average_time / 60)}, ${average_time % 60}]]`; + if (average_time > 0) { + message += ` [[register:registration-queue-average-time, ${Math.floor(average_time / 60)}, ${average_time % 60}]]`; + } } if (meta.config.autoApproveTime > 0) { message += ` [[register:registration-queue-auto-approve-time, ${meta.config.autoApproveTime}]]`; diff --git a/src/user/approval.js b/src/user/approval.js index 2476da5cb1..0a2c200d7c 100644 --- a/src/user/approval.js +++ b/src/user/approval.js @@ -13,7 +13,7 @@ const slugify = require('../slugify'); const plugins = require('../plugins'); module.exports = function (User) { - new cronJob('0 * * * * *', function () { + new cronJob('0 * * * *', function () { User.autoApprove(); }, null, true);