From 4de658e0964873f621f811a862fe9bec7263f63f Mon Sep 17 00:00:00 2001 From: barisusakli Date: Fri, 19 Sep 2014 19:45:16 -0400 Subject: [PATCH] checks --- src/socket.io/topics.js | 4 +++- src/topics/unread.js | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/socket.io/topics.js b/src/socket.io/topics.js index 8d495ee239..7b7b0fb7f2 100644 --- a/src/socket.io/topics.js +++ b/src/socket.io/topics.js @@ -89,7 +89,9 @@ SocketTopics.markAsRead = function(socket, tids, callback) { if (!tids.length) { return callback(); } - + tids = tids.filter(function(tid) { + return tid && utils.isNumber(tid); + }); topics.markAsRead(tids, socket.uid, function(err) { if (err) { return callback(err); diff --git a/src/topics/unread.js b/src/topics/unread.js index fd1849cfdf..0951a0f3aa 100644 --- a/src/topics/unread.js +++ b/src/topics/unread.js @@ -206,6 +206,9 @@ module.exports = function(Topics) { }; Topics.markTopicNotificationsRead = function(tid, uid) { + if (!tid) { + return; + } user.notifications.getUnreadByField(uid, 'tid', tid, function(err, nids) { if (err) { return winston.error(err.stack);