From 4b0cb26b34ea44385c89329c1a7f530ac1713493 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Fri, 21 Aug 2020 15:42:04 -0400
Subject: [PATCH] fix: empty "manage" menu showing in ACP

... if no privileges corresponding to those menu items
are given
---
 src/middleware/admin.js           | 1 +
 src/views/admin/partials/menu.tpl | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/src/middleware/admin.js b/src/middleware/admin.js
index fe06bf053c..da52a4a778 100644
--- a/src/middleware/admin.js
+++ b/src/middleware/admin.js
@@ -73,6 +73,7 @@ middleware.renderHeader = async (req, res, data) => {
 		version: version,
 		latestVersion: results.latestVersion,
 		upgradeAvailable: results.latestVersion && semver.gt(results.latestVersion, version),
+		showManageMenu: results.privileges.superadmin || ['categories', 'privileges', 'users', 'settings'].some(priv => results.privileges[`admin:${priv}`]),
 	};
 
 	templateValues.template = { name: res.locals.template };
diff --git a/src/views/admin/partials/menu.tpl b/src/views/admin/partials/menu.tpl
index 750255bf28..47bae16e6b 100644
--- a/src/views/admin/partials/menu.tpl
+++ b/src/views/admin/partials/menu.tpl
@@ -11,6 +11,7 @@
 		</ul>
 	</section>
 
+	{{{ if showManageMenu }}}
 	<section class="menu-section">
 		<h3 class="menu-section-title">[[admin/menu:section-manage]]</h3>
 		<ul class="menu-section-list">
@@ -30,6 +31,7 @@
 			{{{ end }}}
 		</ul>
 	</section>
+	{{{ end }}}
 
 	{{{ if user.privileges.admin:settings }}}
 	<section class="menu-section">
@@ -180,6 +182,7 @@
 			</li>
 			{{{ end }}}
 
+			{{{ if showManageMenu }}}
 			<li class="dropdown menu-item">
 				<a id="manage-menu" href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false">[[admin/menu:section-manage]]</a>
 				<ul class="dropdown-menu" role="menu">
@@ -199,6 +202,7 @@
 					{{{ end }}}
 				</ul>
 			</li>
+			{{{ end }}}
 
 			{{{ if user.privileges.admin:settings }}}
 			<li class="dropdown menu-item">