From 4a6249a4555b5e3d1b84e31a6bef731f133c61e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Sat, 10 Jun 2023 17:24:10 -0400
Subject: [PATCH] fix: closes #11697, remove min attribute from rep thresholds

---
 src/messaging/index.js                  | 11 ++++++-----
 src/views/admin/settings/reputation.tpl | 18 +++++++++---------
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/src/messaging/index.js b/src/messaging/index.js
index bc7d4ee4db..ddb6eb6fbe 100644
--- a/src/messaging/index.js
+++ b/src/messaging/index.js
@@ -292,11 +292,12 @@ Messaging.canMessageRoom = async (uid, roomId) => {
 };
 
 async function checkReputation(uid) {
-	if (meta.config['min:rep:chat'] > 0) {
-		const reputation = await user.getUserField(uid, 'reputation');
-		if (meta.config['min:rep:chat'] > reputation) {
-			throw new Error(`[[error:not-enough-reputation-to-chat, ${meta.config['min:rep:chat']}]]`);
-		}
+	if (meta.config['reputation:disabled']) {
+		return;
+	}
+	const reputation = await user.getUserField(uid, 'reputation');
+	if (meta.config['min:rep:chat'] > reputation) {
+		throw new Error(`[[error:not-enough-reputation-to-chat, ${meta.config['min:rep:chat']}]]`);
 	}
 }
 
diff --git a/src/views/admin/settings/reputation.tpl b/src/views/admin/settings/reputation.tpl
index 1ffc11e66e..99eed3a959 100644
--- a/src/views/admin/settings/reputation.tpl
+++ b/src/views/admin/settings/reputation.tpl
@@ -26,11 +26,11 @@
 				<h5 class="fw-bold tracking-tight settings-header">[[admin/settings/reputation:thresholds]]</h5>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:chat">[[admin/settings/reputation:min-rep-chat]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:chat" id="min:rep:chat">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:chat" id="min:rep:chat">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:upvote">[[admin/settings/reputation:min-rep-upvote]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:upvote" id="min:rep:upvote">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:upvote" id="min:rep:upvote">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="upvotesPerDay">[[admin/settings/reputation:upvotes-per-day]]</label>
@@ -43,7 +43,7 @@
 
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:downvote">[[admin/settings/reputation:min-rep-downvote]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:downvote" id="min:rep:downvote">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:downvote" id="min:rep:downvote">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="downvotesPerDay">[[admin/settings/reputation:downvotes-per-day]]</label>
@@ -55,27 +55,27 @@
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:flag">[[admin/settings/reputation:min-rep-flag]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:flag" id="min:rep:flag">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:flag" id="min:rep:flag">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:website">[[admin/settings/reputation:min-rep-website]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:website" id="min:rep:website">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:website" id="min:rep:website">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:aboutme">[[admin/settings/reputation:min-rep-aboutme]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:aboutme" id="min:rep:aboutme">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:aboutme" id="min:rep:aboutme">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:signature">[[admin/settings/reputation:min-rep-signature]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:signature" id="min:rep:signature">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:signature" id="min:rep:signature">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:profile-picture">[[admin/settings/reputation:min-rep-profile-picture]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:profile-picture" id="min:rep:profile-picture">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:profile-picture" id="min:rep:profile-picture">
 				</div>
 				<div class="mb-3">
 					<label class="form-label" for="min:rep:cover-picture">[[admin/settings/reputation:min-rep-cover-picture]]</label>
-					<input type="number" min="0" class="form-control" placeholder="0" data-field="min:rep:cover-picture" id="min:rep:cover-picture">
+					<input type="number" class="form-control" placeholder="0" data-field="min:rep:cover-picture" id="min:rep:cover-picture">
 				</div>
 			</div>