From bac2a0d959f4f8d7567738fa6e3995e0eb4b4e1f Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Thu, 5 Nov 2015 11:25:53 -0500
Subject: [PATCH 1/2] removed event:connect use socket.io connect event duh

---
 public/src/sockets.js  | 15 ++++++---------
 src/socket.io/index.js |  2 --
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/public/src/sockets.js b/public/src/sockets.js
index 3d0c3bb7ac..d53fd011bd 100644
--- a/public/src/sockets.js
+++ b/public/src/sockets.js
@@ -26,8 +26,6 @@ app.isConnected = false;
 		setTimeout(socket.connect.bind(socket), parseInt(config.reconnectionDelay, 10) * 10);
 	});
 
-	socket.on('event:connect', onEventConnect);
-
 	socket.on('event:disconnect', onEventDisconnect);
 
 	socket.on('event:banned', onEventBanned);
@@ -37,6 +35,12 @@ app.isConnected = false;
 	socket.on('event:alert', app.alert);
 
 	function onSocketConnect() {
+		if (!reconnecting) {
+			app.showLoginMessage();
+			$(window).trigger('action:connected');
+			app.isConnected = true;
+		}
+
 		if (reconnecting) {
 			var reconnectEl = $('#reconnect');
 
@@ -104,13 +108,6 @@ app.isConnected = false;
 		});
 	}
 
-	function onEventConnect() {
-		app.showLoginMessage();
-		app.replaceSelfLinks();
-		$(window).trigger('action:connected');
-		app.isConnected = true;
-	}
-
 	function onEventDisconnect() {
 		$(window).trigger('action:disconnected');
 		app.isConnected = false;
diff --git a/src/socket.io/index.js b/src/socket.io/index.js
index fd3ab9e995..968669fa06 100644
--- a/src/socket.io/index.js
+++ b/src/socket.io/index.js
@@ -71,14 +71,12 @@ function onConnect(socket) {
 				return;
 			}
 
-			socket.emit('event:connect');
 			if (userData.status !== 'offline') {
 				socket.broadcast.emit('event:user_status_change', {uid: socket.uid, status: userData.status || 'online'});
 			}
 		});
 	} else {
 		rooms.enter(socket, 'online_guests');
-		socket.emit('event:connect');
 	}
 }
 

From 0d23c562812e2cd6a620b7d4077f6ddbefc9eaed Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Thu, 5 Nov 2015 11:31:59 -0500
Subject: [PATCH 2/2] removed event:disconnect

---
 public/src/sockets.js             | 17 ++++++++---------
 src/controllers/authentication.js |  2 --
 src/socket.io/admin/user.js       |  2 --
 src/socket.io/index.js            |  4 ----
 4 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/public/src/sockets.js b/public/src/sockets.js
index d53fd011bd..1d606407f7 100644
--- a/public/src/sockets.js
+++ b/public/src/sockets.js
@@ -17,28 +17,29 @@ app.isConnected = false;
 
 	socket = io(config.websocketAddress, ioParams);
 
-	socket.on('connect', onSocketConnect);
+	socket.on('connect', onConnect);
 
 	socket.on('reconnecting', onReconnecting);
 
+	socket.on('disconnect', onDisconnect);
+
 	socket.on('reconnect_failed', function() {
 		// Wait ten times the reconnection delay and then start over
 		setTimeout(socket.connect.bind(socket), parseInt(config.reconnectionDelay, 10) * 10);
 	});
 
-	socket.on('event:disconnect', onEventDisconnect);
-
 	socket.on('event:banned', onEventBanned);
 
 	socket.on('event:logout', app.logout);
 
 	socket.on('event:alert', app.alert);
 
-	function onSocketConnect() {
+	function onConnect() {
+		app.isConnected = true;
+
 		if (!reconnecting) {
 			app.showLoginMessage();
 			$(window).trigger('action:connected');
-			app.isConnected = true;
 		}
 
 		if (reconnecting) {
@@ -52,7 +53,6 @@ app.isConnected = false;
 
 			socket.emit('meta.reconnected');
 
-			app.isConnected = true;
 			$(window).trigger('action:reconnected');
 
 			setTimeout(function() {
@@ -95,7 +95,7 @@ app.isConnected = false;
 		app.enterRoom(room);
 	}
 
-	function onReconnecting(attempt) {
+	function onReconnecting() {
 		reconnecting = true;
 		var reconnectEl = $('#reconnect');
 
@@ -108,10 +108,9 @@ app.isConnected = false;
 		});
 	}
 
-	function onEventDisconnect() {
+	function onDisconnect() {
 		$(window).trigger('action:disconnected');
 		app.isConnected = false;
-		socket.connect();
 	}
 
 	function onEventBanned() {
diff --git a/src/controllers/authentication.js b/src/controllers/authentication.js
index 686a9d2717..579f8462c3 100644
--- a/src/controllers/authentication.js
+++ b/src/controllers/authentication.js
@@ -30,7 +30,6 @@ authenticationController.register = function(req, res, next) {
 		}
 	}
 
-	var uid;
 	async.waterfall([
 		function(next) {
 			if (registrationType === 'invite-only') {
@@ -255,7 +254,6 @@ authenticationController.localLogin = function(req, username, password, next) {
 authenticationController.logout = function(req, res, next) {
 	if (req.user && parseInt(req.user.uid, 10) > 0 && req.sessionID) {
 		var uid = parseInt(req.user.uid, 10);
-		require('../socket.io').logoutUser(req.user.uid);
 		db.sessionStore.destroy(req.sessionID, function(err) {
 			if (err) {
 				return next(err);
diff --git a/src/socket.io/admin/user.js b/src/socket.io/admin/user.js
index d0eb477301..e1c0489ea8 100644
--- a/src/socket.io/admin/user.js
+++ b/src/socket.io/admin/user.js
@@ -88,7 +88,6 @@ User.banUser = function(uid, callback) {
 
 			websockets.in('uid_' + uid).emit('event:banned');
 
-			websockets.logoutUser(uid);
 			callback();
 		});
 	});
@@ -193,7 +192,6 @@ User.deleteUsers = function(socket, uids, callback) {
 					ip: socket.ip
 				});
 
-				websockets.logoutUser(uid);
 				next();
 			});
 		});
diff --git a/src/socket.io/index.js b/src/socket.io/index.js
index 968669fa06..6490d3e4cc 100644
--- a/src/socket.io/index.js
+++ b/src/socket.io/index.js
@@ -206,10 +206,6 @@ function callMethod(method, socket, params, callback) {
 	});
 }
 
-Sockets.logoutUser = function(uid) {
-	io.in('uid_' + uid).emit('event:disconnect');
-};
-
 Sockets.in = function(room) {
 	return io.in(room);
 };