From 48690a01b98a92182e55e8cdb502e09a672fc0b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 21 Nov 2018 17:24:38 -0500 Subject: [PATCH] dont need to call multi if keys.length is 0 --- src/database/mongo/sorted.js | 2 +- src/database/redis/sorted.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/database/mongo/sorted.js b/src/database/mongo/sorted.js index 59cb548fb4..a44315d5b5 100644 --- a/src/database/mongo/sorted.js +++ b/src/database/mongo/sorted.js @@ -363,7 +363,7 @@ module.exports = function (db, module) { module.getSortedSetsMembers = function (keys, callback) { if (!Array.isArray(keys) || !keys.length) { - return callback(null, []); + return setImmediate(callback, null, []); } db.collection('objects').find({ _key: { $in: keys } }, { projection: { _id: 0, score: 0 } }).sort({ score: 1 }).toArray(function (err, data) { if (err) { diff --git a/src/database/redis/sorted.js b/src/database/redis/sorted.js index fe1ee3a3b5..a38185f41d 100644 --- a/src/database/redis/sorted.js +++ b/src/database/redis/sorted.js @@ -172,6 +172,9 @@ module.exports = function (redisClient, module) { }; module.getSortedSetsMembers = function (keys, callback) { + if (!Array.isArray(keys) || !keys.length) { + return setImmediate(callback, null, []); + } var multi = redisClient.multi(); for (var i = 0; i < keys.length; i += 1) { multi.zrange(keys[i], 0, -1);