From 4826883484f3719b73b82a8759764651f91f79e7 Mon Sep 17 00:00:00 2001 From: barisusakli Date: Wed, 16 Sep 2015 14:51:55 -0400 Subject: [PATCH] up themes, 404 non existing popular pages --- package.json | 4 ++-- src/controllers/popular.js | 10 +++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 6afcd1855f..dc8d4920b8 100644 --- a/package.json +++ b/package.json @@ -49,8 +49,8 @@ "nodebb-plugin-spam-be-gone": "0.4.2", "nodebb-rewards-essentials": "0.0.5", "nodebb-theme-lavender": "2.0.1", - "nodebb-theme-persona": "3.0.12", - "nodebb-theme-vanilla": "4.0.7", + "nodebb-theme-persona": "3.0.13", + "nodebb-theme-vanilla": "4.0.8", "nodebb-widget-essentials": "2.0.1", "npm": "^2.1.4", "passport": "^0.3.0", diff --git a/src/controllers/popular.js b/src/controllers/popular.js index bfadc9f228..80bf362fba 100644 --- a/src/controllers/popular.js +++ b/src/controllers/popular.js @@ -13,13 +13,17 @@ var anonCache = {}, lastUpdateTime = 0; var terms = { daily: 'day', weekly: 'week', - monthly: 'month', - alltime: 'alltime' + monthly: 'month' }; popularController.get = function(req, res, next) { - var term = terms[req.params.term] || 'alltime'; + var term = terms[req.params.term]; + + if (!term && req.params.term) { + return next(); + } + term = term || 'alltime'; var termToBreadcrumb = { day: '[[recent:day]]',