From 46e022e97f9b0f63e7bb29e1ae213df38fe0f87a Mon Sep 17 00:00:00 2001 From: barisusakli Date: Mon, 1 Dec 2014 13:24:13 -0500 Subject: [PATCH] closes #2483 --- public/src/admin/extend/plugins.js | 320 ++++++++++++++--------------- src/views/admin/extend/plugins.tpl | 6 +- 2 files changed, 162 insertions(+), 164 deletions(-) diff --git a/public/src/admin/extend/plugins.js b/public/src/admin/extend/plugins.js index 52c9144360..5ebe8b8359 100644 --- a/public/src/admin/extend/plugins.js +++ b/public/src/admin/extend/plugins.js @@ -1,184 +1,182 @@ "use strict"; -/* global define, app, socket */ +/* global define, app, socket, bootbox */ define('admin/extend/plugins', function() { - var Plugins = { - init: function() { - var pluginsList = $('.plugins'), - numPlugins = pluginsList[0].querySelectorAll('li').length, - pluginID; - - if (numPlugins > 0) { - - pluginsList.on('click', 'button[data-action="toggleActive"]', function() { - pluginID = $(this).parents('li').attr('data-plugin-id'); - var btn = $(this); - socket.emit('admin.plugins.toggleActive', pluginID, function(err, status) { - btn.html(' ' + (status.active ? 'Deactivate' : 'Activate')); - btn.toggleClass('btn-warning', status.active).toggleClass('btn-success', !status.active); - - app.alert({ - alert_id: 'plugin_toggled', - title: 'Plugin ' + (status.active ? 'Enabled' : 'Disabled'), - message: status.active ? 'Please reload your NodeBB to fully activate this plugin' : 'Plugin successfully deactivated', - type: status.active ? 'warning' : 'success', - timeout: 5000, - clickfn: function() { - socket.emit('admin.reload'); - } - }); - }); - }); + var Plugins = {}; + Plugins.init = function() { + var pluginsList = $('.plugins'), + numPlugins = pluginsList[0].querySelectorAll('li').length, + pluginID; + + if (!numPlugins) { + pluginsList.append('

  • No plugins found.

    • '); + return; + } - pluginsList.on('click', 'button[data-action="toggleInstall"]', function() { - pluginID = $(this).parents('li').attr('data-plugin-id'); - - Plugins.suggest(pluginID, function(err, payload) { - if (!err) { - require(['semver'], function(semver) { - if (payload.version !== 'latest') { - Plugins.toggleInstall(pluginID, payload.version); - } else if (payload.version === 'latest') { - bootbox.confirm( - '

    No Compatibility Infomation Found

    This plugin did not specify a specific version for installation given your NodeBB version. Full compatibility cannot be guaranteed, and may cause your NodeBB to no longer start properly.

    ' + - '

    In the event that NodeBB cannot boot properly:

    ' + - '
    $ ./nodebb reset plugin="' + pluginID + '"
    ' + - '

    Continue installation of latest version of this plugin?

    ' - , function(confirm) { - if (confirm) { - Plugins.toggleInstall(pluginID, 'latest'); - } - }); - } - }); - } else { - bootbox.confirm('

    NodeBB could not reach the package manager, proceed with installation of latest version?

    Server returned (' + err.status + '): ' + err.responseText + '
    ', function(confirm) { - if (confirm) { - Plugins.toggleInstall(pluginID, 'latest'); - } - }); - } - }); + pluginsList.on('click', 'button[data-action="toggleActive"]', function() { + pluginID = $(this).parents('li').attr('data-plugin-id'); + var btn = $(this); + socket.emit('admin.plugins.toggleActive', pluginID, function(err, status) { + btn.html(' ' + (status.active ? 'Deactivate' : 'Activate')); + btn.toggleClass('btn-warning', status.active).toggleClass('btn-success', !status.active); + + app.alert({ + alert_id: 'plugin_toggled', + title: 'Plugin ' + (status.active ? 'Enabled' : 'Disabled'), + message: status.active ? 'Please reload your NodeBB to fully activate this plugin' : 'Plugin successfully deactivated', + type: status.active ? 'warning' : 'success', + timeout: 5000, + clickfn: function() { + socket.emit('admin.reload'); + } }); + }); + }); + + pluginsList.on('click', 'button[data-action="toggleInstall"]', function() { + pluginID = $(this).parents('li').attr('data-plugin-id'); - pluginsList.on('click', 'button[data-action="upgrade"]', function() { - var btn = $(this); - var parent = btn.parents('li'); - pluginID = parent.attr('data-plugin-id'); - - - Plugins.suggest(pluginID, function(err, payload) { - if (!err) { - require(['semver'], function(semver) { - if (payload.version !== 'latest' && semver.gt(payload.version, parent.find('.currentVersion').text())) { - btn.attr('disabled', true).find('i').attr('class', 'fa fa-refresh fa-spin'); - socket.emit('admin.plugins.upgrade', { - id: pluginID, - version: payload.version - }, function(err) { - if (err) { - return app.alertError(err.message); - } - parent.find('.fa-exclamation-triangle').remove(); - parent.find('.currentVersion').text(payload.version); - btn.remove(); - }); - } else if (payload.version === 'latest') { - bootbox.confirm( - '

    No Compatibility Infomation Found

    This plugin did not specify a specific version for installation given your NodeBB version. Full compatibility cannot be guaranteed, and may cause your NodeBB to no longer start properly.

    ' + - '

    In the event that NodeBB cannot boot properly:

    ' + - '
    $ ./nodebb reset plugin="' + pluginID + '"
    ' + - '

    Continue installation of latest version of this plugin?

    ' - , function(confirm) { - if (confirm) { - socket.emit('admin.plugins.upgrade', { - id: pluginID, - version: payload.version - }, function(err) { - if (err) { - return app.alertError(err.message); - } - parent.find('.fa-exclamation-triangle').remove(); - parent.find('.currentVersion').text(payload.version); - btn.remove(); - }); - } - }); - } else { - bootbox.alert('

    Your version of NodeBB (v' + app.config.version + ') is only cleared to upgrade to v' + payload.version + ' of this plugin. Please update your NodeBB if you wish to install a newer version of this plugin.'); - } - }); - } else { - bootbox.alert('

    NodeBB could not reach the package manager, an upgrade is not suggested at this time.

    '); + if ($(this).attr('data-installed') === '1') { + return Plugins.toggleInstall(pluginID, $(this).parents('li').attr('data-version')); + } + + Plugins.suggest(pluginID, function(err, payload) { + if (err) { + bootbox.confirm('

    NodeBB could not reach the package manager, proceed with installation of latest version?

    Server returned (' + err.status + '): ' + err.responseText + '
    ', function(confirm) { + if (confirm) { + Plugins.toggleInstall(pluginID, 'latest'); } }); + return; + } + + require(['semver'], function(semver) { + if (payload.version !== 'latest') { + Plugins.toggleInstall(pluginID, payload.version); + } else if (payload.version === 'latest') { + confirmInstall(pluginID, function() { + Plugins.toggleInstall(pluginID, 'latest'); + }); + } }); + }); + }); + pluginsList.on('click', 'button[data-action="upgrade"]', function() { + var btn = $(this); + var parent = btn.parents('li'); + pluginID = parent.attr('data-plugin-id'); - $('#plugin-search').on('input propertychange', function() { - var term = $(this).val(); - $('.plugins li').each(function() { - var pluginId = $(this).attr('data-plugin-id'); - $(this).toggleClass('hide', pluginId && pluginId.indexOf(term) === -1); - }); + Plugins.suggest(pluginID, function(err, payload) { + if (err) { + return bootbox.alert('

    NodeBB could not reach the package manager, an upgrade is not suggested at this time.

    '); + } + + require(['semver'], function(semver) { + if (payload.version !== 'latest' && semver.gt(payload.version, parent.find('.currentVersion').text())) { + upgrade(pluginID, btn, payload.version); + } else if (payload.version === 'latest') { + confirmInstall(pluginID, function() { + upgrade(pluginID, btn, payload.version); + }); + } else { + bootbox.alert('

    Your version of NodeBB (v' + app.config.version + ') is only cleared to upgrade to v' + payload.version + ' of this plugin. Please update your NodeBB if you wish to install a newer version of this plugin.'); + } }); + }); + }); + + $('#plugin-search').on('input propertychange', function() { + var term = $(this).val(); + $('.plugins li').each(function() { + var pluginId = $(this).attr('data-plugin-id'); + $(this).toggleClass('hide', pluginId && pluginId.indexOf(term) === -1); + }); + }); + }; + function confirmInstall(pluginID, callback) { + bootbox.confirm( + '

    No Compatibility Infomation Found

    This plugin did not specify a specific version for installation given your NodeBB version. Full compatibility cannot be guaranteed, and may cause your NodeBB to no longer start properly.

    ' + + '

    In the event that NodeBB cannot boot properly:

    ' + + '
    $ ./nodebb reset plugin="' + pluginID + '"
    ' + + '

    Continue installation of latest version of this plugin?

    ', function(confirm) { + if (confirm) { + callback(); + } + }); + } + + function upgrade(pluginID, btn, version) { + btn.attr('disabled', true).find('i').attr('class', 'fa fa-refresh fa-spin'); + socket.emit('admin.plugins.upgrade', { + id: pluginID, + version: version + }, function(err) { + if (err) { + return app.alertError(err.message); + } + var parent = btn.parents('li'); + parent.find('.fa-exclamation-triangle').remove(); + parent.find('.currentVersion').text(version); + btn.remove(); + }); + } + + Plugins.toggleInstall = function(pluginID, version, callback) { + var btn = $('li[data-plugin-id="' + pluginID + '"] button[data-action="toggleInstall"]'); + var activateBtn = btn.siblings('[data-action="toggleActive"]'); + btn.html(btn.html() + 'ing') + .attr('disabled', true) + .find('i').attr('class', 'fa fa-refresh fa-spin'); + + socket.emit('admin.plugins.toggleInstall', { + id: pluginID, + version: version + }, function(err, status) { + if (err) { + return app.alertError(err.message); + } + + if (status.installed) { + btn.html(' Uninstall'); } else { - pluginsList.append('

  • No plugins found.

    • '); + btn.html(' Install'); } - }, - toggleInstall: function(pluginID, version, callback) { - var btn = $('li[data-plugin-id="' + pluginID + '"] button[data-action="toggleInstall"]'); - var activateBtn = btn.siblings('[data-action="toggleActive"]'); - btn.html(btn.html() + 'ing') - .attr('disabled', true) - .find('i').attr('class', 'fa fa-refresh fa-spin'); - - socket.emit('admin.plugins.toggleInstall', { - id: pluginID, - version: version - }, function(err, status) { - if (err) { - return app.alertError(err.message); - } - if (status.installed) { - btn.html(' Uninstall'); - } else { - btn.html(' Install'); + activateBtn.toggleClass('hidden', !status.installed); - } - activateBtn.toggleClass('hidden', !status.installed); + btn.toggleClass('btn-danger', status.installed) + .toggleClass('btn-success', !status.installed) + .attr('disabled', false) + .attr('data-installed', status.installed ? 1 : 0); - btn.toggleClass('btn-danger', status.installed).toggleClass('btn-success', !status.installed) - .attr('disabled', false); + app.alert({ + alert_id: 'plugin_toggled', + title: 'Plugin ' + (status.installed ? 'Installed' : 'Uninstalled'), + message: status.installed ? 'Plugin successfully installed, please activate the plugin.' : 'The plugin has been successfully deactivated and uninstalled.', + type: 'info', + timeout: 5000 + }); - app.alert({ - alert_id: 'plugin_toggled', - title: 'Plugin ' + (status.installed ? 'Installed' : 'Uninstalled'), - message: status.installed ? 'Plugin successfully installed, please activate the plugin.' : 'The plugin has been successfully deactivated and uninstalled.', - type: 'info', - timeout: 5000 - }); + if (typeof callback === 'function') { + callback.apply(this, arguments); + } + }); + }; - if (typeof callback === 'function') { - callback.apply(this, arguments); - } - }); - }, - suggest: function(pluginId, callback) { - var nbbVersion = app.config.version; - $.ajax('https://packages.nodebb.org/api/v1/suggest', { - type: 'GET', - data: { - package: pluginId, - version: nbbVersion - }, - dataType: 'json' - }).done(function(payload) { - callback(undefined, payload); - }).fail(callback); - } + Plugins.suggest = function(pluginId, callback) { + var nbbVersion = app.config.version; + $.ajax('https://packages.nodebb.org/api/v1/suggest', { + type: 'GET', + data: { + package: pluginId, + version: nbbVersion + }, + dataType: 'json' + }).done(function(payload) { + callback(undefined, payload); + }).fail(callback); }; return Plugins; diff --git a/src/views/admin/extend/plugins.tpl b/src/views/admin/extend/plugins.tpl index 542e0b435f..d966dcee53 100644 --- a/src/views/admin/extend/plugins.tpl +++ b/src/views/admin/extend/plugins.tpl @@ -6,11 +6,11 @@