From 57f9f8bc5726a1c05b489700f842ed3b42cc2c92 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Sun, 9 Mar 2014 16:39:31 -0400
Subject: [PATCH 1/2] closes #1176

---
 public/src/forum/topic.js | 5 +++--
 src/database/redis.js     | 4 +---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/public/src/forum/topic.js b/public/src/forum/topic.js
index 6ccb865b07..2280bb728f 100644
--- a/public/src/forum/topic.js
+++ b/public/src/forum/topic.js
@@ -309,7 +309,7 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 			var bookmark = localStorage.getItem('topic:' + tid + ':bookmark');
 			if (window.location.hash) {
 				Topic.scrollToPost(window.location.hash.substr(1), true);
-			} else if (bookmark && (!config.usePagination || (config.usePagination && pagination.currentPage === 1))) {
+			} else if (bookmark && (!config.usePagination || (config.usePagination && pagination.currentPage === 1)) && Topic.postCount > 1) {
 				app.alert({
 					alert_id: 'bookmark',
 					message: '[[topic:bookmark_instructions]]',
@@ -1042,8 +1042,9 @@ define(['composer', 'forum/pagination'], function(composer, pagination) {
 				$('.progress-bar').width((index / Topic.postCount * 100) + '%');
 
 				var currentBookmark = localStorage.getItem('topic:' + templates.get('topic_id') + ':bookmark');
-				if (!currentBookmark || parseInt(el.attr('data-pid'), 10) > parseInt(currentBookmark, 10)) {
+				if (!currentBookmark || parseInt(el.attr('data-pid'), 10) >= parseInt(currentBookmark, 10)) {
 					localStorage.setItem('topic:' + templates.get('topic_id') + ':bookmark', el.attr('data-pid'));
+					app.removeAlert('bookmark');
 				}
 
 				if (!scrollingToPost) {
diff --git a/src/database/redis.js b/src/database/redis.js
index d672994b6c..e37afff1ba 100644
--- a/src/database/redis.js
+++ b/src/database/redis.js
@@ -207,9 +207,7 @@
 			multi.hgetall(keys[x]);
 		}
 
-		multi.exec(function (err, replies) {
-			callback(err, replies);
-		});
+		multi.exec(callback);
 	};
 
 	module.getObjectField = function(key, field, callback) {

From 73c89010cba10378e35d4f8be891c7583a4ce5a1 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Sun, 9 Mar 2014 17:29:05 -0400
Subject: [PATCH 2/2] closes #1182

---
 public/src/forum/admin/themes.js  | 120 +++++++++++++++++-------------
 public/templates/admin/themes.tpl |   9 ++-
 src/meta.js                       |  16 ++--
 src/routes/api.js                 |   1 +
 4 files changed, 81 insertions(+), 65 deletions(-)

diff --git a/public/src/forum/admin/themes.js b/public/src/forum/admin/themes.js
index d5873a7164..14408bbce6 100644
--- a/public/src/forum/admin/themes.js
+++ b/public/src/forum/admin/themes.js
@@ -1,43 +1,53 @@
 define(['forum/admin/settings'], function(Settings) {
 	var Themes = {};
 
+	function highlightSelectedTheme(themeId) {
+		$('#themes li[data-theme]').removeClass('btn-warning');
+		$('#themes li[data-theme="' + themeId + '"]').addClass('btn-warning');
+	}
+
 	Themes.init = function() {
 		var scriptEl = $('<script />');
 		scriptEl.attr('src', 'http://api.bootswatch.com/3/?callback=bootswatchListener');
 		$('body').append(scriptEl);
 
 		var bootstrapThemeContainer = $('#bootstrap_themes'),
-			installedThemeContainer = $('#installed_themes'),
-
-			themeEvent = function(e) {
-				var target = $(e.target),
-					action = target.attr('data-action');
-
-				if (action) {
-					switch (action) {
-						case 'use':
-							var parentEl = target.parents('li'),
-								themeType = parentEl.attr('data-type'),
-								cssSrc = parentEl.attr('data-css'),
-								themeId = parentEl.attr('data-theme');
-
-							socket.emit('admin.themes.set', {
-								type: themeType,
-								id: themeId,
-								src: cssSrc
-							}, function(err) {
-								app.alert({
-									alert_id: 'admin:theme',
-									type: 'success',
-									title: 'Theme Changed',
-									message: 'Restarting your NodeBB <i class="fa fa-refresh fa-spin"></i>',
-									timeout: 3500
-								});
+			installedThemeContainer = $('#installed_themes');
+
+		function themeEvent(e) {
+			var target = $(e.target),
+				action = target.attr('data-action');
+
+			if (action) {
+				switch (action) {
+					case 'use':
+						var parentEl = target.parents('li'),
+							themeType = parentEl.attr('data-type'),
+							cssSrc = parentEl.attr('data-css'),
+							themeId = parentEl.attr('data-theme');
+
+						socket.emit('admin.themes.set', {
+							type: themeType,
+							id: themeId,
+							src: cssSrc
+						}, function(err) {
+							if (err) {
+								return app.alertError(err.message);
+							}
+							highlightSelectedTheme(themeId);
+
+							app.alert({
+								alert_id: 'admin:theme',
+								type: 'success',
+								title: 'Theme Changed',
+								message: 'Restarting your NodeBB <i class="fa fa-refresh fa-spin"></i>',
+								timeout: 3500
 							});
-							break;
-					}
+						});
+						break;
 				}
-			};
+			}
+		}
 
 		bootstrapThemeContainer.on('click', themeEvent);
 		installedThemeContainer.on('click', themeEvent);
@@ -49,6 +59,10 @@ define(['forum/admin/settings'], function(Settings) {
 						type: 'local',
 						id: 'nodebb-theme-cerulean'
 					}, function(err) {
+						if (err) {
+							return app.alertError(err.message);
+						}
+						highlightSelectedTheme('nodebb-theme-cerulean');
 						app.alert({
 							alert_id: 'admin:theme',
 							type: 'success',
@@ -59,7 +73,7 @@ define(['forum/admin/settings'], function(Settings) {
 					});
 				}
 			});
-		}, false);
+		});
 
 		// Installed Themes
 		socket.emit('admin.themes.getInstalled', function(err, themes) {
@@ -69,30 +83,32 @@ define(['forum/admin/settings'], function(Settings) {
 
 			var instListEl = $('#installed_themes').empty(), liEl;
 
-			if (themes.length > 0) {
-				for (var x = 0, numThemes = themes.length; x < numThemes; x++) {
-					liEl = $('<li/ >').attr({
-						'data-type': 'local',
-						'data-theme': themes[x].id
-					}).html('<img src="' + (themes[x].screenshot ? '/css/previews/' + themes[x].id : RELATIVE_PATH + '/images/themes/default.png') + '" />' +
-							'<div>' +
-							'<div class="pull-right">' +
-							'<button class="btn btn-primary" data-action="use">Use</button> ' +
-							'</div>' +
-							'<h4>' + themes[x].name + '</h4>' +
-							'<p>' +
-							themes[x].description +
-							(themes[x].url ? ' (<a href="' + themes[x].url + '">Homepage</a>)' : '') +
-							'</p>' +
-							'</div>' +
-							'<div class="clear">');
-
-					instListEl.append(liEl);
-				}
-			} else {
-				// No themes found
+			if (!themes.length) {
 				instListEl.append($('<li/ >').addClass('no-themes').html('No installed themes found'));
+				return;
 			}
+
+			for (var x = 0, numThemes = themes.length; x < numThemes; x++) {
+				liEl = $('<li/ >').attr({
+					'data-type': 'local',
+					'data-theme': themes[x].id
+				}).html('<img src="' + (themes[x].screenshot ? '/css/previews/' + themes[x].id : RELATIVE_PATH + '/images/themes/default.png') + '" />' +
+						'<div>' +
+						'<div class="pull-right">' +
+						'<button class="btn btn-primary" data-action="use">Use</button> ' +
+						'</div>' +
+						'<h4>' + themes[x].name + '</h4>' +
+						'<p>' +
+						themes[x].description +
+						(themes[x].url ? ' (<a href="' + themes[x].url + '">Homepage</a>)' : '') +
+						'</p>' +
+						'</div>' +
+						'<div class="clear">');
+
+				instListEl.append(liEl);
+			}
+
+			highlightSelectedTheme(config['theme:id']);
 		});
 
 		// Proper tabbing for "Custom CSS" field
diff --git a/public/templates/admin/themes.tpl b/public/templates/admin/themes.tpl
index 3e279c2f5c..d17f067f6b 100644
--- a/public/templates/admin/themes.tpl
+++ b/public/templates/admin/themes.tpl
@@ -10,6 +10,11 @@
 
 	<div class="tab-content">
 		<div class="tab-pane active" id="themes">
+			<h3>Revert to Default</h3>
+			<p class="alert">
+				<button class="btn btn-warning" id="revert_theme">Revert</button> This will remove any custom theme applied to your NodeBB, and restore the base theme.
+			</p>
+
 			<h3>Installed Themes</h3>
 			<p>
 				The following themes are currently installed in this NodeBB instance.
@@ -27,10 +32,6 @@
 				<li><i class="fa fa-refresh fa-spin"></i> Loading Themes</li>
 			</ul>
 
-			<h3>Revert to Default</h3>
-			<p class="alert">
-				<button class="btn btn-warning" id="revert_theme">Revert</button> This will remove any custom theme applied to your NodeBB, and restore the base theme.
-			</p>
 		</div>
 		<div class="tab-pane" id="customise">
 			<h3>Custom CSS</h3>
diff --git a/src/meta.js b/src/meta.js
index f8196c9fba..34d2b7d10b 100644
--- a/src/meta.js
+++ b/src/meta.js
@@ -125,12 +125,12 @@ var fs = require('fs'),
 		},
 		set: function(data, callback) {
 			var	themeData = {
-					'theme:type': data.type,
-					'theme:id': data.id,
-					'theme:staticDir': '',
-					'theme:templates': '',
-					'theme:src': ''
-				};
+				'theme:type': data.type,
+				'theme:id': data.id,
+				'theme:staticDir': '',
+				'theme:templates': '',
+				'theme:src': ''
+			};
 
 			switch(data.type) {
 				case 'local':
@@ -152,9 +152,7 @@ var fs = require('fs'),
 
 							db.setObject('config', themeData, next);
 						}
-					], function(err) {
-						callback(err);
-					});
+					], callback);
 				break;
 
 				case 'bootswatch':
diff --git a/src/routes/api.js b/src/routes/api.js
index 1242e4b04a..ddd0461131 100644
--- a/src/routes/api.js
+++ b/src/routes/api.js
@@ -66,6 +66,7 @@ var path = require('path'),
 				config.topicsPerPage = meta.config.topicsPerPage || 20;
 				config.postsPerPage = meta.config.postsPerPage || 20;
 				config.maximumFileSize = meta.config.maximumFileSize;
+				config['theme:id'] = meta.config['theme:id'];
 				config.defaultLang = meta.config.defaultLang || 'en_GB';
 				config.environment = process.env.NODE_ENV;