From 43f9c3224fa8cc67c12e7bca909c87fdf9112234 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <baris@nodebb.org>
Date: Thu, 2 Nov 2017 08:14:35 -0400
Subject: [PATCH] dont crash sortedSetIncryBy on redis if no callback is
 supplied

---
 src/database/mongo/helpers.js | 8 +++-----
 src/database/redis/helpers.js | 2 ++
 src/database/redis/sorted.js  | 1 +
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/database/mongo/helpers.js b/src/database/mongo/helpers.js
index 7a791c9fca..29c83ea3b9 100644
--- a/src/database/mongo/helpers.js
+++ b/src/database/mongo/helpers.js
@@ -1,6 +1,8 @@
 'use strict';
 
-var helpers = {};
+var helpers = module.exports;
+
+helpers.noop = function () {};
 
 helpers.toMap = function (data) {
 	var map = {};
@@ -31,7 +33,3 @@ helpers.valueToString = function (value) {
 
 	return value.toString();
 };
-
-helpers.noop = function () {};
-
-module.exports = helpers;
diff --git a/src/database/redis/helpers.js b/src/database/redis/helpers.js
index b1c2a98092..bcf2b63e1c 100644
--- a/src/database/redis/helpers.js
+++ b/src/database/redis/helpers.js
@@ -2,6 +2,8 @@
 
 var helpers = module.exports;
 
+helpers.noop = function () {};
+
 helpers.multiKeys = function (redisClient, command, keys, callback) {
 	callback = callback || function () {};
 	var multi = redisClient.multi();
diff --git a/src/database/redis/sorted.js b/src/database/redis/sorted.js
index 282928da97..fe1ee3a3b5 100644
--- a/src/database/redis/sorted.js
+++ b/src/database/redis/sorted.js
@@ -180,6 +180,7 @@ module.exports = function (redisClient, module) {
 	};
 
 	module.sortedSetIncrBy = function (key, increment, value, callback) {
+		callback = callback || helpers.noop;
 		redisClient.zincrby(key, increment, value, function (err, newValue) {
 			callback(err, !err ? parseFloat(newValue) : undefined);
 		});