diff --git a/public/src/forum/accountedit.js b/public/src/forum/accountedit.js index 0deeda57c7..13bab6cf9d 100644 --- a/public/src/forum/accountedit.js +++ b/public/src/forum/accountedit.js @@ -190,10 +190,11 @@ define(['forum/accountheader', 'uploader'], function(header, uploader) { $('#changePasswordBtn').on('click', function() { - if (passwordvalid && passwordsmatch && currentPassword.val()) { + if (passwordvalid && passwordsmatch && (currentPassword.val() || app.isAdmin)) { socket.emit('user.changePassword', { 'currentPassword': currentPassword.val(), - 'newPassword': password.val() + 'newPassword': password.val(), + 'uid': templates.get('theirid') }, function(err) { currentPassword.val(''); @@ -203,12 +204,10 @@ define(['forum/accountheader', 'uploader'], function(header, uploader) { passwordvalid = false; if (err) { - app.alertError(err.message); - return; + return app.alertError(err.message); } app.alertSuccess('Your password is updated!'); - }); } return false; diff --git a/public/src/forum/admin/groups.js b/public/src/forum/admin/groups.js index 7d21ee8742..ad530c12a9 100644 --- a/public/src/forum/admin/groups.js +++ b/public/src/forum/admin/groups.js @@ -58,15 +58,14 @@ define(function() { listEl.on('click', 'button[data-action]', function() { var action = this.getAttribute('data-action'), - parent = $(this).parents('li[data-gid]'), - gid = parent.attr('data-gid'), - system = parseInt(parent.attr('data-system'), 10) === 1; + gid = $(this).parents('li[data-gid]').attr('data-gid'); switch (action) { case 'delete': bootbox.confirm('Are you sure you wish to delete this group?', function(confirm) { if (confirm) { socket.emit('admin.groups.delete', gid, function(err, data) { + console.log(err, data); if(err) { return app.alertError(err.message); } @@ -107,8 +106,6 @@ define(function() { detailsModal.attr('data-gid', groupObj.gid); detailsModal.modal('show'); - - $('.hide-if-system')[system ? 'hide' : 'show'](); }); break; } diff --git a/public/src/forum/popular.js b/public/src/forum/popular.js index f85e38ccb2..c4817bbd71 100644 --- a/public/src/forum/popular.js +++ b/public/src/forum/popular.js @@ -21,6 +21,10 @@ define(['forum/recent'], function(recent) { }); function loadMoreTopics() { + if(!$('#topics-container').length) { + return; + } + loadingMoreTopics = true; socket.emit('topics.loadMoreFromSet', { set: 'topics:' + $('.nav-pills .active a').html().toLowerCase(), diff --git a/public/src/forum/recent.js b/public/src/forum/recent.js index 15e1d63ceb..8837c41367 100644 --- a/public/src/forum/recent.js +++ b/public/src/forum/recent.js @@ -92,6 +92,10 @@ define(function() { } Recent.loadMoreTopics = function() { + if(!$('#topics-container').length) { + return; + } + loadingMoreTopics = true; socket.emit('topics.loadMoreRecentTopics', { after: $('#topics-container').attr('data-nextstart'), diff --git a/public/src/forum/unread.js b/public/src/forum/unread.js index 4f3024fbab..3ed2baf5cc 100644 --- a/public/src/forum/unread.js +++ b/public/src/forum/unread.js @@ -44,6 +44,9 @@ define(['forum/recent'], function(recent) { }); function loadMoreTopics() { + if(!$('#topics-container').length) { + return; + } loadingMoreTopics = true; socket.emit('topics.loadMoreUnreadTopics', { after: $('#topics-container').attr('data-nextstart') diff --git a/public/templates/admin/groups.tpl b/public/templates/admin/groups.tpl index 6c87898da0..bd21db2b9f 100644 --- a/public/templates/admin/groups.tpl +++ b/public/templates/admin/groups.tpl @@ -5,7 +5,7 @@