From 38a7030639be8485c53241939e814ca65289c8ce Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Mon, 11 Sep 2017 15:37:18 -0400 Subject: [PATCH] Revert "Merge pull request #5923 from NodeBB/patch-5922" This reverts commit f8ddabc884c5aba7604ba8edeccd2e421e42b185, reversing changes made to 4976d1301358573f53862692c84ae3359fe040b7. --- public/language/en-GB/error.json | 1 - src/controllers/helpers.js | 2 +- src/views/400.tpl | 2 +- src/views/403.tpl | 2 +- src/views/500-embed.tpl | 2 +- src/views/500.tpl | 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/public/language/en-GB/error.json b/public/language/en-GB/error.json index f970199f32..8d106b6a79 100644 --- a/public/language/en-GB/error.json +++ b/public/language/en-GB/error.json @@ -5,7 +5,6 @@ "not-logged-in": "You don't seem to be logged in.", "account-locked": "Your account has been locked temporarily", "search-requires-login": "Searching requires an account - please login or register.", - "goback": "Return to the previous page", "invalid-cid": "Invalid Category ID", "invalid-tid": "Invalid Topic ID", diff --git a/src/controllers/helpers.js b/src/controllers/helpers.js index c95b012aa9..ee0ba75482 100644 --- a/src/controllers/helpers.js +++ b/src/controllers/helpers.js @@ -26,7 +26,7 @@ helpers.noScriptErrors = function (req, res, error, httpStatus) { path: req.path, loggedIn: true, error: error, - returnLink: req.get('Referrer'), + returnLink: true, title: '[[global:' + httpStatusString + '.title]]', }); }); diff --git a/src/views/400.tpl b/src/views/400.tpl index 419f7beff5..c36f1b2f48 100644 --- a/src/views/400.tpl +++ b/src/views/400.tpl @@ -7,6 +7,6 @@ - [[error:goback]] +

[[error:goback]]

diff --git a/src/views/403.tpl b/src/views/403.tpl index 16760c452c..bf93b496cd 100644 --- a/src/views/403.tpl +++ b/src/views/403.tpl @@ -7,7 +7,7 @@ - [[error:goback]] +

[[error:goback]]

diff --git a/src/views/500-embed.tpl b/src/views/500-embed.tpl index 44bb1744ff..b1045d431f 100644 --- a/src/views/500-embed.tpl +++ b/src/views/500-embed.tpl @@ -4,7 +4,7 @@ define('/assets/templates/500.jst', function () { return '
\n\t[[global:500.title]]\n\t

[[global:500.message]]

\n\t

' + helpers.__escape(get(context && context['path'])) + '

\n\t' + (get(context && context['error']) ? '

' + helpers.__escape(get(context && context['error'])) + '

' : '') + '\n\n\t' + - (get(context && context['returnLink']) ? '\n\t[[error:goback]]\n\t' : '') + '\n
\n'; + (get(context && context['returnLink']) ? '\n\t

[[error:goback]]

\n\t' : '') + '\n\n'; } return compiled; diff --git a/src/views/500.tpl b/src/views/500.tpl index fb611a23b8..7795fbbf8a 100644 --- a/src/views/500.tpl +++ b/src/views/500.tpl @@ -5,6 +5,6 @@

{error}

- [[error:goback]] +

[[error:goback]]