From 3077eb94289e3d103433c36a346f0181276a75cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Tue, 21 Jan 2020 15:17:31 -0500
Subject: [PATCH] fix: remove unused conditional, dont add dupe messages

---
 public/src/modules/chat.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/public/src/modules/chat.js b/public/src/modules/chat.js
index 5bd2bca080..46ad454585 100644
--- a/public/src/modules/chat.js
+++ b/public/src/modules/chat.js
@@ -70,13 +70,10 @@ define('chat', [
 				roomData.silent = true;
 				roomData.uid = app.user.uid;
 				roomData.isSelf = isSelf;
-				module.createModal(roomData, function (modal) {
+				module.createModal(roomData, function () {
 					if (!isSelf) {
 						updateTitleAndPlaySound(data.message.mid, username);
 					}
-					if (!modal) {
-						addMessageToModal(data);
-					}
 				});
 			});
 		}
@@ -87,7 +84,10 @@ define('chat', [
 		var username = data.message.fromUser.username;
 		var isSelf = data.self === 1;
 		require(['forum/chats/messages'], function (ChatsMessages) {
-			ChatsMessages.appendChatMessage(modal.find('.chat-content'), data.message);
+			// don't add if already added
+			if (!modal.find('[data-mid="' + data.message.messageId + '"]').length) {
+				ChatsMessages.appendChatMessage(modal.find('.chat-content'), data.message);
+			}
 
 			if (modal.is(':visible')) {
 				taskbar.updateActive(modal.attr('data-uuid'));