From 303bffdb5f7e7e048c4e019f128b3a42c9362aa8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Wed, 29 Jul 2020 11:19:29 -0400 Subject: [PATCH] feat: remove require fallback for plugins --- src/plugins/index.js | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/plugins/index.js b/src/plugins/index.js index e126cee97d..7d243cf3d1 100644 --- a/src/plugins/index.js +++ b/src/plugins/index.js @@ -44,28 +44,6 @@ Plugins.loadedPlugins = []; Plugins.initialized = false; -var defaultRequire = module.require; - -module.require = function (p) { - try { - return defaultRequire.apply(module, arguments); - } catch (err) { - // if we can't find the module try in parent directory - // since plugins.js moved into plugins folder - if (err.code === 'MODULE_NOT_FOUND') { - let stackLine = err.stack.split('\n'); - stackLine = stackLine.find(line => line.includes('nodebb-plugin') || line.includes('nodebb-theme')); - var deprecatedPath = err.message.replace('Cannot find module ', ''); - winston.warn('[deprecated] requiring core modules with `module.parent.require(' + deprecatedPath + ')` is deprecated. Please use `require.main.require("./src/")` instead.\n' + stackLine); - if (path.isAbsolute(p)) { - throw err; - } - return defaultRequire.apply(module, [path.join('../', p)]); - } - throw err; - } -}; - Plugins.requireLibrary = function (pluginID, libraryPath) { Plugins.libraries[pluginID] = require(libraryPath); Plugins.libraryPaths.push(libraryPath);