closed #159 - issue where theme listing would hang if a theme folder did

not contain theme.json

Also refactored theme socket event a bit

public/src/forum/admin/themes.js

@@ -39,7 +39,7 @@ var nodebb_admin = (function(nodebb_admin) {
 
 (function() {
 	var scriptEl = document.createElement('script');
-	scriptEl.src = 'http://api.bootswatch.com?callback=nodebb_admin.themes.render';
+	scriptEl.src = 'http://api.bootswatch.com/2/?callback=nodebb_admin.themes.render';
 	document.body.appendChild(scriptEl);
 
 	var	bootstrapThemeContainer = document.querySelector('#bootstrap_themes'),
@@ -81,7 +81,7 @@ var nodebb_admin = (function(nodebb_admin) {
 	}, false);
 
 	// Installed Themes
-	socket.once('api:admin:themes.getInstalled', function(themes) {
+	socket.emit('api:admin.themes.getInstalled', function(themes) {
 		var	instListEl = document.getElementById('installed_themes'),
 			themeFrag = document.createDocumentFragment(),
 			liEl = document.createElement('li');
@@ -108,5 +108,4 @@ var nodebb_admin = (function(nodebb_admin) {
 		instListEl.innerHTML = '';
 		instListEl.appendChild(themeFrag);
 	});
-	socket.emit('api:admin:themes.getInstalled');
 })();

src/meta.js

@@ -49,7 +49,7 @@ var utils = require('./../public/src/utils.js'),
 										themeArr.push(conf);
 										next();
 									});
-								}
+								} else next();
 							});
 						} else next();
 					});
@@ -57,9 +57,6 @@ var utils = require('./../public/src/utils.js'),
 					callback(err, themeArr);
 				});
 			});
-		},
-		saveViaGithub: function(repo_url, callback) {
-			// ...
 		}
 	}
 

src/websockets.js

@@ -701,9 +701,9 @@ var SocketIO = require('socket.io').listen(global.server, { log:false }),
 				socket.emit('api:admin.user.search', null);
 		});
 
-		socket.on('api:admin:themes.getInstalled', function() {
+		socket.on('api:admin.themes.getInstalled', function(callback) {
 			meta.themes.get(function(err, themeArr) {
-				socket.emit('api:admin:themes.getInstalled', themeArr);
+				callback(themeArr);
 			});
 		});