From 1ec9739629bc62d03f5c61ab611e84493fa88c1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <baris@nodebb.org>
Date: Mon, 17 May 2021 17:24:23 -0400
Subject: [PATCH] switch to request-promise-native (#9561)

* refactor: cli/upgrade async/await

async/await cli/upgrade-plugins
remove unused payload.files

* fix: add missing await

* refactor: use request-promise-native
---
 src/cli/upgrade-plugins.js | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/src/cli/upgrade-plugins.js b/src/cli/upgrade-plugins.js
index 2359bcc767..b6cd6ac2a7 100644
--- a/src/cli/upgrade-plugins.js
+++ b/src/cli/upgrade-plugins.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const prompt = require('prompt');
-const request = require('request');
+const request = require('request-promise-native');
 const cproc = require('child_process');
 const semver = require('semver');
 const fs = require('fs');
@@ -76,22 +76,17 @@ async function getCurrentVersion() {
 	return pkg.version;
 }
 
-const getSuggestedModules = util.promisify((nbbVersion, toCheck, cb) => {
-	request({
+async function getSuggestedModules(nbbVersion, toCheck) {
+	let body = await request({
 		method: 'GET',
 		url: `https://packages.nodebb.org/api/v1/suggest?version=${nbbVersion}&package[]=${toCheck.join('&package[]=')}`,
 		json: true,
-	}, (err, res, body) => {
-		if (err) {
-			process.stdout.write('error'.red + ''.reset);
-			return cb(err);
-		}
-		if (!Array.isArray(body) && toCheck.length === 1) {
-			body = [body];
-		}
-		cb(null, body);
 	});
-});
+	if (!Array.isArray(body) && toCheck.length === 1) {
+		body = [body];
+	}
+	return body;
+}
 
 async function checkPlugins() {
 	process.stdout.write('Checking installed plugins and themes for updates... ');