From 16a7728ab84812cabde7b8a806de034d583d60c6 Mon Sep 17 00:00:00 2001 From: Baris Usakli Date: Fri, 6 Jul 2018 14:20:37 -0400 Subject: [PATCH] fix redis warnings --- src/database/redis/hash.js | 5 ++++- src/socket.io/admin/categories.js | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/database/redis/hash.js b/src/database/redis/hash.js index 9dd6276f88..3055143375 100644 --- a/src/database/redis/hash.js +++ b/src/database/redis/hash.js @@ -14,7 +14,7 @@ module.exports = function (redisClient, module) { } Object.keys(data).forEach(function (key) { - if (data[key] === undefined) { + if (data[key] === undefined || data[key] === null) { delete data[key]; } }); @@ -26,6 +26,9 @@ module.exports = function (redisClient, module) { module.setObjectField = function (key, field, value, callback) { callback = callback || function () {}; + if (!field) { + return callback(); + } redisClient.hset(key, field, value, function (err) { callback(err); }); diff --git a/src/socket.io/admin/categories.js b/src/socket.io/admin/categories.js index 6ccc20c873..d35a582691 100644 --- a/src/socket.io/admin/categories.js +++ b/src/socket.io/admin/categories.js @@ -85,7 +85,7 @@ Categories.setPrivilege = function (socket, data, callback) { events.log({ uid: socket.uid, ip: socket.ip, - privilege: data.privilege, + privilege: data.privilege.toString(), action: data.set ? 'grant' : 'rescind', target: data.member, }, callback);