From 06f66337fb7c3a8cef14b132260169548a78eb23 Mon Sep 17 00:00:00 2001
From: barisusakli <barisusakli@gmail.com>
Date: Tue, 4 Nov 2014 19:05:55 -0500
Subject: [PATCH] anon checks

less db calls for uid 0
---
 src/favourites.js       | 14 ++++++++++++++
 src/posts.js            | 18 ++++++++++++++++++
 src/privileges/posts.js |  7 +------
 src/user.js             |  3 +++
 4 files changed, 36 insertions(+), 6 deletions(-)

diff --git a/src/favourites.js b/src/favourites.js
index 123e014bc9..518b796f96 100644
--- a/src/favourites.js
+++ b/src/favourites.js
@@ -195,6 +195,9 @@ var async = require('async'),
 	};
 
 	Favourites.hasVoted = function(pid, uid, callback) {
+		if (!parseInt(uid, 10)) {
+			return callback(null, {upvoted: false, downvoted: false});
+		}
 		db.isMemberOfSets(['pid:' + pid + ':upvote', 'pid:' + pid + ':downvote'], uid, function(err, hasVoted) {
 			if (err) {
 				return callback(err);
@@ -205,6 +208,10 @@ var async = require('async'),
 	};
 
 	Favourites.getVoteStatusByPostIDs = function(pids, uid, callback) {
+		if (!parseInt(uid, 10)) {
+			var data = pids.map(function() {return false;});
+			return callback(null, {upvotes: data, downvotes: data});
+		}
 		var upvoteSets = [],
 			downvoteSets = [];
 
@@ -284,10 +291,17 @@ var async = require('async'),
 	}
 
 	Favourites.hasFavourited = function(pid, uid, callback) {
+		if (!parseInt(uid, 10)) {
+			return callback(null, false);
+		}
 		db.isSetMember('pid:' + pid + ':users_favourited', uid, callback);
 	};
 
 	Favourites.getFavouritesByPostIDs = function(pids, uid, callback) {
+		if (!parseInt(uid, 10)) {
+			return callback(null, pids.map(function() {return false;}));
+		}
+
 		var sets = [];
 		for (var i=0; i<pids.length; ++i) {
 			sets.push('pid:' + pids[i] + ':users_favourited');
diff --git a/src/posts.js b/src/posts.js
index f856e711f2..54d01dcd30 100644
--- a/src/posts.js
+++ b/src/posts.js
@@ -579,6 +579,9 @@ var async = require('async'),
 	Posts.isOwner = function(pid, uid, callback) {
 		uid = parseInt(uid, 10);
 		if (Array.isArray(pid)) {
+			if (!uid) {
+				return callback(null, pid.map(function() {return false;}));
+			}
 			Posts.getPostsFields(pid, ['uid'], function(err, posts) {
 				if (err) {
 					return callback(err);
@@ -589,12 +592,27 @@ var async = require('async'),
 				callback(null, posts);
 			});
 		} else {
+			if (!uid) {
+				return callback(null, false);
+			}
 			Posts.getPostField(pid, 'uid', function(err, author) {
 				callback(err, parseInt(author, 10) === uid);
 			});
 		}
 	};
 
+	Posts.isModerator = function(pids, uid, callback) {
+		if (!parseInt(uid, 10)) {
+			return callback(null, pids.map(function() {return false;}));
+		}
+		Posts.getCidsByPids(pids, function(err, cids) {
+			if (err) {
+				return callback(err);
+			}
+			user.isModerator(uid, cids, callback);
+		});
+	}
+
 	Posts.isMain = function(pid, callback) {
 		Posts.getPostField(pid, 'tid', function(err, tid) {
 			if (err) {
diff --git a/src/privileges/posts.js b/src/privileges/posts.js
index c23dae0eae..e5035ceb4b 100644
--- a/src/privileges/posts.js
+++ b/src/privileges/posts.js
@@ -38,12 +38,7 @@ module.exports = function(privileges) {
 					posts.isOwner(pids, uid, next);
 				},
 				isModerator: function(next) {
-					posts.getCidsByPids(pids, function(err, cids) {
-						if (err) {
-							return next(err);
-						}
-						user.isModerator(uid, cids, next);
-					});
+					posts.isModerator(pids, uid, next);
 				}
 			}, function(err, postResults) {
 				if (err) {
diff --git a/src/user.js b/src/user.js
index 74299cb8bf..5b242bbcb0 100644
--- a/src/user.js
+++ b/src/user.js
@@ -402,6 +402,9 @@ var	async = require('async'),
 
 	User.isModerator = function(uid, cid, callback) {
 		if (Array.isArray(cid)) {
+			if (!parseInt(uid, 10)) {
+				return callback(null, cid.map(function() {return false;}));
+			}
 			var uniqueCids = cid.filter(function(cid, index, array) {
 				return array.indexOf(cid) === index;
 			});