From 03d92eb5cd144a209295871dcc0bb54c35f10dd4 Mon Sep 17 00:00:00 2001 From: MrWaffle <mrwafflewaffle@aim.com> Date: Wed, 22 Jan 2014 20:29:37 +0100 Subject: [PATCH] Thought I'd refactor this for you guys --- src/favourites.js | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/favourites.js b/src/favourites.js index be3636ebd2..aa017c982b 100644 --- a/src/favourites.js +++ b/src/favourites.js @@ -100,21 +100,18 @@ var async = require('async'), }; Favourites.getFavouritesByPostIDs = function (pids, uid, callback) { - var loaded = 0; var data = {}; - for (var i = 0, ii = pids.length; i < ii; i++) { - (function (post_id) { - Favourites.hasFavourited(post_id, uid, function (hasFavourited) { - - data[post_id] = hasFavourited; - loaded++; - if (loaded === pids.length) { - callback(data); - } - }); - }(pids[i])); + function iterator(pid, next) { + Favourites.hasFavourited(pid, uid, function (hasFavourited) { + data[pid] = hasFavourited; + next() + }); } + + async.each(pids, iterator, function(err) { + callback(data); + }); }; Favourites.getFavouritedUidsByPids = function (pids, callback) {