From 002522834c7c57fede6f736c2a731fef7568a2d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Thu, 4 Oct 2018 13:42:53 -0400 Subject: [PATCH] closes #6815 --- src/socket.io/admin.js | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/socket.io/admin.js b/src/socket.io/admin.js index 3f9cd91666..c13132c973 100644 --- a/src/socket.io/admin.js +++ b/src/socket.io/admin.js @@ -178,6 +178,14 @@ SocketAdmin.config.setMultiple = function (socket, data, callback) { return callback(new Error('[[error:invalid-data]]')); } + var changes = {}; + Object.keys(data).forEach(function (key) { + if (data[key] !== meta.config[key]) { + changes[key] = data[key]; + changes[key + '_old'] = meta.config[key]; + } + }); + async.waterfall([ function (next) { meta.configs.setMultiple(data, next); @@ -194,10 +202,15 @@ SocketAdmin.config.setMultiple = function (socket, data, callback) { logger.monitorConfig({ io: index.server }, setting); } } - data.type = 'config-change'; - data.uid = socket.uid; - data.ip = socket.ip; - events.log(data, next); + + if (Object.keys(changes).length) { + changes.type = 'config-change'; + changes.uid = socket.uid; + changes.ip = socket.ip; + events.log(changes, next); + } else { + next(); + } }, ], callback); };