You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
nodebb/test/socket.io.js

816 lines
23 KiB
JavaScript

'use strict';
// see https://gist.github.com/jfromaniello/4087861#gistcomment-1447029
8 years ago
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
const util = require('util');
const sleep = util.promisify(setTimeout);
const assert = require('assert');
const async = require('async');
const nconf = require('nconf');
const request = require('request');
const cookies = request.jar();
const db = require('./mocks/databasemock');
const user = require('../src/user');
const groups = require('../src/groups');
const categories = require('../src/categories');
const helpers = require('./helpers');
const meta = require('../src/meta');
const events = require('../src/events');
const socketAdmin = require('../src/socket.io/admin');
describe('socket.io', () => {
let io;
let cid;
let tid;
let adminUid;
let regularUid;
before(async () => {
const data = await Promise.all([
user.create({ username: 'admin', password: 'adminpwd' }),
user.create({ username: 'regular', password: 'regularpwd' }),
categories.create({
name: 'Test Category',
description: 'Test category created by testing script',
}),
]);
adminUid = data[0];
await groups.join('administrators', data[0]);
regularUid = data[1];
await user.setUserField(regularUid, 'email', '[email protected]');
await user.email.confirmByUid(regularUid);
cid = data[2].cid;
});
it('should connect and auth properly', (done) => {
request.get({
url: `${nconf.get('url')}/api/config`,
jar: cookies,
json: true,
}, (err, res, body) => {
assert.ifError(err);
request.post(`${nconf.get('url')}/login`, {
jar: cookies,
form: {
username: 'admin',
password: 'adminpwd',
},
headers: {
'x-csrf-token': body.csrf_token,
},
json: true,
}, (err, res) => {
assert.ifError(err);
helpers.connectSocketIO(res, (err, _io) => {
io = _io;
assert.ifError(err);
done();
});
});
});
});
it('should return error for unknown event', (done) => {
io.emit('unknown.event', (err) => {
assert(err);
assert.equal(err.message, '[[error:invalid-event, unknown.event]]');
done();
});
});
it('should return error for unknown event', (done) => {
io.emit('user.gdpr.__proto__.constructor.toString', (err) => {
assert(err);
assert.equal(err.message, '[[error:invalid-event, user.gdpr.__proto__.constructor.toString]]');
done();
});
});
it('should return error for unknown event', (done) => {
io.emit('constructor.toString', (err) => {
assert(err);
assert.equal(err.message, '[[error:invalid-event, constructor.toString]]');
done();
});
});
it('should return error for invalid eventName type', (done) => {
const eventName = ['topics.loadMoreTags'];
2 years ago
io.emit(eventName, (err) => {
assert.strictEqual(err.message, `[[error:invalid-event, object]]`);
done();
});
});
it('should get installed themes', (done) => {
Bootstrap5 (#10894) * chore: up deps * chore: up composer * fix(deps): bump 2factor to v7 * chore: up harmony * chore: up harmony * fix: missing await * feat: allow middlewares to pass in template values via res.locals * feat: buildAccountData middleware automatically added ot all account routes * fix: properly allow values in res.locals.templateValues to be added to the template data * refactor: user/blocks * refactor(accounts): categories and consent * feat: automatically 404 if exposeUid or exposeGroupName come up empty * refactor: remove calls to getUserDataByUserSlug for most account routes, since it is populated via middleware now * fix: allow exposeUid and exposeGroupName to work with slugs with mixed capitalization * fix: move reputation removal check to accountHelpers method * test: skip i18n tests if ref branch when present is not develop * fix(deps): bump theme versions * fix(deps): bump ntfy and 2factor * chore: up harmony * fix: add missing return * fix: #11191, only focus on search input on md environments and up * feat: allow file uploads on mobile chat closes https://github.com/NodeBB/NodeBB/issues/11217 * chore: up themes * chore: add lang string * fix(deps): bump ntfy to 1.0.15 * refactor: use new if/each syntax * chore: up composer * fix: regression from user helper refactor * chore: up harmony * chore: up composer * chore: up harmony * chore: up harmony * chore: up harmony * chore: fix composer version * feat: add increment helper * chore: up harmony * fix: #11228 no timestamps in future :hourglass: * chore: up harmony * check config.theme as well fire action:posts.loaded after processing dom * chore: up harmony * chore: up harmony * chore: up harmony * chore: up themes * chore: up harmony * remove extra class * refactor: move these to core from harmony * chore: up widgets * chore: up widgets * height auto * fix: closes #11238 * dont focus inputs, annoying on mobile * fix: dont focus twice, only focus on chat input on desktop dont wrap widget footer in row * chore: up harmony * chore: up harmony * update chat window * chore: up themes * fix cache buster for skins * chat fixes * chore: up harmony * chore: up composer * refactor: change hook logs to debug * fix: scroll to post right after adding to dom * fix: hash scrolling and highlighting correct post * test: re-enable read API schema tests * fix: add back schema changes for 179faa2270f2ad955dcc4a7b04755acce59e6ffd and c3920ccb10d8ead2dcd9914bb1784bed3f6adfd4 * fix: schema changes from 488f0978a4aa1ca1e4d2a1f2e8c7ef7a681f2f27 * fix: schema changes for f4cf482a874701ce80c0f306c49d8788cec66f87 * fix: schema update for be6bbabd0e2551fbe9571dcf3ee40ad721764543 * fix: schema changes for 69c96078ea78ee2c45885a90a6f6a59f9042a33c * fix: schema changes for d1364c313021e48a879a818b24947e1457c062f7 * fix: schema changes for 84ff1152f7552dd866e25a90972d970b9861107e * fix: schema changes for b860c2605c209e0650ef98f4c80d842ea23a51ce * fix: schema changes for 23cb67a1126481848fac39aafd1e253441e76d7f * fix: schema changes for b916e42f400dac8aa51670b15e439f87f0eb8939 * fix: schema change for a9bbb586fcb3a1c61b5fb69052236e78cdf7d743 * fix: schema changes for 4b738c8cd36c936a1dbe2bb900c694bf6c5520ec * fix: schema changes for 58b5781cea9acb129e6604a82ab5a5bfc0d8394d * fix: schema changes for 794bf01b21709c4be06584d576d706b3d6342057 * fix: schema changes for 80ea12c1c1963f5b39fb64841e4f3c8da3c87af2, e368feef51e0766f119c9710fb4db8f64724725c, and 52ead114bec961c62fa2eb0786540e229f6e4873 * fix: composer-default object in config? * fix: schema changes for 9acdc6808c070555352951c651921df181b10993 and 093093420027999df3c67bf0ea6024f6dbf81d2d * fix: schema changes for c0a52924f1f7ef8caeaacda67363ac269b56042c * fix: schema change for aba420a3f3b774e949c2539c73f3dc0e1ae79a38, move loggedInUser to optional props * fix: schema changes for 8c67031609da30d788561459f8bb76e9a69253de * fix: schema changes for 27e53b42f3ce48fa61d3754375715cd41ffe808d * fix: schema changes for 28359665187b0a3b9ec6226dca1234ebdbd725a5 * fix: breaking test for email confirmation API call * fix: schema changes for refactored search page * fix: schema changes for user object * fix: schema changes for 9f531f957e08eabb4bae844ddd67bde14d9b59f0 * fix: schema changes for c4042c70decd628e5b880bd109515b47e4e16164 and 23175110a29640e6fa052db1079bfedb34a61055 * fix: schema changes for 9b3616b10392e247974eb0c1e6225a1582bf6c69 * fix: schema changes for 5afd5de07d42fd33f039a6f85ded3b4992200e5a * fix: schema change for 1d7baf12171cffbd3af8914bef4e6297d1160d49 * fix: schema changes for 57bfb37c55a839662144e684875003ab52315ecc and be6bbabd0e2551fbe9571dcf3ee40ad721764543 * fix: schema changes for 6e86b4afa20d662af8b9f1c07518df2d8c258105 and 3efad2e13b7319eb9a1f4fda7af047be43ebc11f and 68f66223e73a72f378f193c83a9b5546bede2cda * fix: allowing optional qs prop in pagination keys (not sure why this didn't break before) * fix: re-login on email change * fix: schema changes for c926358d734a2fa410de87f4e4a91744215fc14a * fix: schema changes for 388a8270c9882892bad5c8141f65da8d59eac0fd * fix: schema change for 2658bcc821c22e137a6eeb9bb74098856a642eaf * fix: no need to call account middlewares for chats routes * fix: schema changes for 71743affc3e58dc85d4ffa15ce043d4d9ddd3d67 * fix: final schema changes * test: support for anyOf and oneOf * fix: check thumb * dont scroll to top on back press * remove group log * fix: add top margin to merged and deleted alerts * chore: up widgets * fix: improve fix-lists mixin * chore: up harmony/composer * feat: allow hiding quicksearch results during search * dont record searches made by composer * chore: up 54 * chore: up spam be gone * feat: add prev/next page and page count into mobile paginator * chore: up harmony * chore: up harmony * use old style for IS * fix: hide entire toolbar row if no posts or not singlePost * fix: updated messaging for post-queue template, #11206 * fix: btn-sm on post queue back button * fix: bump harmony, closes #11206 * fix: remove unused alert module import * fix: bump harmony * fix: bump harmony * chore: up harmony * refactor: IS scrolltop * fix: update users:search-user-for-chat source string * feat: support for mark-read toggle on chats dropdown and recent chats list * feat: api v3 calls to mark chat read/unread * feat: send event:chats.mark socket event on mark read or unread * refactor: allow frontend to mark chats as unread, use new API v3 routes instead of socket calls, better frontend event handling * docs: openapi schema updates for chat marking * fix: allow unread state toggling in chats dropdown too * fix: issue where repeated openings of the chats dropdown would continually add events for mark-read/unread * fix: debug log * refactor: move userSearch filter to a module * feat(routes): allow remounting /categories (#11230) * feat: send flags count to frontend on flags list page * refactor: filter form client-side js to extract out some logic * fix: applyFilters to not take any arguments, update selectedCids in updateButton instead of onHidden * fix: use userFilter module for assignee, reporterId, targetUid * fix(openapi): schema changes for updated flags page * fix: dont allow adding duplicates to userFilter * use same var * remove log * fix: closes #11282 * feat: lang key for x-topics * chore: up harmony * chore: up emoji * chore: up harmony * fix: update userFilter to allow new option `selectedBlock` * fix: wrong block name passed to userFilter * fix: https://github.com/NodeBB/NodeBB/issues/11283 * fix: chats, allow multiple dropdowns like in harmony * chore: up harmony * refactor: flag note adding/editing, closes #11285 * fix: remove old prepareEdit logic * chore: add caveat about hacky code block in userFilter module * fix: placeholders for userFilter module * refactor: navigator so it works with multiple thumbs/navigators * chore: up harmony * fix: closes #11287, destroy quick reply autocomplete on navigation * fix: filter disabled categories on user categories page count * chore: up harmony * docs: update openapi spec to include info about passing in timestamps for topic creation, removing timestamp as valid request param for topic replying * fix: send back null values on ACP search dashboard for startDate and endDate if not expicitly passed in, fix tests * fix: tweak table order in ACP dash searches * fix: only invoke navigator click drag on left mouse button * feat: add back unread indicator to navigator * clear bookmark on mark unread * fix: navigator crash on ajaxify * better thumb top calculation * fix: reset user bookmark when topic is marked unread * Revert "fix: reset user bookmark when topic is marked unread" This reverts commit 9bcd85c2c6848c3d325d32027261809da6e11c9e. * fix: update unread indicator on scroll, add unread count * chore: bump harmony * fix: crash on navigator unread update when backing out of a topic * fix: closes #11183 * fix: update topics:recent zset when rescheduling a topic * fix: dupe quote button, increase delay, hide immediately on empty selection * fix: navigator not showing up on first load * refactor: remove glance assorted fixes to navigator dont reduce remaning count if user scrolls down and up quickly only call topic.navigatorCallback when index changes * more sanity checks for bookmark dont allow setting bookmark higher than topic postcount * closes #11218, :train: * Revert "fix: update topics:recent zset when rescheduling a topic" This reverts commit 737973cca9e94b6cb3867492a09e1e0b1af391d5. * fix: #11306, show proper error if queued post doesn't exist was showing no-privileges if someone else accepted the post * https://github.com/NodeBB/NodeBB/issues/11307 dont use li * chore: up harmony * chore: bump version string * fix: copy paste fail * feat: closes #7382, tag filtering add client side support for filtering by tags on /category, /recent and /unread * chore: up harmony * chore: up harmony * Revert "fix: add back req.query fallback for backwards compatibility" [breaking] This reverts commit cf6cc2c454dc35c330393c62ee8ce67b42d8eefb. This commit is no longer required as passing in a CSRF token via query parameter is no longer supported as of NodeBB v3.x This is a breaking change. * fix: pass csrf token in form data, re: NodeBB/NodeBB#11309 * chore: up deps * fix: tests, use x-csrf-token query param removed * test: fix csrf_token * lint: remove unused * feat: add itemprop="image" to avatar helper * fix: get chat upload button in chat modal * breaking: remove deprecated socket.io methods * test: update messaging tests to not use sockets * fix: parent post links * fix: prevent post tooltip if mouse leaves before data/tpl is loaded * chore: up harmony * chore: up harmony * chore: up harmony * chore: up harmony * fix: nested replies indices * fix(deps): bump 2factor * feat: add loggedIn user to all api routes * chore: up themes * refactor: audit admin v3 write api routes as per #11321 * refactor: audit category v3 write api routes as per #11321 [breaking] docs: fix open api spec for #11321 * refactor: audit chat v3 write api routes as per #11321 * refactor: audit files v3 write api routes as per #11321 * refactor: audit flags v3 write api routes as per #11321 * refactor: audit posts v3 write api routes as per #11321 * refactor: audit topics v3 write api routes as per #11321 * refactor: audit users v3 write api routes as per #11321 * fix: lang string * remove min height * fix: empty topic/labels taking up space * fix: tag filtering when changing filter to watched topics or changing popular time limit to month * chore: up harmony * fix: closes #11354, show no post error if queued post already accepted/rejected * test: #11354 * test: #11354 * fix(deps): bump 2factor * fix: #11357 clear cache on thumb remove * fix: thumb remove on windows, closes #11357 * test: openapi for thumbs * test: fix openapi --------- Co-authored-by: Julian Lam <[email protected]> Co-authored-by: Opliko <[email protected]>
2 years ago
const themes = ['nodebb-theme-persona'];
io.emit('admin.themes.getInstalled', (err, data) => {
assert.ifError(err);
assert(data);
const installed = data.map(theme => theme.id);
themes.forEach((theme) => {
Bootstrap5 (#10894) * chore: up deps * chore: up composer * fix(deps): bump 2factor to v7 * chore: up harmony * chore: up harmony * fix: missing await * feat: allow middlewares to pass in template values via res.locals * feat: buildAccountData middleware automatically added ot all account routes * fix: properly allow values in res.locals.templateValues to be added to the template data * refactor: user/blocks * refactor(accounts): categories and consent * feat: automatically 404 if exposeUid or exposeGroupName come up empty * refactor: remove calls to getUserDataByUserSlug for most account routes, since it is populated via middleware now * fix: allow exposeUid and exposeGroupName to work with slugs with mixed capitalization * fix: move reputation removal check to accountHelpers method * test: skip i18n tests if ref branch when present is not develop * fix(deps): bump theme versions * fix(deps): bump ntfy and 2factor * chore: up harmony * fix: add missing return * fix: #11191, only focus on search input on md environments and up * feat: allow file uploads on mobile chat closes https://github.com/NodeBB/NodeBB/issues/11217 * chore: up themes * chore: add lang string * fix(deps): bump ntfy to 1.0.15 * refactor: use new if/each syntax * chore: up composer * fix: regression from user helper refactor * chore: up harmony * chore: up composer * chore: up harmony * chore: up harmony * chore: up harmony * chore: fix composer version * feat: add increment helper * chore: up harmony * fix: #11228 no timestamps in future :hourglass: * chore: up harmony * check config.theme as well fire action:posts.loaded after processing dom * chore: up harmony * chore: up harmony * chore: up harmony * chore: up themes * chore: up harmony * remove extra class * refactor: move these to core from harmony * chore: up widgets * chore: up widgets * height auto * fix: closes #11238 * dont focus inputs, annoying on mobile * fix: dont focus twice, only focus on chat input on desktop dont wrap widget footer in row * chore: up harmony * chore: up harmony * update chat window * chore: up themes * fix cache buster for skins * chat fixes * chore: up harmony * chore: up composer * refactor: change hook logs to debug * fix: scroll to post right after adding to dom * fix: hash scrolling and highlighting correct post * test: re-enable read API schema tests * fix: add back schema changes for 179faa2270f2ad955dcc4a7b04755acce59e6ffd and c3920ccb10d8ead2dcd9914bb1784bed3f6adfd4 * fix: schema changes from 488f0978a4aa1ca1e4d2a1f2e8c7ef7a681f2f27 * fix: schema changes for f4cf482a874701ce80c0f306c49d8788cec66f87 * fix: schema update for be6bbabd0e2551fbe9571dcf3ee40ad721764543 * fix: schema changes for 69c96078ea78ee2c45885a90a6f6a59f9042a33c * fix: schema changes for d1364c313021e48a879a818b24947e1457c062f7 * fix: schema changes for 84ff1152f7552dd866e25a90972d970b9861107e * fix: schema changes for b860c2605c209e0650ef98f4c80d842ea23a51ce * fix: schema changes for 23cb67a1126481848fac39aafd1e253441e76d7f * fix: schema changes for b916e42f400dac8aa51670b15e439f87f0eb8939 * fix: schema change for a9bbb586fcb3a1c61b5fb69052236e78cdf7d743 * fix: schema changes for 4b738c8cd36c936a1dbe2bb900c694bf6c5520ec * fix: schema changes for 58b5781cea9acb129e6604a82ab5a5bfc0d8394d * fix: schema changes for 794bf01b21709c4be06584d576d706b3d6342057 * fix: schema changes for 80ea12c1c1963f5b39fb64841e4f3c8da3c87af2, e368feef51e0766f119c9710fb4db8f64724725c, and 52ead114bec961c62fa2eb0786540e229f6e4873 * fix: composer-default object in config? * fix: schema changes for 9acdc6808c070555352951c651921df181b10993 and 093093420027999df3c67bf0ea6024f6dbf81d2d * fix: schema changes for c0a52924f1f7ef8caeaacda67363ac269b56042c * fix: schema change for aba420a3f3b774e949c2539c73f3dc0e1ae79a38, move loggedInUser to optional props * fix: schema changes for 8c67031609da30d788561459f8bb76e9a69253de * fix: schema changes for 27e53b42f3ce48fa61d3754375715cd41ffe808d * fix: schema changes for 28359665187b0a3b9ec6226dca1234ebdbd725a5 * fix: breaking test for email confirmation API call * fix: schema changes for refactored search page * fix: schema changes for user object * fix: schema changes for 9f531f957e08eabb4bae844ddd67bde14d9b59f0 * fix: schema changes for c4042c70decd628e5b880bd109515b47e4e16164 and 23175110a29640e6fa052db1079bfedb34a61055 * fix: schema changes for 9b3616b10392e247974eb0c1e6225a1582bf6c69 * fix: schema changes for 5afd5de07d42fd33f039a6f85ded3b4992200e5a * fix: schema change for 1d7baf12171cffbd3af8914bef4e6297d1160d49 * fix: schema changes for 57bfb37c55a839662144e684875003ab52315ecc and be6bbabd0e2551fbe9571dcf3ee40ad721764543 * fix: schema changes for 6e86b4afa20d662af8b9f1c07518df2d8c258105 and 3efad2e13b7319eb9a1f4fda7af047be43ebc11f and 68f66223e73a72f378f193c83a9b5546bede2cda * fix: allowing optional qs prop in pagination keys (not sure why this didn't break before) * fix: re-login on email change * fix: schema changes for c926358d734a2fa410de87f4e4a91744215fc14a * fix: schema changes for 388a8270c9882892bad5c8141f65da8d59eac0fd * fix: schema change for 2658bcc821c22e137a6eeb9bb74098856a642eaf * fix: no need to call account middlewares for chats routes * fix: schema changes for 71743affc3e58dc85d4ffa15ce043d4d9ddd3d67 * fix: final schema changes * test: support for anyOf and oneOf * fix: check thumb * dont scroll to top on back press * remove group log * fix: add top margin to merged and deleted alerts * chore: up widgets * fix: improve fix-lists mixin * chore: up harmony/composer * feat: allow hiding quicksearch results during search * dont record searches made by composer * chore: up 54 * chore: up spam be gone * feat: add prev/next page and page count into mobile paginator * chore: up harmony * chore: up harmony * use old style for IS * fix: hide entire toolbar row if no posts or not singlePost * fix: updated messaging for post-queue template, #11206 * fix: btn-sm on post queue back button * fix: bump harmony, closes #11206 * fix: remove unused alert module import * fix: bump harmony * fix: bump harmony * chore: up harmony * refactor: IS scrolltop * fix: update users:search-user-for-chat source string * feat: support for mark-read toggle on chats dropdown and recent chats list * feat: api v3 calls to mark chat read/unread * feat: send event:chats.mark socket event on mark read or unread * refactor: allow frontend to mark chats as unread, use new API v3 routes instead of socket calls, better frontend event handling * docs: openapi schema updates for chat marking * fix: allow unread state toggling in chats dropdown too * fix: issue where repeated openings of the chats dropdown would continually add events for mark-read/unread * fix: debug log * refactor: move userSearch filter to a module * feat(routes): allow remounting /categories (#11230) * feat: send flags count to frontend on flags list page * refactor: filter form client-side js to extract out some logic * fix: applyFilters to not take any arguments, update selectedCids in updateButton instead of onHidden * fix: use userFilter module for assignee, reporterId, targetUid * fix(openapi): schema changes for updated flags page * fix: dont allow adding duplicates to userFilter * use same var * remove log * fix: closes #11282 * feat: lang key for x-topics * chore: up harmony * chore: up emoji * chore: up harmony * fix: update userFilter to allow new option `selectedBlock` * fix: wrong block name passed to userFilter * fix: https://github.com/NodeBB/NodeBB/issues/11283 * fix: chats, allow multiple dropdowns like in harmony * chore: up harmony * refactor: flag note adding/editing, closes #11285 * fix: remove old prepareEdit logic * chore: add caveat about hacky code block in userFilter module * fix: placeholders for userFilter module * refactor: navigator so it works with multiple thumbs/navigators * chore: up harmony * fix: closes #11287, destroy quick reply autocomplete on navigation * fix: filter disabled categories on user categories page count * chore: up harmony * docs: update openapi spec to include info about passing in timestamps for topic creation, removing timestamp as valid request param for topic replying * fix: send back null values on ACP search dashboard for startDate and endDate if not expicitly passed in, fix tests * fix: tweak table order in ACP dash searches * fix: only invoke navigator click drag on left mouse button * feat: add back unread indicator to navigator * clear bookmark on mark unread * fix: navigator crash on ajaxify * better thumb top calculation * fix: reset user bookmark when topic is marked unread * Revert "fix: reset user bookmark when topic is marked unread" This reverts commit 9bcd85c2c6848c3d325d32027261809da6e11c9e. * fix: update unread indicator on scroll, add unread count * chore: bump harmony * fix: crash on navigator unread update when backing out of a topic * fix: closes #11183 * fix: update topics:recent zset when rescheduling a topic * fix: dupe quote button, increase delay, hide immediately on empty selection * fix: navigator not showing up on first load * refactor: remove glance assorted fixes to navigator dont reduce remaning count if user scrolls down and up quickly only call topic.navigatorCallback when index changes * more sanity checks for bookmark dont allow setting bookmark higher than topic postcount * closes #11218, :train: * Revert "fix: update topics:recent zset when rescheduling a topic" This reverts commit 737973cca9e94b6cb3867492a09e1e0b1af391d5. * fix: #11306, show proper error if queued post doesn't exist was showing no-privileges if someone else accepted the post * https://github.com/NodeBB/NodeBB/issues/11307 dont use li * chore: up harmony * chore: bump version string * fix: copy paste fail * feat: closes #7382, tag filtering add client side support for filtering by tags on /category, /recent and /unread * chore: up harmony * chore: up harmony * Revert "fix: add back req.query fallback for backwards compatibility" [breaking] This reverts commit cf6cc2c454dc35c330393c62ee8ce67b42d8eefb. This commit is no longer required as passing in a CSRF token via query parameter is no longer supported as of NodeBB v3.x This is a breaking change. * fix: pass csrf token in form data, re: NodeBB/NodeBB#11309 * chore: up deps * fix: tests, use x-csrf-token query param removed * test: fix csrf_token * lint: remove unused * feat: add itemprop="image" to avatar helper * fix: get chat upload button in chat modal * breaking: remove deprecated socket.io methods * test: update messaging tests to not use sockets * fix: parent post links * fix: prevent post tooltip if mouse leaves before data/tpl is loaded * chore: up harmony * chore: up harmony * chore: up harmony * chore: up harmony * fix: nested replies indices * fix(deps): bump 2factor * feat: add loggedIn user to all api routes * chore: up themes * refactor: audit admin v3 write api routes as per #11321 * refactor: audit category v3 write api routes as per #11321 [breaking] docs: fix open api spec for #11321 * refactor: audit chat v3 write api routes as per #11321 * refactor: audit files v3 write api routes as per #11321 * refactor: audit flags v3 write api routes as per #11321 * refactor: audit posts v3 write api routes as per #11321 * refactor: audit topics v3 write api routes as per #11321 * refactor: audit users v3 write api routes as per #11321 * fix: lang string * remove min height * fix: empty topic/labels taking up space * fix: tag filtering when changing filter to watched topics or changing popular time limit to month * chore: up harmony * fix: closes #11354, show no post error if queued post already accepted/rejected * test: #11354 * test: #11354 * fix(deps): bump 2factor * fix: #11357 clear cache on thumb remove * fix: thumb remove on windows, closes #11357 * test: openapi for thumbs * test: fix openapi --------- Co-authored-by: Julian Lam <[email protected]> Co-authored-by: Opliko <[email protected]>
2 years ago
assert(installed.includes(theme));
});
done();
});
});
it('should ban a user', async () => {
const apiUser = require('../src/api/users');
await apiUser.ban({ uid: adminUid }, { uid: regularUid, reason: 'spammer' });
const data = await user.getLatestBanInfo(regularUid);
assert(data.uid);
assert(data.timestamp);
assert(data.hasOwnProperty('banned_until'));
assert(data.hasOwnProperty('banned_until_readable'));
assert.equal(data.reason, 'spammer');
});
it('should return ban reason', (done) => {
user.bans.getReason(regularUid, (err, reason) => {
assert.ifError(err);
assert.equal(reason, 'spammer');
done();
});
});
it('should unban a user', async () => {
const apiUser = require('../src/api/users');
await apiUser.unban({ uid: adminUid }, { uid: regularUid });
const isBanned = await user.bans.isBanned(regularUid);
assert(!isBanned);
});
it('should make user admin', (done) => {
socketAdmin.user.makeAdmins({ uid: adminUid }, [regularUid], (err) => {
8 years ago
assert.ifError(err);
groups.isMember(regularUid, 'administrators', (err, isMember) => {
8 years ago
assert.ifError(err);
assert(isMember);
done();
});
});
});
it('should make user non-admin', (done) => {
socketAdmin.user.removeAdmins({ uid: adminUid }, [regularUid], (err) => {
8 years ago
assert.ifError(err);
groups.isMember(regularUid, 'administrators', (err, isMember) => {
8 years ago
assert.ifError(err);
assert(!isMember);
done();
});
});
});
describe('user create/delete', () => {
let uid;
const apiUsers = require('../src/api/users');
it('should create a user', async () => {
const userData = await apiUsers.create({ uid: adminUid }, { username: 'foo1' });
uid = userData.uid;
const isMember = await groups.isMember(userData.uid, 'registered-users');
assert(isMember);
8 years ago
});
it('should delete users', async () => {
await apiUsers.delete({ uid: adminUid }, { uid });
await sleep(500);
const isMember = await groups.isMember(uid, 'registered-users');
assert(!isMember);
8 years ago
});
it('should error if user does not exist', async () => {
let err;
try {
await apiUsers.deleteMany({ uid: adminUid }, { uids: [uid] });
} catch (_err) {
err = _err;
}
assert.strictEqual(err.message, '[[error:no-user]]');
8 years ago
});
it('should delete users and their content', async () => {
const userData = await apiUsers.create({ uid: adminUid }, { username: 'foo2' });
await apiUsers.deleteMany({ uid: adminUid }, { uids: [userData.uid] });
await sleep(500);
const isMember = await groups.isMember(userData.uid, 'registered-users');
assert(!isMember);
});
8 years ago
it('should error with invalid data', async () => {
let err;
try {
await apiUsers.create({ uid: adminUid }, null);
} catch (_err) {
err = _err;
}
assert.strictEqual(err.message, '[[error:invalid-data]]');
8 years ago
});
});
it('should load user groups', async () => {
const { users } = await socketAdmin.user.loadGroups({ uid: adminUid }, [adminUid]);
assert.strictEqual(users[0].username, 'admin');
assert(Array.isArray(users[0].groups));
});
it('should reset lockouts', (done) => {
socketAdmin.user.resetLockouts({ uid: adminUid }, [regularUid], (err) => {
8 years ago
assert.ifError(err);
done();
});
});
describe('validation emails', () => {
const plugins = require('../src/plugins');
async function dummyEmailerHook(data) {
// pretend to handle sending emails
}
before(() => {
// Attach an emailer hook so related requests do not error
plugins.hooks.register('emailer-test', {
hook: 'filter:email.send',
method: dummyEmailerHook,
});
});
after(() => {
plugins.hooks.unregister('emailer-test', 'filter:email.send');
});
8 years ago
it('should validate emails', (done) => {
socketAdmin.user.validateEmail({ uid: adminUid }, [regularUid], (err) => {
8 years ago
assert.ifError(err);
user.getUserField(regularUid, 'email:confirmed', (err, emailConfirmed) => {
8 years ago
assert.ifError(err);
assert.equal(parseInt(emailConfirmed, 10), 1);
done();
});
});
});
it('should error with invalid uids', (done) => {
socketAdmin.user.sendValidationEmail({ uid: adminUid }, null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should send validation email', (done) => {
socketAdmin.user.sendValidationEmail({ uid: adminUid }, [regularUid], (err) => {
8 years ago
assert.ifError(err);
done();
});
});
});
it('should push unread notifications on reconnect', (done) => {
const socketMeta = require('../src/socket.io/meta');
socketMeta.reconnected({ uid: 1 }, {}, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should error if the room is missing', (done) => {
io.emit('meta.rooms.enter', null, (err) => {
8 years ago
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should return if uid is 0', (done) => {
const socketMeta = require('../src/socket.io/meta');
socketMeta.rooms.enter({ uid: 0 }, null, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should join a room', (done) => {
io.emit('meta.rooms.enter', { enter: 'recent_topics' }, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should leave current room', (done) => {
io.emit('meta.rooms.leaveCurrent', {}, (err) => {
8 years ago
assert.ifError(err);
done();
});
});
it('should get server time', (done) => {
io.emit('admin.getServerTime', null, (err, time) => {
8 years ago
assert.ifError(err);
assert(time);
done();
});
});
it('should error to get daily analytics with invalid data', (done) => {
io.emit('admin.analytics.get', null, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should get daily analytics', (done) => {
io.emit('admin.analytics.get', { graph: 'traffic', units: 'days' }, (err, data) => {
assert.ifError(err);
assert(data);
8 years ago
assert(data.summary);
done();
});
});
it('should get hourly analytics', (done) => {
io.emit('admin.analytics.get', { graph: 'traffic', units: 'hours' }, (err, data) => {
assert.ifError(err);
assert(data);
8 years ago
assert(data.summary);
done();
});
});
it('should allow a custom date range for traffic graph analytics', (done) => {
io.emit('admin.analytics.get', { graph: 'traffic', units: 'days', amount: '7' }, (err, data) => {
assert.ifError(err);
assert(data);
assert(data.pageviews);
assert(data.uniqueVisitors);
assert.strictEqual(7, data.pageviews.length);
assert.strictEqual(7, data.uniqueVisitors.length);
done();
});
});
it('should return error', (done) => {
socketAdmin.before({ uid: 10 }, 'someMethod', {}, (err) => {
assert.equal(err.message, '[[error:no-privileges]]');
done();
});
});
it('should get room stats', (done) => {
io.emit('meta.rooms.enter', { enter: 'topic_1' }, (err) => {
assert.ifError(err);
socketAdmin.rooms.getAll({ uid: 10 }, {}, (err) => {
assert.ifError(err);
setTimeout(() => {
socketAdmin.rooms.getAll({ uid: 10 }, {}, (err, data) => {
assert.ifError(err);
assert(data.hasOwnProperty('onlineGuestCount'));
assert(data.hasOwnProperty('onlineRegisteredCount'));
assert(data.hasOwnProperty('socketCount'));
assert(data.hasOwnProperty('topics'));
assert(data.hasOwnProperty('users'));
done();
});
}, 1000);
});
});
});
it('should get room stats', (done) => {
io.emit('meta.rooms.enter', { enter: 'category_1' }, (err) => {
assert.ifError(err);
socketAdmin.rooms.getAll({ uid: 10 }, {}, (err) => {
assert.ifError(err);
setTimeout(() => {
socketAdmin.rooms.getAll({ uid: 10 }, {}, (err, data) => {
assert.ifError(err);
assert.equal(data.users.category, 1, JSON.stringify(data, null, 4));
done();
});
}, 1000);
});
});
});
it('should get admin search dictionary', (done) => {
socketAdmin.getSearchDict({ uid: adminUid }, {}, (err, data) => {
assert.ifError(err);
assert(Array.isArray(data));
assert(data[0].namespace);
assert(data[0].translations);
assert(data[0].title);
done();
});
});
it('should fire event', (done) => {
io.on('testEvent', (data) => {
assert.equal(data.foo, 1);
done();
});
socketAdmin.fireEvent({ uid: adminUid }, { name: 'testEvent', payload: { foo: 1 } }, (err) => {
assert.ifError(err);
});
});
it('should error with invalid data', (done) => {
socketAdmin.themes.set({ uid: adminUid }, null, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should set theme to bootswatch', (done) => {
8 years ago
socketAdmin.themes.set({ uid: adminUid }, {
type: 'bootswatch',
src: '//maxcdn.bootstrapcdn.com/bootswatch/latest/darkly/bootstrap.min.css',
id: 'darkly',
}, (err) => {
assert.ifError(err);
meta.configs.getFields(['theme:src', 'bootswatchSkin'], (err, fields) => {
assert.ifError(err);
8 years ago
assert.equal(fields['theme:src'], '//maxcdn.bootstrapcdn.com/bootswatch/latest/darkly/bootstrap.min.css');
assert.equal(fields.bootswatchSkin, 'darkly');
done();
});
});
});
it('should set theme to local persona', (done) => {
socketAdmin.themes.set({ uid: adminUid }, { type: 'local', id: 'nodebb-theme-persona' }, (err) => {
assert.ifError(err);
meta.configs.get('theme:id', (err, id) => {
assert.ifError(err);
assert.equal(id, 'nodebb-theme-persona');
done();
});
});
});
it('should toggle plugin active', (done) => {
socketAdmin.plugins.toggleActive({ uid: adminUid }, 'nodebb-plugin-location-to-map', (err, data) => {
assert.ifError(err);
assert.deepEqual(data, { id: 'nodebb-plugin-location-to-map', active: true });
done();
});
});
it('should toggle plugin install', function (done) {
this.timeout(0);
const oldValue = process.env.NODE_ENV;
process.env.NODE_ENV = 'development';
socketAdmin.plugins.toggleInstall({
uid: adminUid,
}, {
id: 'nodebb-plugin-location-to-map',
version: 'latest',
}, (err, data) => {
assert.ifError(err);
assert.equal(data.name, 'nodebb-plugin-location-to-map');
process.env.NODE_ENV = oldValue;
done();
});
});
it('should get list of active plugins', (done) => {
socketAdmin.plugins.getActive({ uid: adminUid }, {}, (err, data) => {
assert.ifError(err);
assert(Array.isArray(data));
done();
});
});
it('should order active plugins', (done) => {
const data = [
{ name: 'nodebb-theme-persona', order: 0 },
{ name: 'nodebb-plugin-dbsearch', order: 1 },
{ name: 'nodebb-plugin-markdown', order: 2 },
{ ignoreme: 'wrong data' },
];
socketAdmin.plugins.orderActivePlugins({ uid: adminUid }, data, (err) => {
assert.ifError(err);
db.sortedSetRank('plugins:active', 'nodebb-plugin-dbsearch', (err, rank) => {
assert.ifError(err);
assert.equal(rank, 1);
done();
});
});
});
it('should upgrade plugin', function (done) {
this.timeout(0);
const oldValue = process.env.NODE_ENV;
process.env.NODE_ENV = 'development';
socketAdmin.plugins.upgrade({
uid: adminUid,
}, {
id: 'nodebb-plugin-location-to-map',
version: 'latest',
}, (err) => {
assert.ifError(err);
process.env.NODE_ENV = oldValue;
done();
});
});
it('should error with invalid data', (done) => {
socketAdmin.widgets.set({ uid: adminUid }, null, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should error with invalid data', (done) => {
const data = [
{
template: 'global',
location: 'sidebar',
widgets: [{ widget: 'html', data: { html: 'test', title: 'test', container: '' } }],
},
];
socketAdmin.widgets.set({ uid: adminUid }, data, (err) => {
assert.ifError(err);
db.getObjectField('widgets:global', 'sidebar', (err, widgetData) => {
assert.ifError(err);
assert.equal(JSON.parse(widgetData)[0].data.html, 'test');
done();
});
});
});
it('should clear sitemap cache', async () => {
await socketAdmin.settings.clearSitemapCache({ uid: adminUid }, {});
});
it('should send test email', async () => {
const tpls = ['digest', 'banned', 'verify', 'welcome', 'notification', 'invitation'];
try {
for (const tpl of tpls) {
// eslint-disable-next-line no-await-in-loop
await socketAdmin.email.test({ uid: adminUid }, { template: tpl });
}
} catch (err) {
if (err.message !== '[[error:sendmail-not-found]]') {
assert.ifError(err);
}
}
});
it('should not error when resending digests', async () => {
await socketAdmin.digest.resend({ uid: adminUid }, { action: 'resend-day', uid: adminUid });
await socketAdmin.digest.resend({ uid: adminUid }, { action: 'resend-day' });
});
it('should error with invalid interval', async () => {
const oldValue = meta.config.dailyDigestFreq;
meta.config.dailyDigestFreq = 'off';
try {
await socketAdmin.digest.resend({ uid: adminUid }, { action: 'resend-' });
} catch (err) {
assert.strictEqual(err.message, '[[error:digest-not-enabled]]');
}
meta.config.dailyDigestFreq = oldValue;
});
it('should get logs', (done) => {
const fs = require('fs');
const path = require('path');
meta.logs.path = path.join(nconf.get('base_dir'), 'test/files', 'output.log');
fs.appendFile(meta.logs.path, 'some logs', (err) => {
assert.ifError(err);
socketAdmin.logs.get({ uid: adminUid }, {}, (err, data) => {
assert.ifError(err);
assert(data);
done();
});
});
});
it('should clear logs', (done) => {
socketAdmin.logs.clear({ uid: adminUid }, {}, (err) => {
assert.ifError(err);
socketAdmin.logs.get({ uid: adminUid }, {}, (err, data) => {
assert.ifError(err);
assert.equal(data.length, 0);
done();
});
});
});
it('should clear errors', (done) => {
socketAdmin.errors.clear({ uid: adminUid }, {}, (err) => {
assert.ifError(err);
db.exists('error:404', (err, exists) => {
assert.ifError(err);
assert(!exists);
done();
});
});
});
it('should delete a single event', (done) => {
db.getSortedSetRevRange('events:time', 0, 0, (err, eids) => {
6 years ago
assert.ifError(err);
events.deleteEvents(eids, (err) => {
6 years ago
assert.ifError(err);
db.isSortedSetMembers('events:time', eids, (err, isMembers) => {
6 years ago
assert.ifError(err);
assert(!isMembers.includes(true));
done();
});
});
});
});
it('should delete all events', (done) => {
events.deleteAll((err) => {
assert.ifError(err);
db.sortedSetCard('events:time', (err, count) => {
assert.ifError(err);
assert.equal(count, 0);
done();
});
});
});
describe('logger', () => {
const logger = require('../src/logger');
const index = require('../src/socket.io');
const fs = require('fs');
const path = require('path');
it('should enable logging', (done) => {
meta.config.loggerStatus = 1;
meta.config.loggerIOStatus = 1;
const loggerPath = path.join(__dirname, '..', 'logs', 'logger.log');
logger.monitorConfig({ io: index.server }, { key: 'loggerPath', value: loggerPath });
setTimeout(() => {
io.emit('meta.rooms.enter', { enter: 'recent_topics' }, (err) => {
assert.ifError(err);
fs.readFile(loggerPath, 'utf-8', (err, content) => {
assert.ifError(err);
assert(content);
done();
});
});
}, 500);
});
after((done) => {
meta.config.loggerStatus = 0;
meta.config.loggerIOStatus = 0;
done();
});
});
describe('password reset', () => {
const socketUser = require('../src/socket.io/user');
it('should error if uids is not array', (done) => {
socketAdmin.user.sendPasswordResetEmail({ uid: adminUid }, null, (err) => {
assert.strictEqual(err.message, '[[error:invalid-data]]');
done();
});
});
it('should error if uid doesnt have email', (done) => {
socketAdmin.user.sendPasswordResetEmail({ uid: adminUid }, [adminUid], (err) => {
assert.strictEqual(err.message, '[[error:user-doesnt-have-email, admin]]');
done();
});
});
it('should send password reset email', async () => {
await user.setUserField(adminUid, 'email', '[email protected]');
await user.email.confirmByUid(adminUid);
await socketAdmin.user.sendPasswordResetEmail({ uid: adminUid }, [adminUid]);
});
it('should error if uids is not array', (done) => {
socketAdmin.user.forcePasswordReset({ uid: adminUid }, null, (err) => {
assert.strictEqual(err.message, '[[error:invalid-data]]');
done();
});
});
it('should for password reset', async () => {
const then = Date.now();
const uid = await user.create({ username: 'forceme', password: '123345' });
await socketAdmin.user.forcePasswordReset({ uid: adminUid }, [uid]);
const pwExpiry = await user.getUserField(uid, 'passwordExpiry');
const sleep = util.promisify(setTimeout);
await sleep(500);
assert(pwExpiry > then && pwExpiry < Date.now());
});
it('should not error on valid email', (done) => {
socketUser.reset.send({ uid: 0 }, '[email protected]', (err) => {
assert.ifError(err);
async.parallel({
count: async.apply(db.sortedSetCount.bind(db), 'reset:issueDate', 0, Date.now()),
event: async.apply(events.getEvents, '', 0, 0),
}, (err, data) => {
assert.ifError(err);
assert.strictEqual(data.count, 2);
// Event validity
assert.strictEqual(data.event.length, 1);
const event = data.event[0];
assert.strictEqual(event.type, 'password-reset');
assert.strictEqual(event.text, '[[success:success]]');
done();
});
});
});
it('should not generate code if rate limited', (done) => {
socketUser.reset.send({ uid: 0 }, '[email protected]', (err) => {
assert(err);
async.parallel({
count: async.apply(db.sortedSetCount.bind(db), 'reset:issueDate', 0, Date.now()),
event: async.apply(events.getEvents, '', 0, 0),
}, (err, data) => {
assert.ifError(err);
assert.strictEqual(data.count, 2);
// Event validity
assert.strictEqual(data.event.length, 1);
const event = data.event[0];
assert.strictEqual(event.type, 'password-reset');
assert.strictEqual(event.text, '[[error:reset-rate-limited]]');
done();
});
});
});
it('should not error on invalid email (but not generate reset code)', (done) => {
socketUser.reset.send({ uid: 0 }, '[email protected]', (err) => {
assert.ifError(err);
db.sortedSetCount('reset:issueDate', 0, Date.now(), (err, count) => {
assert.ifError(err);
assert.strictEqual(count, 2);
done();
});
});
});
it('should error on no email', (done) => {
socketUser.reset.send({ uid: 0 }, '', (err) => {
assert(err instanceof Error);
assert.strictEqual(err.message, '[[error:invalid-data]]');
done();
});
});
});
it('should clear caches', async () => {
await socketAdmin.cache.clear({ uid: adminUid }, { name: 'post' });
await socketAdmin.cache.clear({ uid: adminUid }, { name: 'object' });
await socketAdmin.cache.clear({ uid: adminUid }, { name: 'group' });
await socketAdmin.cache.clear({ uid: adminUid }, { name: 'local' });
});
it('should toggle caches', async () => {
const caches = {
post: require('../src/posts/cache'),
object: require('../src/database').objectCache,
group: require('../src/groups').cache,
local: require('../src/cache'),
};
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'post', enabled: !caches.post.enabled });
3 years ago
if (caches.object) {
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'object', enabled: !caches.object.enabled });
}
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'group', enabled: !caches.group.enabled });
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'local', enabled: !caches.local.enabled });
// call again to return back to original state
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'post', enabled: !caches.post.enabled });
3 years ago
if (caches.object) {
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'object', enabled: !caches.object.enabled });
}
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'group', enabled: !caches.group.enabled });
await socketAdmin.cache.toggle({ uid: adminUid }, { name: 'local', enabled: !caches.local.enabled });
});
});