You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
a907ac43b9
This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.
In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)
This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".
If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.
Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.
Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
|
5 years ago | |
|---|---|---|
| .phan | 6 years ago | |
| i18n | 5 years ago | |
| includes | 5 years ago | |
| resources | 5 years ago | |
| screenshots | 8 years ago | |
| .eslintrc.json | 6 years ago | |
| .fresnel.yml | 6 years ago | |
| .gitignore | 6 years ago | |
| .gitreview | 8 years ago | |
| .phpcs.xml | 6 years ago | |
| .stylelintrc.json | 7 years ago | |
| CODE_OF_CONDUCT.md | 7 years ago | |
| Gruntfile.js | 6 years ago | |
| composer.json | 5 years ago | |
| package.json | 6 years ago | |
| skin.json | 5 years ago | |