Commit Graph

18 Commits (f7cf742c3c4cdb3f643d7d115f144f0209963df5)

Author SHA1 Message Date
Isarra f7cf742c3c Create getContentBlock function to get rid of some of the ridiculous indenting
Seriously, what the crap. Break this up a bit, shall we? Also probably means we might be able to extend this better, or something. (Not that I have any idea how that works.)

Change-Id: I2576d2244091aabcc973d9d4b7a3020d34f365f8
James D. Forrester 655b109bea build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Add `@param-taint $content escapes_htmlnoent` annotation to
TimelessTemplate::getPortlet(). See explanation on
Id8ef73f2efbe8d4d5510917d55dbac4e41b2b3a1.

Change-Id: I2fc96ed7876292dd6bd1e7f4fe799bdb6d8cdfd1
jenkins-bot 9481c431de Merge "Preserve standard username label to allow customisation"
Isarra 999ed40930 Preserve standard username label to allow customisation
Bug: T215822
Change-Id: If371deb02ea97478fd856aa4941c4715aaca7a11
Jack Phoenix fb690eeda4 Remove broken compatibility hack for the legacy SkinTemplateToolboxEnd hook
SkinTemplateToolboxEnd hook really shouldn't be used and extensions should have been using BaseTemplateToolbox hook instead, for that hook's been around since MW 1.18.

Also this code was broken because $boxes was undefined.

Change-Id: I34537e8eb6ec0109253b5470d12d12d86c4dada0
Isarra 12ec0fc69e Make page logs link actually work for page
Was using the page as th actor, not the target. Fixed.

bug: T163262
Change-Id: Idf9a9b3170d34df6c1685ccbc10986619a4afd9e
Isarra 03f01e242c Use default search placeholder
The custom one as-is is never going to actually be accurate due to
caching, with an implementation that was basically just a bad joke.
A more thoughtful implementation with rounding and stuff per the
winter prototype is probably in order, but that will require a
different implementation anyway (T182345)...

bug: T160647
Change-Id: Id2776d69a7d42b9907b4363977134fea48dc2440
Kunal Mehta ef01612ab6 Fix escaping issues with messages
Notably, content passed to Language::convert() needs to be escaped beforehand.

Spotted by phan-taint-check-plugin.

Change-Id: Id8a5f8bbe635e2f321882296e40dd0c41cf91a3b
Isarra 7df2db6ee9 Make afterContent stuff appear correctly after content in all view
modes

Mostly affects extensions that add stuff after the content with them
hook dealies, such as flaggedrevisions etc.

bug: T200729
Change-Id: I5c46af8f4cab20b04930a0e25d380ec040557bb6
Isarra 496997424d Add sitesub, but hide by default
Bug: T193215
Change-Id: Ia09ae2b763107d0bdc3c379525405e8edf17edb7
jenkins-bot 279ded1b51 Merge "Fix display of categories in the sidebar"
evad37 3139581560 Fix display of categories in the sidebar
Switching from a unique approach -- getting category names, querying
the database, and then building links -- to the standard
OutputPage::getCategoryLinks() fixes the display of redlinks (T175713),
display order (T197852), and perhaps other bugs in the subtasks
of T160645.

A downside to this approach is that categories will not be shown on
history pages, but this is consistent with other skins (e.g. Vector
and Monobook) not displaying categories on history pages.

Bug: T186089
Bug: T175716
Bug: T175714
Bug: T175713
Bug: T197852
Bug: T160645
Change-Id: Ifad999033e8448615128cba4d6386045a9fc749b
Isarra b76ae6c43a Attempt to fix overflow issues with hsc- and mb-style implementations
* display:flex for three-column
* float content and some voodoo for two-column (same as monobook)

Also had to slightly rearrange dom to make the latter work. Content
is now before nav in dom.

Change-Id: I7209eb21473877592d89f8471f8f8ed1f6b87851
Fomafix acce94cea4 Simplify message parameter handling
Change-Id: I1ca300e0ed857c7ea74c4bd1ade599cc38bae381
Kunal Mehta 95f038996e Don't use wfMessage()
Avoids GlobalTitleFail log entries.

Change-Id: I53462eed5d0513da0e1130a4776c0bb5c86f94b1
Bartosz Dziewoński 70b5f24986 Fix condition for 'emptyPortlet' class
Follow-up to 6b9616d1ca, which
accidentally inverted the logic.

Bug: T196026
Change-Id: I98bc7529a1894b09ec3d80aab244327f526c022c
Paladox 6b9616d1ca Fix $count to === against array instead of using count that fails
Bug: T195613
Change-Id: I3f38ae8f5f322c49639b23126f990854f6a6549f
Isarra 24c7182ae8 Move classes to includes/
Change-Id: I77862f0a451d4b742e762a3caedf032edd06485a