Commit Graph

300 Commits (d14a84a20b8e55b3f800206074fa452d0539a647)

Author SHA1 Message Date
jenkins-bot d745bb22f9 Merge "Remove nonfunctional jquery mobile stuff"
jenkins-bot 62556aa723 Merge "Revert "Redo width cutoffs to keep content wider and better match values elsewhere in mw""
Isarra 93c88a5df6 Revert "Redo width cutoffs to keep content wider and better match values elsewhere in mw"
Accidentally removed an unrelated thing; am too out of it right now to submit a followup putting that back.

This reverts commit 138036882f.

Change-Id: I1dcd0a887de8bc4423fc5e166e465873c1549a1a
jenkins-bot 093dba116a Merge "Reduce colours somewhat"
jenkins-bot 1af0eb9969 Merge "Redo width cutoffs to keep content wider and better match values elsewhere in mw"
Isarra 13d426907d Remove nonfunctional jquery mobile stuff
Does not appear to work, and is possibly breaking things elsewise as
well. In particular: chrome text selection in general, possibly iphone
support?

May or may not resolve the following; please test (does seem to 
effectively resolve T183215, for now, at least, but dunno at all about
the other two.):

Bug: T161470
Bug: T183215
Bug: T188387
Change-Id: I2d4aae98fe47bce5a873bc44b6cea58f111f5086
jenkins-bot 1e18f721a2 Merge "ToC: Use table layout for the toc"
Isarra 03b31d4d11 Reduce colours somewhat
* colour bar for header now only has number of colours equal to
  columns underneath it
* h1 and h2 now have grey underlines instead of blue

bug: T182388
bug: T132000
Change-Id: I883bcfa872d6306c04418230c3f7034e5ec9f188
Isarra 138036882f Redo width cutoffs to keep content wider and better match values
elsewhere in mw

* Bump max content width up to 125em because why not
* Make fixed-width padding a bit less
* Basically just follow WikimediaUI Base breakpoints as appropriate
  while keeping content similarly wide across devices

Bug: T165945
Change-Id: I8afb30bc1fb24907f94195b31289a664c050fcc4
Volker E 3e6d396dc1 Remove `text-shadow` from progressive mediawiki.ui buttons
Bug: T192303
Change-Id: If4023b2e5aff2635aba61b3bd9e1a280ed1c3908
Derk-Jan Hartman 7dfc75fec2 Move copyright and credits in seperate line of footer
This makes the footer more readable instead of a blob of characters

Change-Id: Ib2aa944082b775898c53fddc6ec577595e5e2759
Derk-Jan Hartman 700c82ec6a ToC: Use table layout for the toc
Table layout is much better in combinging wrapping, using as much
space as available and floating content at the same time.

This is similar to how we do this for all our skins

Change-Id: I23408d1aa6773af05f2ee197356a9b04feb524f0
Thiemo Kreuz c99492e63d Make Timeless aware of OOUI multiselect widgets
These OOUI widgets are special in so far that:

* OOUI makes the actual <input> element invisible and partly fails
  to do so because Timeless sets properties on <input>s that are not
  reset by OOUI.

* An outer <div> is styled like an <input> instead. Timeless is not
  aware of this and forgets to set it's overrides for <input>s there.

This patch is motivated by the AdvancedSearch extension which uses
these widgets, but is not limited to this.

This patch also does not fix all compatibility issues between Timeless
and these OOUI widgets, but greatly reduces the main issues. More to
come in later patches.

Bug: T192303
Change-Id: I8a4fc3f74dabdb54fd95cd133bb4fe28944c4a40
jenkins-bot 832672fbc9 Merge "Fix selflink styles"
Ebrahim Byagowi 142edcb27f [i18n] Fix icons issues of the skin on RTL
* Used nominal values of background-position so CSSJanus can apply
  CSS flipping correctly
* Added the missed RTL search icons, optimized SVG source of the
  LTR search icon, optimized PNG rsvg-convert result of both
  SVGs using optipng

Change-Id: I6a56f8ee448b60742b92d3613394a0d61b9235a1
evad37 9e6555a263 Fix indenting of subheadings in TOC
Reduce the specificity of TOC ul styles, so the existing rules
for indenting (with selector `.mw-content-ltr .toc ul ul`) are
applied. This matches the behaviour in other skins.

Bug: T190830
Change-Id: I84fd56c2baeaa218fb4fda493393f8c3d3ddd6cd
evad37 ce38e698a2 Fix selflink styles
Selflinks should inherit color and text-decoration styles, and
be bolded. This matches how they are displayed in other skins,
and how they were displayed before a change to mediawiki core
in MW-1.29 ( If058843924c3b30c116df2520aef93a004d98a5d ).

Bug: T192033
Change-Id: Id61f06a6b1921208d5436cb6e21f710413e990e9
jenkins-bot e7df4aa40f Merge "Make misc content styles selector less specific"
Isarra 208b2957ab Make misc content styles selector less specific
Bug: T192560
Change-Id: If98bb0e3cfe4aa182475363210dc56cb24f9e040
jenkins-bot 45116ea7a3 Merge "Prevent logo text overlapping icons on small mobile displays"
evad37 4eb3791bd4 Prevent logo text overlapping icons on small mobile displays
Puts the sitename logo text onto its own line, effectively, plus
some minor padding adjustments for aesthetics:
- Zero out padding-top so there isn't a big gap above;
- Add padding back below long names (which the `.long` class
  otherwise sets to 0) so there is a slight gap below.

Bug: T161461
Change-Id: I84fb41ec50f795446d9a8a3a08c4f67857d9908f
jenkins-bot 82f0eed394 Merge "Fix hiding of empty portlets on special pages"
evad37 b03a2a970f Fix hiding of empty portlets on special pages
* Increased selector specificy so that .emptyPortlet works on portlets within
  #mw-page-header-links
* Moved the `ca-more` dropdown, only shown on mobile, into a new portlet so that
  `p-views` is really empty on Special pages, and has class .emptyPortlet
* Moved languages dropdown, also only shown on mobile, into the new portlet too.
  This way on special pages the two dropdowns are in a single <ul> list with two
  items, rather than two adjacent list each with one item. Also, grouping the
  mobile-only items together means the desktop CSS only has to hide the portlet,
  rather than the individual ietms.

Bug: T182533
Change-Id: I496af1805d200e1fd67b1232e1b3b029b08b82ca
evad37 53f8532054 Add explicit padding and margins for all ul elements
The lack of such styles causes unwanted spacing on ul elements
that are not within `.mw-content-ltr`, most noticeably on the
watchlist (T181275) and search result pages (T181287).

Bug: T181275
Bug: T181287
Change-Id: I3402c3e297abbbbbcc19d69acee9808195c1f99a
jenkins-bot 0c87ff1557 Merge "Fix sidebar chunk spacing in two-column (desktop-mid) view"
jenkins-bot aafeb559da Merge "Middle aligne images with text"
Ed Sanders 29cabefee5 Fix default overlay selector
Change-Id: I2cd38050e201158a70f9557fb5466daaa294c061
Framawiki d5f416c4c0 Middle aligne images with text
Bug: T175890
Change-Id: I849e51a80d9a03e4ce8062cbaf9191a9d8d5508a
Ed Sanders b3c629ef4d build: Update linters
Change-Id: Iee462bae8112755e7cd0c5caa88c3fc6fcdc852e
evad37 a7fb239d57 Fix sidebar chunk spacing in two-column (desktop-mid) view
Set the top margin of #mw-related-navigation and its first sidebar chunk
to 0. This replicates the margin collapsing that occurs between other
sidebar chunks, so that all the gaps between sidebar chunks are the same
size.

Bug: T181256
Change-Id: I35b90383be8610412566e7367ecf25d771d4747c
jenkins-bot c971d2f24a Merge "OOjs UI: Display windows on top of the fixed header"
jenkins-bot c6d1a32e03 Merge "OOjs UI: Fix z-index and font size for default overlay"
evad37 3c3caeda7c Make languages portlet visible when empty
The languages portlet should always be visible so that the ULS
is always visible.

Bug: T181362
Change-Id: Icd89ccd28072758b9267906e5f4b72c39da5269d
Bartosz Dziewoński e705ce6d7f OOjs UI: Display windows on top of the fixed header
Workaround copied from Vector.

Bug: T183284
Change-Id: I7a4847f8d7c81e30610964762d6e591d753fa207
Bartosz Dziewoński 5b4508d644 OOjs UI: Fix z-index and font size for default overlay
OOUI dropdown menus should appear on top of the fixed header
and their font size should match the body text.

For example, on Special:MovePage:
* Before: https://phabricator.wikimedia.org/F12517634
* After:  https://phabricator.wikimedia.org/F12517632

Bug: T183069
Change-Id: I291d852f49507e58082ac95e59cb115170aa809a
jenkins-bot 9a1b390e5c Merge "Changes to portlets for greater compatibility with other skins"
SamanthaNguyen f473b850f9 Remove fake element created before links so background aligns correctly
This rule seems to no longer apply to the skin in it's current state,
and seems to be causing problems with references. These rules are an issue
for that it creates a fake block element (which adds extra spacing at the
top), creates a static height, and pulls it up with a negative top margin.

It seems best to remove this CSS block.

Bug: T181490
Change-Id: Id109e42731202f0c6e1ef6ff8855617e0795b35d
vlakoff 1ff3e9a8f7 Add some missing "noflip" directives for thumbs
Bug: T183783
Change-Id: I9722a155bf75b47ac8d18e844a7255a1e057a77c
evad37 212357d9b8 Changes to portlets for greater compatibility with other skins
Rename `pagetools` to `views`, `pageactions` to `cactions`, and
`cactions` from last commit back to `pagemisc`.
Make empty portlets available on page but hidden (display:none)
 with css class emptyPortlet, which can be removed by scripts
that add links to portlets (mw.util.addPortletLink already does
this).

Bug: T181362
Change-Id: I56d5b9df529abbdfead26cc46b8fe28935b417c3
jenkins-bot 630e31c446 Merge "Help icon is a bit weirdly aligned"
jenkins-bot 9d0525ddd8 Merge "Only add border to the primary thumb image"
Derk-Jan Hartman d6383bf713 No need for background color on the outside of thumbnails
Change-Id: Id7e38e3653ad0c53a41444926b7ba3157e13c2d2
Framawiki 3185eb1d42 Help icon is a bit weirdly aligned
Change margin of .mw-indicators

Bug: T173186
Change-Id: I614b54f3fb6097842703f383f1aed5c2c9c39a6a
Cormac Parle 5889423de3 Do not overwrite all background attributes with a color
Bug: T176010
Change-Id: I605675fe3ddb9fd3a83c513f8fdb2d104adb21dd
Isarra f1379fcd27 Put back stupid horrible overflow:auto to keep sidebars from
shoving down all content

Was removed from most boxes in 30ddb35f0; put it back here only
on mid- and full- content. No need for it on small.
Apparently I suck at reviewing shit.

Bug: T181323
Change-Id: Ic0bc08b9ba542ac16936c27e1dcdaca140fd51a2
Isarra bfa6e4a275 Merge "Revert "Remove brackets around new toctoggle""
Isarra adbab0e162 Revert "Remove brackets around new toctoggle"
This reverts commit 366f80701b.

Change-Id: I96e6cdf7739a21ed3a1d86fb37ee863d867d6dbb
Isarra 2d7547aabe Merge "Remove brackets around new toctoggle"
Derk-Jan Hartman 4af519be1f Only add border to the primary thumb image
Bug: T181211
Change-Id: Idf3d2fa88d5bf6c7244cf2bd1c32813b141fb845
Derk-Jan Hartman 580519342f Allow multiple mw-indicator side by side
Bug: T175894
Change-Id: I6ca0b1739ba8364ef64c92a6e05569a1da2c9c76
jenkins-bot f1c80b1b9f Merge "Remove 'overflow: auto' from .box() mixin"
jenkins-bot 9682b27739 Merge "Fix some small positioning/overflow things"
Isarra 29b0838989 Fix some small positioning/overflow things
* Echo icon positioning fix in rtl languages (thanks to RoanKattouw)
* Fix for header lines overlapping with floats (thanks to someone who...
  I don't actually remember, but they're absolutely lovely too)

Change-Id: I57825a7e7e06184f452cec69b15b484173b59413
Bartosz Dziewoński 30ddb35f06 Remove 'overflow: auto' from .box() mixin
I am pretty sure this is unnecessary in almost all places this mixin
is used, and at least one of them (for 'fieldset') is causing issues
(T181258).

The only place I am not pretty sure about is in the .nav-block()
mixin, so let's add it back there.

Bug: T181258
Change-Id: I77d34634d97b38712e74bc5f2227e42e9c49f18d
jenkins-bot 8e146c4d6c Merge "Styling for the <tt> tag"
jenkins-bot 83e4ccab47 Merge "Update jQuery Mobile to 1.5 (alpha)"
Fomafix 366f80701b Remove brackets around new toctoggle
I82db33d656 in core changes the toggle button of the TOC.
This change removes the brackets around the new toctoggle, too.

Depends-On: I82db33d656b3795d7134a91d20ed9d93a3471086
Change-Id: I4ebe356e266a93b2391650ac915940432e02f0ef
Jack Phoenix d013bf5cfc Custom styling for <pre> and <code> elements
Copypasted from core /resources/src/mediawiki.skinning/elements.css with
colors adjusted for Timeless.

Bug: T177142
Change-Id: Ic6d18911df4f1ea504ed547292676eac1ff54995
Jack Phoenix cb04db2039 Add some spacing and styling for #contentSub
The font-size is direct copypasta from MonoBook; on MonoBook #contentSub's
color is #54595d whereas here it uses the @grey-dark variable (which is
defined as the hex color  in variables.less).

Bug: T173951
Change-Id: Id57a3e2acab1f734b6a8ba65734c9d3d828d9ca7
jenkins-bot 9ca76ed5b7 Merge "Fix IE10/11 bug with the fixed header"
Ed Sanders 4291209afe VE: Fix font sizes and toolbar position
Change-Id: Ic34a4bca04a353572ed706e0ce990ea471837fb4
Bartosz Dziewoński 73a584b8af Update jQuery Mobile to 1.5 (alpha)
Downloaded from http://jquerymobile.com/download-builder/ with two modules:
* Core / Virtual Mouse (vmouse) Bindings
* Events / Touch

Local hacks:
* Replaced all .bind() calls with .on() to avoid jQuery Migrate warnings
* Replaced all .unbind() calls with .off() to avoid jQuery Migrate warnings

Bug: T165816
Bug: T174545
Change-Id: Icdcaf49c583f2f1380656cd0a0b6333ace0f1c53
Jack Phoenix 260725618e Fix IE10/11 bug with the fixed header
Apparently not defining the height property makes everything just plain
messed up, and to fix things, all you need is the height property that has
a value (other than "auto") of some kind.

Bug: T173769
Change-Id: Ie8c86e01c77b3f5de11c1bd7c6bf491c8ef0fb26
Jack Phoenix 7e956119b7 Styling for the <tt> tag
Bug: T175709
Change-Id: I7461f65ee11c0f68ac3e635a72d993c44a0cc1c6
Isarra 5570b3fdd9 Make Echo icons more likely to remain inline
Sometimes they wind up stacked vertically. They should be
horizontal. I don't know.

Change-Id: I92eaaa6c2e52944d818f042ea1bfed4a43ed0943
Isarra 1d2636dfdf Fix messed up recent changes/watchlist legends
Bug: T173151
Change-Id: Iedf0f7dd9d03ea43db6355ccc09fb731187abf60
Ed Sanders 58eaa7392e Remove overly-generic line-height selector
Change-Id: Ic672d49fe3337d5db065bca0e32f73e3fc4b01e9
jenkins-bot 650f5a5425 Merge "build: Resolve suppressed eslint warnings"
Timo Tijhof b925a9e1b0 build: Resolve suppressed eslint warnings
* Consistent string quoting style.
* Consistent spacing.
* Remove unused variables.

Change-Id: I6f78f1127c563ae3f81b6268eb896b2441ffd840
Bartosz Dziewoński 58e8c3d47d Use transparent for invisible borders of page navigation rather than white
This makes the effect better when you override page background color,
like we do on mediawiki.org e.g. on manual pages like
<https://www.mediawiki.org/wiki/Manual:Installation_guide>.

Change-Id: Ie863d11b19a56ab6cf75ff4b8dfcd2d74b69ce1d
Bartosz Dziewoński f11212f7bd Fix JQMIGRATE warnings in jQuery Mobile
jQuery Mobile 1.5 is supposed to be compatible with jQuery 3, but it isn't...

* Replace .bind() calls with .on()
* Replace .unbind() calls with .off()

Bug: T165816
Change-Id: I79639fd9ae8e6e785f93191273147866e52c4ed1
Umherirrender 77ff62c02c Add stylelint for css and less files
Fixed the following rules:
- number-leading-zero
- length-zero-no-unit
- string-quotes
- max-empty-lines
- selector-pseudo-element-colon-notation
- at-rule-empty-line-before
- at-rule-name-space-after
- media-feature-parentheses-space-inside
- color-hex-case
- declaration-block-semicolon-space-bef
- declaration-property-value-blacklist

Change-Id: Id0b43bff22b3f9ae9b912bd886e2da4c8576b165
Bartosz Dziewoński 26bf7c3c19 Make VisualEditor gutter area clickable
Code adapted from VisualEditor's ve.init.mw.DesktopArticleTarget-vector.css.

Bug: T162838
Change-Id: I828b97b060d631d7c86bff308802fb05c3dff781
Bartosz Dziewoński 51b9ba4eeb Remove workaround for T162493
Change-Id: Icb1f7632512b4a8fd0e2bf50035e40d3a89cd9bb
Isarra 9811d44774 Move echo styles to the correct module
Change-Id: I28af6af3d1fe4d2dca363175e430976bb3ab03ec
Isarra adf906a297 VE styles
Positioned toolbar properly for all modes.
Added icon to ve-edit, and new icon for edit source.
Yadda.

Toolbar does not work properly at low resolutions. This is a VE problem.
Cactions do not work with editor open. This is a VE problem.

bug: T161462
Change-Id: Ie5f4732f49f2dc365f5a3cc0c4b0e21444c21d1f
Isarra 1bb12ffaae Make variables for resolution boundaries
And some comments, or stuff.
Also bumped version number.

Change-Id: I4a4978e622eb82461573819992b19d5374bcc749
Isarra 8cb2458c99 Refactor TimelessTemplate.php
Structure is generally the same. All html is rendered into a
single variable, output with a single unholy 'echo'.

getPortlet is now more general, and generally used.

Should generally address the issues raised in T158011.
Should also be technically compatible with VE (DOM), but
without styling, and requiring the user to edit
LocalSettings.php (hopefully that gets fixed soon).
Fixed a slight bug with the languages rendering on mobile.

Some randomly missing things were added back in. (Variants,
some hooks)

bug: T161428
bug: T158011
bug: T132005
Change-Id: I3b691c8bfe7aed4a544236d5ac031b77ec4e8337
Isarra 10de923cd3 Move echo icons out of the personal dropdown
Lots of positioning weirdness, and the pokey was being
weird too.

Change-Id: Ia46c4f4cf0ce1c043c5506981b4ebc4b6dc4b5d1
Isarra 693aec5fdc Style and message tweaks
Maybe addresses T160647.

Change-Id: I4f6c73db6784415cdeca269321ba6f0f47c67551
Isarra 7f534ee46c Fix repeating background image on mobile
Class name was changed in html, forgot to make the mobile
stylesheet match.

Change-Id: I99802a56134280ea13264e86e50107cbb9fdca49
Isarra c583887ff4 QoL style fixes
* Added monospace font stack for metrics consistency with
  content/headers
* Fixed/styled search suggestions to work with header
* Added styles for hrs

Bug: T131996
Bug: T131993
Change-Id: I99aaaf6c55e375f847683909154a429e180b3dad
Isarra ec70f7df50 Fix horizontal scrollbar on special pages
Solution: fix .hidden mixin, per Alexander E. Patrakov's report

Bug: T131575
Change-Id: Id37fd9d243813cca9ea1630e5ef117ad87cf2050
Prateek Saxena f549d8b343 Remove styling for .mw-ui-primary
Follows-up I8ebea46c6e20bf81ce3cfc38b9f02651176db5be

Bug: T146923
Change-Id: I6341b7cab3b12f2d290941375fb4c557e5da6a73
Prateek Saxena 963e3018af Remove styling for .mw-ui-constructive
Bug: T146923
Change-Id: I8ebea46c6e20bf81ce3cfc38b9f02651176db5be
Isarra 3e6cf05412 Remove thingy
Change-Id: Ic72c8486558ffec58e46aaf9173bb844b76003da
Isarra 83b98586dd Add print styles, add 'mw' to page-header-links id
Bug: T131987

Change-Id: Ia14e7f26dd249e95d1bbe00437b8d1483be08fa5
Isarra f450f7e13b Make this thing responsive
And some other stuff too just because I ran into it on the way:
* Added indicators
* Fixed js in general
* Bumped version number
* Added some stupid hacks
* Cleaned stuff up
* I don't actually know

Change-Id: Ifa557c6f0f8a972d8986c3bffdfe08ddb4b39664
Isarra dc417173b1 Various improvements and fixes
* Consistent dark colours stolen from wikimediadc.org, probably stolen from
  that header template
* More consistent colours for headers
* Fixes for extension:templatesandbox
* pre and center rules, which for some reason aren't in core
* Fix for anchor offset issues caused by the fixed header
* Fixes for the personal dropdown menu
* Update font stack to use only ones with known consistent metrics

Change-Id: I88350e837b96de812c9d5f1308ae83703da6d0b4
Isarra 820154823c Make site title overflow less; add option to just change it for the skin
Just makes the font smaller if over a certain length. Not actually
smart. Will later add an option to replace it entirely with an image.

Change-Id: I7157c80132330c525ac2cb2027307550cee282b4
Isarra 6a25c68b2d Style changes, I don't know
Lowered font size, better menus (maybe), white header bar thingy with
colour

Probably other things.

Change-Id: Ia1b4c3ce0fed3752a9bae529573aa45912cb01ad
Isarra ff28a87f46 Turn this into more of a skin. Formatting, horror, more horror.
Thanks to Skizzers for the catlist db query.
Thanks to HORROR for the tool parsing.
Lots of css and stuff.

Change-Id: I9b6b4c2e3a206d909972929ae32777c933d0be46
Isarra 826140a6b0 Make dark footer
Also separated it from the content a bit, cleaned up the class names to
be more consistent, etc.

Change-Id: Ib0b3539ec112ef162c8d16e91bd805b884a2a502
Isarra a8c2913c26 Style search some more, add an icon
Change-Id: Id2ce1f3761f3948b647e638b5f130d5b5f9cc60a
Isarra a950d154b7 Everything is horrible.
Change-Id: Id35180435716a269edb45cab286ec178e9dd7791
Isarra 6056f7d586 Initial structure
Change-Id: I6457449db49ae1eef083684db75d5280bf404381
Isarra ade8feb066 Form stuff
Change-Id: I22e08ee082aa34e9fca6aacacdc9ae05c3707a15
Isarra ef37cd4298 Add some colour variables
Currently just used for text and links.

Unrelatedly, also some notes for the layout.

Change-Id: I3cb26e4eaf3c9d35fecf9899e817ba0df31084cb
Isarra 679bf418b3 Remove unneeded example styles
Change-Id: I773dbf3567acf9ca5343819575007229756e327e
Isarra 3a1bc368de Initial skin from skin:Example; just renamed
Change-Id: Ic60e93eff08abe541635e135faf04e60a756f44c