For you consideration. We will be aiming to do this in all Wikimedia
deployed skins so it would be great to have Timeless consistent with
those.
Change-Id: I11a8e0c8ca01b2c7eb2acc0b84ea4ad9301d3d8f
* Stop images from overflowing on desktop as well as mobile (folks wanna
overflow, they can load it sans skin, dammit)
* Firefox's stupid scrollbar colours
* Merge js into single module for desktop and mobile so it doesn't
randomly break on the wrong devices, and something about too many
modules anyway
* Weird footer padding?
* Weird WikiEditor/CodeMirror fonts/sizing
Bug: T256105
Bug: T247325
Change-Id: I8142c505534869c2530a915cfe8cef56303be6ed
Core now provides anon placeholder but Timeless has a
different treatment for the item and needs to unset this.
Bug: T263382
Change-Id: I0ba502a1e1368c1080caee2ce2bb45c27fdf77c3
I6e69b482cdbc adds a viewport with the same value as Timeless.
Also remove the SkinTimeless::$skinname override, as it is now set in
Skin::__construct.
Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: I215ac0153e5652e7ac76b11dba23a05aa2d1f685
Apparently getFooterBlock never actually made it into core, so copied
out of Example.
Bug: T254266
Change-Id: Id62319314937080b99f2b93fd7b7fa62527d8fe7
Use getAvailableLogos to retrieve wordmark and icon
wikimedia production has values for all projects for these values
TimelessLogo and TimelessWordmark continue to be supported for
3rd parties.
Bug: T231615
Change-Id: I2e4bc30c948b1bcb338f9d41774912b9afb320b4
Timeless is showing the language portlet correctly when are languages or
when something is added to the portlet, but it's also showing the header
even if there are no languages and nothing extra was defined.
The root cause is that when we check $this->afterLangPortlet !== '', the
property is actually null at that stage, it is only defined when we call
$this->getPortlet( 'lang' ...) in the next line.
Bug: T256355
Change-Id: Ie3e0acccede7e2f477c6182e288def8d7a35070e
Only does this with wordmarks; desktop devices are a lot less likely to merit this, and
the larger desktop logos are probably a rather bad idea to make unnecessarily large
anyway. Whereas the wordmarks should still be pretty small in terms of filesize as
they're going to be pretty simple, and are all we normally show on mobile.
Bug: T232540
Change-Id: I1932a99d8784eadf02f2711d9557425de0db0100
And put the position:relative on that. Keeps the sticky header out of
it, regardless, and let folks do their weird non-content voodoo on
stuff like the siteSub more consistently, I guess...
Bug: T231400
Change-Id: I7ac35f741210a0c54976f43d2294af8f123967a1
Basically, move a bunch of the logic to ProofreadPage itself, and only
do some timeless-specific reordering/styling as due to its Special
nature. Because timeless is Special.
Bug: T231250
Depends-On: Ifd8be387cef671b2aaa2a482c145bccf2e6d1543
Change-Id: I6fd7b648e459fee60569a06ffa1f0a5eb179c9ba
Currently js-only due to the default (only) vector styles requiring js. Fixed in
Ifd8be387cef671b2aaa2a482c145bccf2e6d1543, with a followup to clean up a bit after
that assuming that doesn't mess up too much to be merged, but this works regardless.
Bug: T231250
Change-Id: I4cadcbc3e51672fb075c884b2d2cc1d799b1b1b0
(Cap at single column or single-sidebar instead of the default three-
column mode.)
Adds user preference options and a $wgTimelessDefaultLayout config to
change the default wiki-wide. Intended for people who hate change and
prefer the same navigation layout (sort of) as we've had forever, and
for people who are really bad at change and just keep getting confused
when everything keeps moving around across different sized devices, as
well as anyone else who just likes... options, I guess? Whatever the
case, this is seriously up there in the running for 'most requested
feature'.
Uses three separate modules to avoid sending all users the same styles
twice regardless of what they'll even use, as each set is mostly the
same, just with slightly different breakpoints. Not seeing any saner
ways to do this, however, as even with LESS we can only use mixins/
includes/& afters to avoid the duplication in terms of what we work on,
not what is generated.
Bug: T131803
Change-Id: I0538d36c2ed7a5009b2a0f75952671ac9447fd56
Messed up a couple of things:
* Nojs variants toggle
* Order of sorting out language/project stuff fixed so it should correctly occur
Fixed.
Change-Id: I9a55848ca50884594035949e5aa855d98ddff77c
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc
Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.
For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
'1x' => $wgLogo,
'1.5x' => $wgLogoHD['1.5x']",
'2x' => $wgLogoHD['2x'],
'width' => 160,
'height' => 160
];
Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';
And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.
Fallback behaviour remains unchanged, if just not using these.
Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
Partially reverts I148707085059f458512d328c415ea0bf134163f3 plus some random
cleanup and stuff
Both of the following bugs involve wikibase stuff so I can't actually be entirely
sure this resolves them, but I thiiiink it does because it should be killing the
offending parts of the above change that caused this? Probably?
Bug: T231256
Bug: T231234
Change-Id: Id7c0d90a805450b577271a321572fcd552ecbc3e
Follows-up f450f7e13 and 1bb12ffaae which introduce and
explaine that module's need based on what I believe was a
misunderstanding.
Specifying an options object (e.g. with a "media" key) is optional
for a stylesheet, and a module can have any number of CSS or LESS
files that are packaged together. The syntax for this was designed
for PHP and unfortunately does not translate elegantly to JSON,
but it does work. In PHP, examples of this can be found that look
as follows:
'styles' => [
'foo.css',
'bar.css' => [ 'media' => 'print' ],
'quux.css',
],
Other examples of this in JSON can be found in Nostalgia.git
and ArticlePlaceholder.git.
Change-Id: Ie2a39a79c0892a1c5699a05071216eb5fe660bc1
This reverts commit c9e9bb97e2.
No longer needed due to I630410aea2852f7a72fea67bbf256b3561ea0f3f.
Change-Id: I179aa6c52da9452f39c9f816c58af44288604863
* Lose the special casing replacement labels for long usernames and
just truncate in CSS with '...' or whatever
* Fix weird padding on two-column mode
* Possibly cleaner Echo badge/whatever handling
* Alignment fixes in general
Note: Breaks two-column layout for IE9-. Probably easily fixed (don't
apply that one line to it), but I don't know how, and don't care.
Bug: T161282
Bug: T173215
Change-Id: I7d27e13265ee54767c509387baf6430bd7c4792d
No more need to add in an html pokey element every potential dropdown menu.
Aaaaaagh that made it bigger, didn't it.
Change-Id: I5d3817aa026849a5304710a32a3585f3e698321d
Hopefully saner access, also clears up some of the sidebar space.
Also forces moving the wikibase other-projects blob into its own
blob entirely.
Not done:
* Pokeys (need to migrate them all to css-only; later patch)
* Handling for no languages for wikidata stuff (may not be possible;
minerva likewise has no handling)
Bug: T213510
Bug: T181309
Change-Id: I148707085059f458512d328c415ea0bf134163f3
That one's newer, lets us do more. Appears to work fine as a drop-in replacement, as long as we add back the emptyPortlet class and kill some dead compatibility stuff.
Change-Id: Id531671eef97c670665aebed784eca41c0394ce8
Seriously, what the crap. Break this up a bit, shall we? Also probably means we might be able to extend this better, or something. (Not that I have any idea how that works.)
Change-Id: I2576d2244091aabcc973d9d4b7a3020d34f365f8
libraryupgrader
jdlrobson
Isarra
Ammar Abdulhamid
mainframe98
jenkins-bot
Umherirrender
AronDemian
James D. Forrester
C. Scott Ananian
Krinkle
Simon Legner