244 Commits (a3040bc185b1c194b8965b60bf7f1511f0208ef6)

Author SHA1 Message Date
Isarra c668fb91d7 Fix logo/sidebar alignment on two-column mode *properly*
Followup on Ib2a93fa0c24f693375fb8c959e77dd47c8087121

Change-Id: I166dc9c00bb8682735a15234d19eb5ca9151fe8a
6 years ago
Isarra 5e98906353 Make font smaller on OAuth approval dialog
Bug: T197910
Change-Id: I3f1c530b654d11a07f2d8715f8b8e69132aaf419
6 years ago
jenkins-bot 02e576ca43 Merge "Be more specific with form formatting" 6 years ago
jenkins-bot 89583faabd Merge "Prevent icon label overflow in focus state" 6 years ago
jenkins-bot 76b65f29c7 Merge "Slightly reduce header margins" 6 years ago
jenkins-bot 92dfb4d773 Merge "Add a margin for frameless images" 6 years ago
Isarra e217b0ace6 Prevent icon label overflow in focus state
...or something?

Bug: T174314
Change-Id: I3068cd1379ebbade93be784364101bad768a5dfc
6 years ago
Isarra 75a9284f16 Add a margin for frameless images
Might as well just reuse the thumb stuff, I guess.

Bug: T196356
Change-Id: Ic0497b2003bea9a5c739fd47858be545b16f2812
6 years ago
Isarra 01ab08e127 Be more specific with form formatting
Bug: T165928
Bug: T185193
Change-Id: Iedb5585554697796127895aa00c9b2f2c3216e17
6 years ago
Isarra 2c4196e5c1 Fix portlet layout for proper handling of non-ul content
For some reason the margin was on the ul, and I have no clue why.
Breaks stuff like wikibase, announcements, anything doing non-ul
portlet content, really.

Change-Id: I201a777547d8bd1b674c8c5d987ab77d4130bfcf
6 years ago
Isarra 133533a5dc Slightly reduce header margins
Slightly.

Bug: T197557
Change-Id: Ic222dd8588b701f34021aefa15b44108f26b477d
6 years ago
jenkins-bot ac37862646 Merge "Make personal menu header expand to show (more of) full usernames" 6 years ago
jenkins-bot 132deaf771 Merge "Fix logo/sidebar alignment on two-column mode" 6 years ago
jenkins-bot 3c317a8312 Merge "Fix fixed header scroll offset in supported browsers" 6 years ago
Isarra 2c526bfdbc Make personal menu header expand to show (more of) full usernames
* Lose the special casing replacement labels for long usernames and
  just truncate in CSS with '...' or whatever
* Fix weird padding on two-column mode
* Possibly cleaner Echo badge/whatever handling
* Alignment fixes in general

Note: Breaks two-column layout for IE9-. Probably easily fixed (don't
apply that one line to it), but I don't know how, and don't care.

Bug: T161282
Bug: T173215
Change-Id: I7d27e13265ee54767c509387baf6430bd7c4792d
6 years ago
Isarra d2fc86f919 Fix logo/sidebar alignment on two-column mode
(margins get lost/combined into larger one unless container... stuff;
on three-column flexbox takes care of this for us)

Change-Id: Ib2a93fa0c24f693375fb8c959e77dd47c8087121
6 years ago
jenkins-bot ad711f7b46 Merge "Fix positioning of dropdown icon for personal menu" 6 years ago
jenkins-bot 663c999fee Merge "Lose catlinks border on mobile" 6 years ago
Isarra e6b90747be Lose catlinks border on mobile
Just looks weird, yo.

Change-Id: I84308c7dde1961d8f2b821910cdd32c4462d5620
6 years ago
Isarra d844571796 Fix positioning of dropdown icon for personal menu
...why was that overflow:hidden even there?

Change-Id: I63a84acc9228baf214fc05c1e2896556d99398d1
6 years ago
Isarra 8a05fb1463 Fix fixed header scroll offset in supported browsers
Kill js solution even for other browsers because it doesn't even really
work to begin with. And I have no clue how to make it work, because I
can't find any examples that do, either.

Fixes current firefox and chrome. Users of old browsers/other
proprietary or whatever things can, uh, suffer, I guess.

Bug: T181484
Change-Id: Ic3415702eaa33cf56ed0b1fabf9ca607c88d1863
6 years ago
Isarra 2808c5c595 CSS-based pokeys
No more need to add in an html pokey element every potential dropdown menu.
Aaaaaagh that made it bigger, didn't it.

Change-Id: I5d3817aa026849a5304710a32a3585f3e698321d
6 years ago
Isarra 1d2a9583a5 Move variants and languages into page tools dropdowns
Hopefully saner access, also clears up some of the sidebar space.
Also forces moving the wikibase other-projects blob into its own
blob entirely.

Not done:
* Pokeys (need to migrate them all to css-only; later patch)
* Handling for no languages for wikidata stuff (may not be possible;
  minerva likewise has no handling)

Bug: T213510
Bug: T181309
Change-Id: I148707085059f458512d328c415ea0bf134163f3
6 years ago
Isarra 961be92230 Break up variables.less into mixins, themes, and general variables
Basically, file soup, but more sensible file soup, hopefully.

Change-Id: Ie2cc7b5b66368d3a03ae4490882335f7930929a7
6 years ago
Isarra b3af826b7d Make footer links blue
Difference between Accent90 and white/base90 is ridiculously subtle, but sure.

Bug: T214204
Change-Id: I1ac7860b5c22ec9b9dae8f4fa61db8d88e5a66ef
6 years ago
Isarra 52d3b3aac9 Use Wikimedia visual style colours
Possibly more consistent in general with the rest of wikimedia. Maybe. We're still using the colours rather differently, though.
Should also resolve some contrast issues we've had thus far. Maybe.
Breaking up the greys like this may or may not help with theming down the road. I'm not really sure.

Bug: T131992
Bug: T200320
Change-Id: I2757271066c54891e2b6e45b86e827f34af59435
6 years ago
Isarra 0af674dbc7 Kill some more stupid padding and add some comments
Bug: T197057
Change-Id: I44dca71602e7bdcb404e56df9274b8a86f410a6e
6 years ago
jenkins-bot 98aed3fb77 Merge "Remove brackets around new toctoggle" 6 years ago
Isarra 93e0ea991b Adjust a bunch of padding, especially mobile
bug: T197057
bug: T182389
Change-Id: I0fbbc037f32cd69375be9e0224967275a8fd9949
6 years ago
jenkins-bot e1f5fddb65 Merge "Fix Special:Watchlist options for no-JS" 6 years ago
Jack Phoenix 7fbdb43a3c Remove brackets around new toctoggle
I82db33d656 in core changes the toggle button of the TOC.
This change removes the brackets around the new toctoggle, too.

Depends-On: I82db33d656b3795d7134a91d20ed9d93a3471086
Change-Id: Id4d42d8e71c559f1e83ac7c1ab055f62654c240e
6 years ago
Jack Phoenix 3435ee25b1 Fix Special:Watchlist options for no-JS
Patch by putnik (see the Phab ticket) with tweaks by yours truly.

Bug: T225412
Change-Id: I23f05bc97929a196c62a0dc242ebace5c6fe45a0
6 years ago
Isarra 0340fb7048 Adjust line-height/padding for ToC items for better wrapping
Multiline items should now be clearly distinguishable from new
single-line items. On, like, mobile, or something. Not truly insane
pages I never should have created in the first place.

Change-Id: Ia0ea69519da865b76299b62ee94b33d3b0b60a94
6 years ago
Isarra c576c68a1f Add TimelessFileModule and $wgTimelessBackdropImage configuration
option to set configurable background image for the skin as a whole

Defaults to the cat, but can ideally be set to anything appropriate
to the wiki in question. Recommendation is a 20-50% opacity black/
white background image, where the alpha values of the b/w parts are
likewise around 10-50/255.

Bug: T193330
Change-Id: Ica3e2ce2568557ef157d06d1b7127b030f3c38f0
6 years ago
jenkins-bot 64ed4a2639 Merge "Redo cat with only black and white and lose png version" 6 years ago
Isarra 6f43b4a328 Move indicators up slightly
Hello, I'm Mr. Competent, reporting in for competency training.

Change-Id: I403c34bcd6322aeb9f319dca0944030a5050992d
6 years ago
Isarra 5d4b4c8249 Redo cat with only black and white and lose png version
Also made slightly bigger.

Change-Id: I91d41378d30ccb2439d44ccdc2caad646fcb9c37
6 years ago
Isarra 2a4fb34b63 New font stack, plus some generic forms and crap
Follow-up on https://gerrit.wikimedia.org/r/501850:
* new font stack stolen from phabricator and then rearranged a
  bit to be less ornery
* restored searchinput fonts and prodded some other alignment
  issues
* p-personal alignment issues maybe addressed, maybe made worse;
  cannot test windows/mac because don't have either of them or
  any remaining budget with which to purchase either of them
  because holy crap expensive
* some very basic generic form styles to align the base ones a
  tad more consistently
* dumb fix for dateinput widgets being mixed into otherwise
  non-ooui forms

Bug: T221345
Change-Id: I43312b23197ed1ce5ea9cb75fb0b8e8466bac6a1
6 years ago
jenkins-bot 38b1e653ce Merge "Remove unnecessary workaround for search suggestions dropdown" 6 years ago
Isarra 5c66a3e9c2 Hide empty list items
Bug: T192446
Bug: T181186
Change-Id: I5fa05dc6b4dbf61d585b456103fabd0ac44cd7ba
6 years ago
Isarra cc20454757 Style sitenotice
Note that this wraps localNotice in a box and may mess up custom
sitenotice css that does not expect a box to already be there.

Bug: T182517
Change-Id: I7d25017ba89cb833317aea61f9ea5f8f0a145df8
6 years ago
Isarra 28a6d31912 Remove a bunch of form stuff and adjust random things to compensate
* Remove most of the special styles; most things are migrated to ooui
  now, and that thing is soup, but at least mostly matches the skin
  anyway
* Kill the special snowflake content/monospace fonts; these were
  actually messing up the ooui styles more than anything else
* Also make body text smaller, headers bigger to more clearly
  differentiate between them, with some of the larger sans serif
  options people might wind up with
* Override some overrides. Let's override these and then override the
  overrides for the overrides, and add more overrides later?
* Make whole thing slightly wider, because sheesh, this is narrow
* Make toctoggle show up like how rclegend toggle does

Either affects or should resolve the following:

Bug: T207610
Bug: T211360
Bug: T188968
Bug: T196243
Bug: T204780
Bug: T207601
Change-Id: I767562e4bbc0a9cdf13db61ce3ed493322edc054
6 years ago
Bartosz Dziewoński b8426cad09 Remove unnecessary workaround for search suggestions dropdown
Bug: T210321
Depends-On: Iae795ef03d888c2b8cc1d5e7463c4692a7eeb138
Change-Id: Ib6d0b929c1c6200e5f2d3cb549a775d9c524c071
6 years ago
Jack Phoenix d9ba2d47d9 Properly center framed thumbnail images
Bug: T219717
Change-Id: I3a96ee7ab91a520258a1543236e7885f191aa82b
6 years ago
Paladox 28dc66bd2b Fix styles for .mw-body.dt and .mw-body.dl
Bug: T211044
Change-Id: I5b4b008cccc237d9c27f975cf5f11bff1ed6fe1e
6 years ago
Thiemo Kreuz dff12e2ce5 Manually optimize all SVG images
I applied a series of manual optimizations, most notably:
* Remove unused IDs.
* Remove attributes with standard values, e.g. opacity="1" is the
  default anyway.
* Remove attributes that don't have an effect, e.g. font styling
  where no fonts are used, or stroke attributes when there is no
  stroke anyway.
* Replace millimeters with pixels.
* I also tried to remove most translations. A lot of files had all
  their coordinates offset by -1032.362. I gave up for a few files.
  It might be worth looking into these later.
* brackets-grey.svg not only had a translation applied, but a
  non-standard viewBox as well. I wrote a tiny script to re-calculate
  all the numbers in this file. As a result it's much more crisp now.

Note that some of these optimizations might alter the appearence of
the image. I mean, they shouldn't, but better check each file manually
before merging this patch.

I did not touched the two files "cat-grey.svg" (I assume this is a
placeholder) as well as "editing icons.svg" (seems to be a temporary
file that should be removed).

Change-Id: Ie2dadef9d5979b563aa0ed0f5d8a69c534b76a4e
6 years ago
Volker E 94e7fe7f7f build: Add Grunt 'svgmin' task and crush SVGs
Adding 'grunt-svgmin' package and corresponding 'svgmin' task and
also crush SVGs. Additionally remove unnecessary attributes like
`version` & `id`s and Inkscape specific styles according to SVG
coding conventions.
Total savings about 75kB.

Change-Id: Id3a6e73d648693f21633fac123db0f26e6502a03
6 years ago
Volker E 715f75d9ea Reduce unnecessary selector specificity
Similar to Iae532d63893489.

Bug: T214218
Change-Id: Ied2ba7fa4ecf148d48b9b327397ff9d57b3752af
6 years ago
Volker E a2474c82fd build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I156dbb3a029696ed0ac3209be455547cd73048c3
6 years ago
Isarra 5d52d91a61 Add offset for # links to work around fixed header on desktop
Prevent anchors from putting headers, cite notes, etc behind fixed
header when jumping around. Use js to avoid previous issue of mucked
up highlighting... (T162649)

bug: T181484, T162649
Change-Id: I6bdb450b24df50f39e14bc2b254c6adb6cc7f7d7
6 years ago
Volker E 4de5631a10 Remove unused '.mw-ui-checked' class
Similar to I7a03215fae0b17.

Change-Id: Id77be290bdf436a1c88d6322f1905f1e122f9601
6 years ago
Ed Sanders d1b54f2b70 Remove obsolete aliases from closures
Bug: T208951
Change-Id: I0949da208d4df1d2fd1f85541f55f092da527400
6 years ago
Volker E df234f8177 Remove obsolete Special:Preferences styles after its transformation to OOUI
These removed styles match no elements in the
Special:Preferences page since the OOUI transformation.

Bug: T208923
Change-Id: I27918a66751c40a52d7a54be9be6f77d05bbfc15
6 years ago
jenkins-bot c1d8fabd80 Merge "Add thumb magnify icon" 6 years ago
Isarra e770804da5 Add thumb magnify icon
bug: T181144
Change-Id: I38e250557688707ed9fb43bf30b4a48683e76a27
6 years ago
Isarra a2e3b727bb Don't hide labels for mobile cactions that have no icon
Not necessarily ideal handling in terms of making things fit, but
should at least avoid issues of there being no things at all, which
is even worse.

bug: T202213
Change-Id: I1aeeddbcac838b475372691d8d76c72018f85787
6 years ago
jenkins-bot f5255a78e9 Merge "Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation" 7 years ago
jenkins-bot 69ab515b05 Merge "Make mw-echo-alert (yellow new message link) line up properly with rest of user dropdown things" 7 years ago
jenkins-bot f8d5f4b374 Merge "Prevent page indicators from interfering with firstheading and causing overflow" 7 years ago
jenkins-bot 22c70cc8fb Merge "Less: Linebreaks everywhere, some cleanup" 7 years ago
jenkins-bot bf91c0f2ec Merge "More consistent .center and toc alignment rules with other skins" 7 years ago
jenkins-bot e10af0fad3 Merge "Make navigation block text stay inside blocks/break-word" 7 years ago
jenkins-bot cd2c4269f3 Merge "Language links box should not have an unnecessary scrollbar" 7 years ago
Isarra 147a0349b7 Prevent echo labels from overflowing over the personal
dropdown and interfering with the hover activation

Change-Id: I98ef872931cf5fa5cb56dba83284dbb02a521a27
7 years ago
Isarra 187dccee9d Make mw-echo-alert (yellow new message link) line up
properly with rest of user dropdown things

Also resolves issues with multiline messages.

bug: T202226
Change-Id: I5635511c4dd51d82fba55dc2c8ef1ca79104993d
7 years ago
Isarra e184ac17bc Less: Linebreaks everywhere, some cleanup
Removed a rule or two.
Also removed the notes file, no longer relevant.

Change-Id: Icc28d3d95ea45e845e29895cfa8044b03ca6258b
7 years ago
Alangi Derick 734a7f7222 Set tabindex to 1 for the search box in Timeless skin
When using the Vector skin, and you load a page and press the tab
button on the keyboard once, the cursor focus on the search box,
this is handy and now available on the timeless skin too.

Also, removed target "mobile" as "jquery.tabIndex" dependency doesn't
use it.

Bug: T201424
Change-Id: I6e5d96371b5342ad2d3a207e980ec1fcf7e2de99
7 years ago
jenkins-bot 980d437ca4 Merge "Prevent content stuff from overlapping over nav stuff" 7 years ago
Isarra 16e3901843 Prevent page indicators from interfering with firstheading and
causing overflow

Change-Id: I381a6b29afd91b799278d19316e4c74d358cd14c
7 years ago
Isarra 74008ce3cb More consistent .center and toc alignment rules with other skins
Change-Id: I9005ed11bf2c70880088cfa41f7f6ebca974eb34
7 years ago
jenkins-bot 312e11f64a Merge "Stop some of the pointless overflows in three-column mode" 7 years ago
Isarra 2e65928731 Make navigation block text stay inside blocks/break-word
bug: T201128
Change-Id: I52a858a0940a49e462d9a98add61ffa792829501
7 years ago
Isarra 967f28a7d9 Stop some of the pointless overflows in three-column mode
Essentially: Tell flex it can shrink the content, too, with some
weird voodoo.

bug: T201126
Change-Id: Ic54dd9b7d499d0be6653767525cc2015350c8ed7
7 years ago
Isarra 557999259e Prevent content stuff from overlapping over nav stuff
bug: T200148
Change-Id: I573eb5cec1a5e45a63d833d97b6dc789f1e3f093
7 years ago
jenkins-bot c34125ba65 Merge "Make afterContent stuff appear correctly after content in all view modes" 7 years ago
jenkins-bot 475f1e334e Merge "Remove brackets around new toctoggle" 7 years ago
Isarra 7df2db6ee9 Make afterContent stuff appear correctly after content in all view
modes

Mostly affects extensions that add stuff after the content with them
hook dealies, such as flaggedrevisions etc.

bug: T200729
Change-Id: I5c46af8f4cab20b04930a0e25d380ec040557bb6
7 years ago
evad37 5b24402ead Fix positioning of content in desktop-small view
Bug: T200494
Change-Id: Ieb9f2123589b5abf49d02eb3d8be62d4064b7398
7 years ago
Fomafix 52aedca543 Remove brackets around new toctoggle
I82db33d656 in core changes the toggle button of the TOC.
This change removes the brackets around the new toctoggle, too.

Depends-On: I82db33d656b3795d7134a91d20ed9d93a3471086
Change-Id: I7a9fa9f3a630901d736331ecef2c43e3ab918d03
7 years ago
jenkins-bot 2193f84068 Merge "Make some more css rules less specific (classes instead of ids)" 7 years ago
Isarra a089f68290 Make some more css rules less specific (classes instead of ids)
Change-Id: Icc86a9a48ff9bd3b1236e9f05851c9e23208c15b
7 years ago
jenkins-bot 878f953208 Merge "Add sitesub, but hide by default" 7 years ago
jenkins-bot e492c51428 Merge "Make tocnumbers grey" 7 years ago
Isarra d419c24a43 Make tocnumbers grey
Bug: T181180
Change-Id: I1d0c627db703d6994884638726b283e89cb49c0a
7 years ago
Jean-Yves Le Gallou b492345c2b Add missing border on plain pictures with border option
Bug: T183718
Change-Id: I1a5182b2d743e4b6ade76d9fa7b0cb8122b343ce
7 years ago
Isarra 496997424d Add sitesub, but hide by default
Bug: T193215
Change-Id: Ia09ae2b763107d0bdc3c379525405e8edf17edb7
7 years ago
Isarra 22f888ccc5 Set firstHeading overflow to be more consistent with other skins
overflow:visible so line goes properly under indicators, help
thingies, wikipedian user icon spam, etc.

Change-Id: I5d626884b13449b8d1351fe4e9a94b3ee99baf80
7 years ago
jenkins-bot e6ee373bcb Merge "Attempt to fix overflow issues with hsc- and mb-style implementations" 7 years ago
Isarra b76ae6c43a Attempt to fix overflow issues with hsc- and mb-style implementations
* display:flex for three-column
* float content and some voodoo for two-column (same as monobook)

Also had to slightly rearrange dom to make the latter work. Content
is now before nav in dom.

Change-Id: I7209eb21473877592d89f8471f8f8ed1f6b87851
7 years ago
jenkins-bot 40510ef517 Merge "Display notifications in echo callout for mobile view" 7 years ago
evad37 8e19c79578 Display notifications in echo callout for mobile view
Override the inline style `width: 0px` on .oo-ui-clippableElement-clippable
elements within .mw-echo-ui-overlay.

Also adjust some other styles for the callout, so that it stays within the
screen width, but is not any wider than it would be otherwise (500px).
Doing so causes the anchor triangle at the top to not align with the
relevant notifications icon, so it is hidden with `display:none`.
(On a narrow mobile screen, it doesn't seem to serve much purpose anyway.)

Bug: T197064
Change-Id: Iaedde85b5c31ab244d4f72c54c9aad6a1b4ebb73
7 years ago
Jack Phoenix 43d2b1a7a2 Language links box should not have an unnecessary scrollbar
Bug: T181491
Change-Id: I23c778d61208238079a7badd301b9a31e929329b
7 years ago
RileyBugz 964849e117 I fixed the alignment of the TOC's header so that it would align with the hide/show button.
Change-Id: I88cc2c84a19f443bd3c749b7729ac0b7b6f74c2c
7 years ago
Paladox 5a0ed3efe1 Fix sidebar closing on iOS
this follows this fix [1]

[1] https://stackoverflow.com/questions/11397028/document-click-function-for-touch-device

Bug: T161470
Change-Id: I20e6a0e18a239131b94e4ab949b7784f241e4d40
7 years ago
jenkins-bot d745bb22f9 Merge "Remove nonfunctional jquery mobile stuff" 7 years ago
jenkins-bot 62556aa723 Merge "Revert "Redo width cutoffs to keep content wider and better match values elsewhere in mw"" 7 years ago
Isarra 93c88a5df6 Revert "Redo width cutoffs to keep content wider and better match values elsewhere in mw"
Accidentally removed an unrelated thing; am too out of it right now to submit a followup putting that back.

This reverts commit 138036882f.

Change-Id: I1dcd0a887de8bc4423fc5e166e465873c1549a1a
7 years ago
jenkins-bot 093dba116a Merge "Reduce colours somewhat" 7 years ago
jenkins-bot 1af0eb9969 Merge "Redo width cutoffs to keep content wider and better match values elsewhere in mw" 7 years ago
Isarra 13d426907d Remove nonfunctional jquery mobile stuff
Does not appear to work, and is possibly breaking things elsewise as
well. In particular: chrome text selection in general, possibly iphone
support?

May or may not resolve the following; please test (does seem to 
effectively resolve T183215, for now, at least, but dunno at all about
the other two.):

Bug: T161470
Bug: T183215
Bug: T188387
Change-Id: I2d4aae98fe47bce5a873bc44b6cea58f111f5086
7 years ago