141 Commits (a171d3d02f19a86ca9716c6ccfbbb30314e820ee)

Author SHA1 Message Date
Ed Sanders c5b46fce8b Support mw-show-empty-elt added in core
Bug: T295984
Depends-On: Ife0e908edc12b2eb04c5f0b4def969ce843606a0
Change-Id: I1369b8a344afdfc57603df5b1bbefa4110045644
3 years ago
Ed Sanders a091a3878b Use full selector for mw-empty-elt
Change-Id: I20d368d79459d953e62c4b0fae6fe9025ad37b9e
3 years ago
jenkins-bot a902b96e11 Merge "Prevent overflowing non-content images from exploding all over the place" 4 years ago
Isarra 9c254a9a1c Support mw 1.36/1.37: Disable all skin features except for a couple
in favour of mw 1.34 shared.css to avoid weird inconsistent visual
styles

Inconsistencies include: monobook-style boxes, random text resizes,
miscellaneous inappropriate colours, unexpected centering of text

Use 'toc' even though it also has weird monobook box styles because
the less/js/rl/php soup for the collapsing is basically a labyrinth
and I can't replicate that; just override everything back to
basically how it's supposed to be, style-wise.

Incidentally resolves T239914 for timeless due to also overriding
toccolours styles that come with the toc feature.

Also include a fork of commonPrint.css as an accompaniment to
shared.css, which willl now hilariously go full-monobook. Ish.

TODO: Don't just use an entire copy of 1.34's shared.css and
commonPrint.css as a workaround, and come up with a better
approach to the toc maybe? (T280747)

Bug: T280285
Bug: T280292
Bug: T239914
Change-Id: I2d600a7d9768942b331f0de1dd1183e438144ad5
4 years ago
Isarra 05338215b4 Prevent overflowing non-content images from exploding all over the
place

Use mw-body-content, that makes more sense, assuming we can get it
off the stupid indicators. (Why?!)

Bug: T279951
Depends-On: I785bd09d01e3b004df2f0fb898d7d8f28180501c
Change-Id: Ica58593dbdb2b36004ba1343f91c6c12476d871e
4 years ago
Isarra 89baa82860 Fix more small things
* Put hover underline back on links, because wikimedians hate change
  and also why not the entire point of the skin is to troll people,
  let's do it right
* Adjust link colours for better distinction between hover, visited,
  external
* Remove text labels from some obvious cactions (history,
  addsection) so they're all more likely to fit on stupid pages
* Don't show empty languages toggle on mobile
* I'unno, catnip.

Bug: T181177
Bug: T181192
Bug: T265205

Change-Id: I6256d9e27d6019944987db62432b1b324d5c4b38
4 years ago
Isarra a75d3c698e Adjust .mw-indicators alignment
* Move images up to match helplink positioning, assuming standard
  size of 20px
* Remove mobile header clear and let the float itself sort it out
  if it even is long enough to matter (most are just icons)

Bug: T269550
Change-Id: Iaddab576b208f927c51c8f64b3e601fd89c0d710
4 years ago
jenkins-bot e4cc6b19f8 Merge "Give up entirely on firefox' stupid 'smart' scrollbars" 4 years ago
Isarra 82dd36d910 Give up entirely on firefox' stupid 'smart' scrollbars
YOU WANNA NOT MATCH THE CONTENT IN THE NAME OF MATCHING THE CONTENT,
FINE. I WON'T STOP YOU. FECKING AAAAARGH.

Because just feckin' matching the interface theme for top-level ones
would have made waaaaay too much sense... or, I dunno, taking the
average of *visible* backgrounds on the page to see if it's overall
light or dark...

But nope. Let's just use the body background, which is usually
entirely covered up anyway. How could that possibly go wrong?!

Change-Id: Ib31030815c947622aaad6340fbafbd6103fef21f
4 years ago
Isarra 5cc9d503ff Make tables full-width on mobile, fix weird internal borders
Apparently tables inside of tables are thing, too...

Change-Id: I5c37d2ee2bc42d01f124301038300bc2e1dee81c
4 years ago
Isarra d5783ccf3b Limit image overflow limits to not tables
Avoid breaking legacy templates. What other templates were affected,
though? Was it just tables? Hopefully it is...

Bug: T181321
Bug: T269970
Change-Id: I2ce7d7b4344cc1b056feb99e47bd7f99959df454
4 years ago
Isarra d94a012f9d More stupid fixes
* Actually make firefox's 'smart' scrollbars semi-cooperate, maybe
* Saner .center styles
* Add mw_metadata to table styles

Change-Id: If14b551e4bd52240748a7681be38ebfe56bebc09
4 years ago
Isarra 5e2291df6d Fix some annoying things
* Stop images from overflowing on desktop as well as mobile (folks wanna
  overflow, they can load it sans skin, dammit)
* Firefox's stupid scrollbar colours
* Merge js into single module for desktop and mobile so it doesn't
  randomly break on the wrong devices, and something about too many
  modules anyway
* Weird footer padding?
* Weird WikiEditor/CodeMirror fonts/sizing

Bug: T256105
Bug: T247325
Change-Id: I8142c505534869c2530a915cfe8cef56303be6ed
4 years ago
Sam Wilson d2fa06a669 Add half-filled star for expiring watched pages
This will only work with recent versions of core, but will not
give an error for older versions that don't have the
'mw-watchlink-temp' class.

Bug: T258674
Change-Id: Ia3d7732160dd0d8358ed12bd2c7ad08db16aa773
5 years ago
jenkins-bot 3a8da90698 Merge "Use getFooterBlock instead of getFooter to avoid weird overflows on mobile" 5 years ago
Isarra b46ff19b3f Use getFooterBlock instead of getFooter to avoid weird overflows on mobile
Apparently getFooterBlock never actually made it into core, so copied
out of Example.

Bug: T254266
Change-Id: Id62319314937080b99f2b93fd7b7fa62527d8fe7
5 years ago
jenkins-bot f05aac7a58 Merge "Replace deprecated `background-image-svg()` mixin calls" 5 years ago
Volker E 3963c99c5d Replace deprecated `background-image-svg()` mixin calls
Use normal `background-image` properties with SVGs now
that IE 8 and Android 2.1 is removed from Grade C.
Also removing all PNG fallback images.

Bug: T248062
Change-Id: I27d95241b6512f36985f7269122802d7b0962042
5 years ago
AronDemian 73388405c3 Add and use `.mw-footer` & `.mw-footer-container` CSS classes
Adding `.mw-footer` & `.mw-footer-container` CSS classes & replacing 
`#mw-footer`,`#mw-footer-container` selectors with them.

`#mw-footer` & `#mw-footer-container` ids are kept for JS, gadgets 
compatibility and backwards compatibility with user styles.

Bug: T248137
Change-Id: I6e262cb5fa1838a22c3c6de8866d0324e83f84b3
5 years ago
AronDemian cb421b75b5 Remove `background:` rule from table cells to enable row background-color overrides in wikitext.
Row background falls back to table's background (same), consistent with Vector skin's behaviour.

Bug: T238482
Change-Id: I8bb955265f0ca189d1e6890065a5db510ceac612
5 years ago
Kunal Mehta 7e8fe12c11 build: Updating npm dependencies
* grunt-stylelint: 0.10.1 → 0.13.0
* stylelint-config-wikimedia: 0.5.0 → 0.8.0

Additional changes:
* Committed package-lock.json (T179229) too.

Change-Id: I6e0066edb40ac0f027421d46f51d0c730503a04f
5 years ago
Isarra 97850166de Normalise some pre styles that just look odd
* Remove Liberation Mono from font stack; comes out excessively light on
  hidpi chrome, to the point of unreadability (and probably is not a local
  config problem beyond merely having it installed at all, as chrome
  overrides normal font rendering settings regardless)
* Kill double border on pre styles; doesn't match other such boxes (notice,
  warning, whatever)

Change-Id: I7a95931bd6af4efc880c3ee8f37a91d61f3e6539
5 years ago
jenkins-bot 30505c31e5 Merge "Create wrapper for all junk below firstHeading, including nav stuff" 5 years ago
jenkins-bot 6ff15a1192 Merge "Prevent thumbnails from overflowing their backgrounds when coupled with random other floats where they don't fit" 5 years ago
jenkins-bot fce278717e Merge "Prevent edtisection icons from getting clipped" 5 years ago
Isarra 62c2eb0760 Create wrapper for all junk below firstHeading, including nav stuff
And put the position:relative on that. Keeps the sticky header out of
it, regardless, and let folks do their weird non-content voodoo on
stuff like the siteSub more consistently, I guess...

Bug: T231400
Change-Id: I7ac35f741210a0c54976f43d2294af8f123967a1
5 years ago
Isarra 359825a088 Prevent edtisection icons from getting clipped
Not an issue in most fonts, but some padding should prevent it more consistently regardless.

Change-Id: Ib8b8daeb8288044d3b85b0d6b4c9e86ea70993f9
5 years ago
Isarra e8824f4bd7 Prevent thumbnails from overflowing their backgrounds when coupled with random other floats where they don't fit
Example:
https://en.wikipedia.org/w/index.php?title=Goose_River_(Belfast_Bay)&oldid=893300681

Change-Id: I7b4c78304c57a32f9ac4684b21a6b70d3f61a7c8
5 years ago
Isarra 0af345adfe Prevent long sitenames from overflowing out of column and stuff
Missed some max-width stuff with the flex.

Bug: T232411
Change-Id: Idb1ebd8c33ade90b1a3d165c04c63e1dcfd7bb95
5 years ago
Isarra 91634606e7 Consolidate and make monospace styles more consistent
* Less stark borders
* Add font stack for monospace (ugh)

Change-Id: Ic3a1dc9ead32a30c95ff1573f2054cf68c8cd3bc
5 years ago
Isarra 321037f1c5 Increase filetoc contrast, make it stand out more
Why were we even killing the border to begin with?

Change-Id: I963f41c245f5911ddd7d8ddc5888402dee20fc57
5 years ago
Isarra b5df43b3e2 Add a min-height to thumbcaptions so magnify icon doesn't overflow
Change-Id: Ic033553e26f3ae4fd330ba501ec6a886e108685c
6 years ago
Isarra 808c317293 Clean up and/or optimise icons a bit
* svgo on everything
* Line up some pixel borders more
* Use transparent for the grey amount
* Fix a couple of overflows on icon css

Change-Id: Ic56b65d71ae08cf71048ad5efdfa7e65a749f680
6 years ago
Isarra a4900353b1 Use flex for logo container width and to show some username on small screens
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc

Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
6 years ago
Isarra f0fc1a4362 Custom logo rendering, including text wordmark images
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.

For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
	'1x' => $wgLogo,
	'1.5x' => $wgLogoHD['1.5x']",
	'2x' => $wgLogoHD['2x'],
	'width' => 160,
	'height' => 160
];

Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';

And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.

Fallback behaviour remains unchanged, if just not using these.

Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
6 years ago
Isarra 8bca35dec0 Put languages back in sidebar on desktop
Partially reverts I148707085059f458512d328c415ea0bf134163f3 plus some random
cleanup and stuff

Both of the following bugs involve wikibase stuff so I can't actually be entirely
sure this resolves them, but I thiiiink it does because it should be killing the
offending parts of the above change that caused this? Probably?

Bug: T231256
Bug: T231234
Change-Id: Id7c0d90a805450b577271a321572fcd552ecbc3e
6 years ago
Isarra e0d18e3298 Style datatables consistently with wikitables
Bug: T220232
Change-Id: Idd286a154f1b615502e0c1bee4db4f704d9bd176
6 years ago
Isarra 1c079f55d4 Better contrast on wikitable borders
Bug: T220255
Change-Id: If19024a9566e55078036d3429251f832099e30b1
6 years ago
Isarra 2cc41bbbff Make editsection icon part of first editsection link
It's sort of attached to it regardless; might as well make it clickable
(especially since the first one is going to be shorter usually regardless)

Change-Id: I40f02240c0c6e447a7042546a0392a52a0f4910c
6 years ago
Isarra 8138b52ff8 Remove extra padding on thumbcaptions
Plenty of padding already in the thumb itself.

Change-Id: I063341cbfd3fd71ef272ebd8dcd3ff335b9678ca
6 years ago
Isarra 9d76730e96 Add icons to desktop cactions and overhaul icon alignment and usage
throughout

* Still need to redo how we're using mixins, but whatever.
* Cleans up a bit from the edit/view source etc changes too, since now
  we have a little more context (oops)...
* Just hide 'view' in general because a, how much does it really add,
  and b, it doesn't fit in a lot of cases when we have the extra width
  from these icons regardless.
* Rename view and add section tabs to make more sense with icons/in
  context/whatever ('view' is now only targeted at screen readers, and
  we use a + for the new section icon, so saying 'add' is kinda...
  redundant)

Bug: T197520
Change-Id: I1ab12ccda60e51035c4adec43c42508ac297c00a
6 years ago
Isarra 9206ada9b7 Fix text cropping issues in h1, h2 for tall scripts etc
We put overflow:hidden on headers so the underline doesn't undercut
thumbs weirdly; this results in actual stuff getting chopped off at
times as well. Main example is burmese, which does line heights a
bit differently, such that overlap is kind of expected.

Solution: move underline to its own pseudo-element. May fix some other
stuff (extensions?), or just as likely break them. Only bother with
parser output because I can't even think of anywhere else we use such
floating to begin with.

Bug: T195822
Change-Id: Ib17b444b2d8720ede860e42c72c8c69e62a9f4ac
6 years ago
jenkins-bot 9cf7eb04ef Merge "Better icons/handling for view source, VE edit links" 6 years ago
jenkins-bot d9e3a5d1ec Merge "Migrate backdrop image style generation to set a variable we use in the LESS instead of adding the styles prebaked" 6 years ago
Isarra 898ee0fdc1 Better icons/handling for view source, VE edit links
* New icon for edit source as variant of normal edit icon
* Use old brackets icon for view source instead
* Put icon for editsection links outside the links themselves and only use one
  for VE when there's two links

Bug: T173531
Bug: T229184
Change-Id: Ia178c487c8e6c175944868646d36064ebde8182c
6 years ago
Isarra b1901210d9 Migrate backdrop image style generation to set a variable we use in
the LESS instead of adding the styles prebaked

Bug: T223112
Change-Id: I773dbd9bd6d318144685d691e72627a00906472b
6 years ago
jenkins-bot 76b65f29c7 Merge "Slightly reduce header margins" 6 years ago
Isarra 75a9284f16 Add a margin for frameless images
Might as well just reuse the thumb stuff, I guess.

Bug: T196356
Change-Id: Ic0497b2003bea9a5c739fd47858be545b16f2812
6 years ago
Isarra 133533a5dc Slightly reduce header margins
Slightly.

Bug: T197557
Change-Id: Ic222dd8588b701f34021aefa15b44108f26b477d
6 years ago
Isarra 2808c5c595 CSS-based pokeys
No more need to add in an html pokey element every potential dropdown menu.
Aaaaaagh that made it bigger, didn't it.

Change-Id: I5d3817aa026849a5304710a32a3585f3e698321d
6 years ago