Commit Graph

98 Commits (a171d3d02f19a86ca9716c6ccfbbb30314e820ee)

Author SHA1 Message Date
Perry Fraser 0cafe062cb Use correct namespace for ResourceLoader\Context
Bug: T308718
Change-Id: Ifdd538086388fc044cba86d2ebb1d7ebb9850506
Jon Robson 8c814579b6 Timeless should only generate body of page
In I203881d7ab035bc953d113106f21348187b51374 a bodyOnly skin
option was added to allow skins to be limited to generation of the
body tag contents. When used, generation of html, body, and head is
deferred to OutputPage.

Since Timeless is deployed on Wikimedia wikis, this is preferred
as it guarantees that debugging information, and head
tags are consistent for all Wikimedia deployed skins.

Bug: T62846
Change-Id: I3353f8b63e8acf3ab29d8c24dd868ad3f121e5bb
Ammarpad ec4544c495 Remove $stylename indirection
Bug: T270754
Change-Id: I402dc92d4bc1a0416e8b66984d9c7585a95f3fce
Lucas Werkmeister 8082e179ff Use null coalescing operator
To hide warnings if the 'svg' or 'icon' keys don’t exist.

Bug: T304917
Change-Id: I12c13615f160f1a889b469ef6e4e7561de121d92
Func 5087e5781e Use svg for the logo if applicable
Improve the appearance of the logo for High-DPI users.

Change-Id: I2b6e6f2c28eafddd6f958acca84eaec0d000f1c4
Reedy 7db015d4fc Namespace skin
Change-Id: I5e11ad1d99850b72f57d8bff3bef9cdb5c403229
Reedy 1160c07841 Drop support for MW < 1.36
Compatibility policy is rel

Change-Id: Icc8ab4f74ec8b81f049b53e705deca8d5bb937bd
Ammarpad 424900cacb Do not duplicate categories in primary action tabs space
In Timeless, they are already added in the sidebar.

Bug: T300100
Change-Id: I055fb98878ae7643c298b9d45a9f31ac1ba0735d
Jon Robson 0c8089251e Make Timeless heading behaviour consistent with other skins
Bug: T298906
Change-Id: Ib542f594a5041741c8c6f33a2aeab3b173eb48ae
DannyS712 eb971c2d91 TimelessVariablesModule: clean up constructor indentation
Change-Id: I40c7393d1778a05f05bb8a384883550e47f3eacb
Alexander Vorwerk 4e4e6ba8bb Use constant MW_VERSION instead of deprecated global $wgVersion
Change-Id: I612dcdd63f4908cc2b3a6123191a16f4bd7c4452
Alexander Vorwerk 59f1ee2682 Avoid using User::getBoolOption()
User::getBoolOption() is deprecated and should be replaced with
UserOptionsLookup::getBoolOption()

Bug: T277600
Change-Id: I5f002b68e980a0931367d037db9a7f7ec051ca43
jenkins-bot 1e7354868c Merge "Use Skin:getAfterPortlet instead of deprecated BaseTemplate:getAfterPortlet"
bwang 954929e27e Use Skin:getAfterPortlet instead of deprecated BaseTemplate:getAfterPortlet
Additional change:
* Add .DS_Store to gitignore

Change-Id: I15ed3c820823782d28f11f3724d56736db0ca3e0
Jdlrobson 9e81cbf9ae Drop mw-body-content class from #bodyContent
The CSS class is being added to `$this->get( 'bodytext' )`
which will make this class here redundant.

Depends-On: I3a91b294fcb3724cd46743e497dff723de0490a6
Bug: T279388
Change-Id: I8a8e47fd419626ebf7bf44d0b25b16a933c1367a
libraryupgrader db0633ec15 build: Updating composer dependencies
* mediawiki/mediawiki-codesniffer: 35.0.0 → 36.0.0
* php-parallel-lint/php-parallel-lint: 1.2.0 → 1.3.0

Change-Id: Iaf1cf75d7555076aefe109d7d9bbdc96f1593ed3
jenkins-bot 7651929b2a Merge "Remove double .mw-footer divs nested inside each other, doesn't seem to have a point"
jenkins-bot 174ef87ede Merge "BaseTemplate::getFooterIcons is deprecated"
Isarra 5057e4208f Remove double .mw-footer divs nested inside each other, doesn't seem
to have a point

Change-Id: Iee715e852c5e9434345186b076f223c00c3abc42
jenkins-bot 7d9d9fb4ff Merge "Correctly fall back to $wgLogos['icon'] when not using timeless' speshul junk"
Isarra bd5f2d9f8c Correctly fall back to $wgLogos['icon'] when not using timeless'
speshul junk

Assumes use of an svg icon because why would anyone seriously still
be using rasters in this day and age? Also probably negates the
usefulness of timeless' speshul logo handling junk anyway, as use of
correctly-sized svgs should obsolete the need for knowing the logo
size to begin with, as we no longer need to manually scale down
different source files...

Cap out at 156px wide, but other than that assume whatever size
people made it was intentional?

Change-Id: I9569e4d57c6740071e87c0f49ee47f739dd68bbd
ZabeMath d1a8584e9a BaseTemplate::getFooterIcons is deprecated
For callers calling `$this->getFooterIcons();` `$this->get( 'footericons' )` can be used instead.

Bug: T267447
Change-Id: Idef36ab0da345390409f8eaeed3592cd84ca980e
Daimona Eaytoy 2c105d7fcd Stop using deprecated Language methods
Change-Id: I4ee112ce1034158cc18b197942f38c8ab5bc5dd6
jenkins-bot 855b3eb62e Merge "Restore Timeless 1.35 support"
jdlrobson f804f27167 Restore Timeless 1.35 support
Change-Id: I882f4d76df4c437ad6cc5883c243ec08a40f34fb
James D. Forrester 306380dccd Use User->isRegistered(), not deprecated isLoggedIn()
Bug: T270450
Change-Id: Ibeeb79bc3b9ea9fbde48d43ab777c3526649e7b9
Isarra 89baa82860 Fix more small things
* Put hover underline back on links, because wikimedians hate change
  and also why not the entire point of the skin is to troll people,
  let's do it right
* Adjust link colours for better distinction between hover, visited,
  external
* Remove text labels from some obvious cactions (history,
  addsection) so they're all more likely to fit on stupid pages
* Don't show empty languages toggle on mobile
* I'unno, catnip.

Bug: T181177
Bug: T181192
Bug: T265205

Change-Id: I6256d9e27d6019944987db62432b1b324d5c4b38
libraryupgrader 6d9a740076 build: Updating mediawiki/mediawiki-phan-config to 0.10.5
Change-Id: Ief05109240391cebeb02965d254f361462846896
jdlrobson 84202757e2 Declare skin styles and scripts in the skin manifest as options
For you consideration. We will be aiming to do this in all Wikimedia
deployed skins so it would be great to have Timeless consistent with
those.

Change-Id: I11a8e0c8ca01b2c7eb2acc0b84ea4ad9301d3d8f
Isarra 5e2291df6d Fix some annoying things
* Stop images from overflowing on desktop as well as mobile (folks wanna
  overflow, they can load it sans skin, dammit)
* Firefox's stupid scrollbar colours
* Merge js into single module for desktop and mobile so it doesn't
  randomly break on the wrong devices, and something about too many
  modules anyway
* Weird footer padding?
* Weird WikiEditor/CodeMirror fonts/sizing

Bug: T256105
Bug: T247325
Change-Id: I8142c505534869c2530a915cfe8cef56303be6ed
Ammar Abdulhamid e92468aa13 Timeless: Unset anon placeholder item
Core now provides anon placeholder but Timeless has a
different treatment for the item and needs to unset this.

Bug: T263382
Change-Id: I0ba502a1e1368c1080caee2ce2bb45c27fdf77c3
Ammar Abdulhamid d911273c3a Remove Skin::setupSkinUserCss call
Method only calls parent and the parent is no-op

Bug: T257990
Change-Id: I44675efc351f74ba38e7d86b03aca48c15e0573e
mainframe98 b517e795a8 Specify the responsive option rather than manually specifying viewport
I6e69b482cdbc adds a viewport with the same value as Timeless.

Also remove the SkinTimeless::$skinname override, as it is now set in
Skin::__construct.

Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: I215ac0153e5652e7ac76b11dba23a05aa2d1f685
jenkins-bot 3a8da90698 Merge "Use getFooterBlock instead of getFooter to avoid weird overflows on mobile"
Isarra b46ff19b3f Use getFooterBlock instead of getFooter to avoid weird overflows on mobile
Apparently getFooterBlock never actually made it into core, so copied
out of Example.

Bug: T254266
Change-Id: Id62319314937080b99f2b93fd7b7fa62527d8fe7
jdlrobson dc4443a7dd Timeless should support default logos
Use getAvailableLogos to retrieve wordmark and icon
wikimedia production has values for all projects for these values

TimelessLogo and TimelessWordmark continue to be supported for
3rd parties.

Bug: T231615
Change-Id: I2e4bc30c948b1bcb338f9d41774912b9afb320b4
Ammar Abdulhamid e5e188fbc6 Fix lang portlet header display.
Timeless is showing the language portlet correctly when are languages or
when something is added to the portlet, but it's also showing the header
even if there are no languages and nothing extra was defined.

The root cause is that when we check $this->afterLangPortlet !== '', the
property is actually null at that stage, it is only defined when we call
$this->getPortlet( 'lang' ...) in the next line.

Bug: T256355
Change-Id: Ie3e0acccede7e2f477c6182e288def8d7a35070e
Ammar Abdulhamid b467344656 Timeless: support SidebarBeforeOutput hook
Remove phan suppression which is now triggering error

Bug: T254419
Change-Id: I5a3b68b2fa0fa243a1534d72fee04e760ff61db2
Umherirrender 7e11aa60ea build: Bump phan to 0.10.2, remove taint-check
Change-Id: I1aa44049c3269096d925f41d7d70c6019eb4699a
AronDemian 73388405c3 Add and use `.mw-footer` & `.mw-footer-container` CSS classes
Adding `.mw-footer` & `.mw-footer-container` CSS classes & replacing 
`#mw-footer`,`#mw-footer-container` selectors with them.

`#mw-footer` & `#mw-footer-container` ids are kept for JS, gadgets 
compatibility and backwards compatibility with user styles.

Bug: T248137
Change-Id: I6e262cb5fa1838a22c3c6de8866d0324e83f84b3
Umherirrender a0ab76479f Use MediaWikiServices::getRepoGroup
This required MediaWiki 1.34 (already set in skin.json)

Change-Id: I5666c637baaf9a93ede4322731e39946d9379766
libraryupgrader 15b4549f5a build: Updating composer dependencies
* mediawiki/minus-x: 0.3.2 → 1.0.0
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.1

Change-Id: I45125aebf577934f481bdd1ee51faea777a1e0d8
James D. Forrester cf3a511071 Follow-up 688fff1: Fix the other use of Sanitizer::escapeId()
Change-Id: I964f83ce88fb9c66a7c59037c6066f4567bcf4c9
C. Scott Ananian 688fff1a3e Replace usage of Sanitizer::escapeId(), deprecated in MW 1.30
Change-Id: I7d5ba4930688ed7f011a4babed5986b8e40910a0
Umherirrender 6e5892b93f build: Updating dependencies
composer:
* mediawiki/minus-x: 0.3.1 → 0.3.2
* jakub-onderka/php-console-highlighter: 0.3.2 -> 0.4.0
* mediawiki/mediawiki-phan-config: 0.8.0 -> 0.9.0

npm:
* grunt-banana-checker: 0.6.0 -> 0.8.1

Change-Id: I7c78fdbc2f5702f1d51af6dd93bea9ecac08e3ce
Umherirrender c92bea0b44 Add int cast for File::createThumb
createThumb needs a int
There are some more int cast on multiply with 1.5 in this code

Change-Id: If8356523ef89a29855dcf9bf390d16890c70f1c8
Umherirrender 93dd4042cf build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Cast division and multiply to int, because that is what needed later

Bug: T235049
Change-Id: I70855b4674e69c332b73ed0fd28c4d1fd79f8da5
jenkins-bot f9bbb4c0ee Merge "Clean up ProofreadPage page tabs a bit"
Isarra f9a7111b73 Render unnecessarily large 2x logos to ensure we support unnecessarily high-res devices
Only does this with wordmarks; desktop devices are a lot less likely to merit this, and
the larger desktop logos are probably a rather bad idea to make unnecessarily large
anyway. Whereas the wordmarks should still be pretty small in terms of filesize as
they're going to be pretty simple, and are all we normally show on mobile.

Bug: T232540
Change-Id: I1932a99d8784eadf02f2711d9557425de0db0100
jenkins-bot 30505c31e5 Merge "Create wrapper for all junk below firstHeading, including nav stuff"