207 Commits (8138b52ff8a89869680f917b364b3da05579a604)

Author SHA1 Message Date
Isarra 8138b52ff8 Remove extra padding on thumbcaptions
Plenty of padding already in the thumb itself.

Change-Id: I063341cbfd3fd71ef272ebd8dcd3ff335b9678ca
6 years ago
Isarra 488be95b2a Kill weird table normalisation
Given all the special table stuff we do is onwiki junk largely targetted
at vector, making this randomly different probably doesn't add a whole lot.

Bug: T215608
Bug: T181184
Change-Id: Id5ad605d7179ac8c4b6766a110f98d44627c06ee
6 years ago
Isarra 9d76730e96 Add icons to desktop cactions and overhaul icon alignment and usage
throughout

* Still need to redo how we're using mixins, but whatever.
* Cleans up a bit from the edit/view source etc changes too, since now
  we have a little more context (oops)...
* Just hide 'view' in general because a, how much does it really add,
  and b, it doesn't fit in a lot of cases when we have the extra width
  from these icons regardless.
* Rename view and add section tabs to make more sense with icons/in
  context/whatever ('view' is now only targeted at screen readers, and
  we use a + for the new section icon, so saying 'add' is kinda...
  redundant)

Bug: T197520
Change-Id: I1ab12ccda60e51035c4adec43c42508ac297c00a
6 years ago
jenkins-bot 5c2c302430 Merge "Add custom WikiLove heart icon" 6 years ago
Isarra ed055b9487 Add custom WikiLove heart icon
Requires I7188a3ee318db80484037733ab058a5a0b42d732 for support for the
replacement with the icon on desktop, as otherwise we can't tell if we're
correctly heeding the configuration setting there.

Removing as a depends-on because we still need this for mobile regardless.

Bug: T173219
Change-Id: I6ee0b6d94d96ee359321b203f235b2d25f06cea6
6 years ago
Isarra 9206ada9b7 Fix text cropping issues in h1, h2 for tall scripts etc
We put overflow:hidden on headers so the underline doesn't undercut
thumbs weirdly; this results in actual stuff getting chopped off at
times as well. Main example is burmese, which does line heights a
bit differently, such that overlap is kind of expected.

Solution: move underline to its own pseudo-element. May fix some other
stuff (extensions?), or just as likely break them. Only bother with
parser output because I can't even think of anywhere else we use such
floating to begin with.

Bug: T195822
Change-Id: Ib17b444b2d8720ede860e42c72c8c69e62a9f4ac
6 years ago
Isarra 31daa2ed38 Better styles for category area on desktop-small layout
Change-Id: I634ca38d904c4a4d3496370370f84c3d70a42f81
6 years ago
jenkins-bot 9cf7eb04ef Merge "Better icons/handling for view source, VE edit links" 6 years ago
jenkins-bot d9e3a5d1ec Merge "Migrate backdrop image style generation to set a variable we use in the LESS instead of adding the styles prebaked" 6 years ago
Isarra 898ee0fdc1 Better icons/handling for view source, VE edit links
* New icon for edit source as variant of normal edit icon
* Use old brackets icon for view source instead
* Put icon for editsection links outside the links themselves and only use one
  for VE when there's two links

Bug: T173531
Bug: T229184
Change-Id: Ia178c487c8e6c175944868646d36064ebde8182c
6 years ago
Isarra 70128730f5 Fix offsets for CodeMirror in VE
Bug: T230756
Depends-On: Ia7168341bcadbc60e307b58b67afc1975a2424f9
Change-Id: Ic64b9786cb7186dba3eb2042a3238149c3bb44c6
6 years ago
Isarra b2519cb240 Fix a bunch of VE alignment issues
Bug: T205149
Change-Id: I7a839fa95b42cfd541da5880ad70a76be607c7d8
6 years ago
Isarra b1901210d9 Migrate backdrop image style generation to set a variable we use in
the LESS instead of adding the styles prebaked

Bug: T223112
Change-Id: I773dbd9bd6d318144685d691e72627a00906472b
6 years ago
Isarra c668fb91d7 Fix logo/sidebar alignment on two-column mode *properly*
Followup on Ib2a93fa0c24f693375fb8c959e77dd47c8087121

Change-Id: I166dc9c00bb8682735a15234d19eb5ca9151fe8a
6 years ago
Isarra 5e98906353 Make font smaller on OAuth approval dialog
Bug: T197910
Change-Id: I3f1c530b654d11a07f2d8715f8b8e69132aaf419
6 years ago
jenkins-bot 02e576ca43 Merge "Be more specific with form formatting" 6 years ago
jenkins-bot 89583faabd Merge "Prevent icon label overflow in focus state" 6 years ago
jenkins-bot 76b65f29c7 Merge "Slightly reduce header margins" 6 years ago
jenkins-bot 92dfb4d773 Merge "Add a margin for frameless images" 6 years ago
Isarra e217b0ace6 Prevent icon label overflow in focus state
...or something?

Bug: T174314
Change-Id: I3068cd1379ebbade93be784364101bad768a5dfc
6 years ago
Isarra 75a9284f16 Add a margin for frameless images
Might as well just reuse the thumb stuff, I guess.

Bug: T196356
Change-Id: Ic0497b2003bea9a5c739fd47858be545b16f2812
6 years ago
Isarra 01ab08e127 Be more specific with form formatting
Bug: T165928
Bug: T185193
Change-Id: Iedb5585554697796127895aa00c9b2f2c3216e17
6 years ago
Isarra 2c4196e5c1 Fix portlet layout for proper handling of non-ul content
For some reason the margin was on the ul, and I have no clue why.
Breaks stuff like wikibase, announcements, anything doing non-ul
portlet content, really.

Change-Id: I201a777547d8bd1b674c8c5d987ab77d4130bfcf
6 years ago
Isarra 133533a5dc Slightly reduce header margins
Slightly.

Bug: T197557
Change-Id: Ic222dd8588b701f34021aefa15b44108f26b477d
6 years ago
jenkins-bot ac37862646 Merge "Make personal menu header expand to show (more of) full usernames" 6 years ago
jenkins-bot 132deaf771 Merge "Fix logo/sidebar alignment on two-column mode" 6 years ago
jenkins-bot 3c317a8312 Merge "Fix fixed header scroll offset in supported browsers" 6 years ago
Isarra 2c526bfdbc Make personal menu header expand to show (more of) full usernames
* Lose the special casing replacement labels for long usernames and
  just truncate in CSS with '...' or whatever
* Fix weird padding on two-column mode
* Possibly cleaner Echo badge/whatever handling
* Alignment fixes in general

Note: Breaks two-column layout for IE9-. Probably easily fixed (don't
apply that one line to it), but I don't know how, and don't care.

Bug: T161282
Bug: T173215
Change-Id: I7d27e13265ee54767c509387baf6430bd7c4792d
6 years ago
Isarra d2fc86f919 Fix logo/sidebar alignment on two-column mode
(margins get lost/combined into larger one unless container... stuff;
on three-column flexbox takes care of this for us)

Change-Id: Ib2a93fa0c24f693375fb8c959e77dd47c8087121
6 years ago
jenkins-bot ad711f7b46 Merge "Fix positioning of dropdown icon for personal menu" 6 years ago
jenkins-bot 663c999fee Merge "Lose catlinks border on mobile" 6 years ago
Isarra e6b90747be Lose catlinks border on mobile
Just looks weird, yo.

Change-Id: I84308c7dde1961d8f2b821910cdd32c4462d5620
6 years ago
Isarra d844571796 Fix positioning of dropdown icon for personal menu
...why was that overflow:hidden even there?

Change-Id: I63a84acc9228baf214fc05c1e2896556d99398d1
6 years ago
Isarra 8a05fb1463 Fix fixed header scroll offset in supported browsers
Kill js solution even for other browsers because it doesn't even really
work to begin with. And I have no clue how to make it work, because I
can't find any examples that do, either.

Fixes current firefox and chrome. Users of old browsers/other
proprietary or whatever things can, uh, suffer, I guess.

Bug: T181484
Change-Id: Ic3415702eaa33cf56ed0b1fabf9ca607c88d1863
6 years ago
Isarra 2808c5c595 CSS-based pokeys
No more need to add in an html pokey element every potential dropdown menu.
Aaaaaagh that made it bigger, didn't it.

Change-Id: I5d3817aa026849a5304710a32a3585f3e698321d
6 years ago
Isarra 1d2a9583a5 Move variants and languages into page tools dropdowns
Hopefully saner access, also clears up some of the sidebar space.
Also forces moving the wikibase other-projects blob into its own
blob entirely.

Not done:
* Pokeys (need to migrate them all to css-only; later patch)
* Handling for no languages for wikidata stuff (may not be possible;
  minerva likewise has no handling)

Bug: T213510
Bug: T181309
Change-Id: I148707085059f458512d328c415ea0bf134163f3
6 years ago
Isarra 961be92230 Break up variables.less into mixins, themes, and general variables
Basically, file soup, but more sensible file soup, hopefully.

Change-Id: Ie2cc7b5b66368d3a03ae4490882335f7930929a7
6 years ago
Isarra b3af826b7d Make footer links blue
Difference between Accent90 and white/base90 is ridiculously subtle, but sure.

Bug: T214204
Change-Id: I1ac7860b5c22ec9b9dae8f4fa61db8d88e5a66ef
6 years ago
Isarra 52d3b3aac9 Use Wikimedia visual style colours
Possibly more consistent in general with the rest of wikimedia. Maybe. We're still using the colours rather differently, though.
Should also resolve some contrast issues we've had thus far. Maybe.
Breaking up the greys like this may or may not help with theming down the road. I'm not really sure.

Bug: T131992
Bug: T200320
Change-Id: I2757271066c54891e2b6e45b86e827f34af59435
6 years ago
Isarra 0af674dbc7 Kill some more stupid padding and add some comments
Bug: T197057
Change-Id: I44dca71602e7bdcb404e56df9274b8a86f410a6e
6 years ago
jenkins-bot 98aed3fb77 Merge "Remove brackets around new toctoggle" 6 years ago
Isarra 93e0ea991b Adjust a bunch of padding, especially mobile
bug: T197057
bug: T182389
Change-Id: I0fbbc037f32cd69375be9e0224967275a8fd9949
6 years ago
jenkins-bot e1f5fddb65 Merge "Fix Special:Watchlist options for no-JS" 6 years ago
Jack Phoenix 7fbdb43a3c Remove brackets around new toctoggle
I82db33d656 in core changes the toggle button of the TOC.
This change removes the brackets around the new toctoggle, too.

Depends-On: I82db33d656b3795d7134a91d20ed9d93a3471086
Change-Id: Id4d42d8e71c559f1e83ac7c1ab055f62654c240e
6 years ago
Jack Phoenix 3435ee25b1 Fix Special:Watchlist options for no-JS
Patch by putnik (see the Phab ticket) with tweaks by yours truly.

Bug: T225412
Change-Id: I23f05bc97929a196c62a0dc242ebace5c6fe45a0
6 years ago
Isarra 0340fb7048 Adjust line-height/padding for ToC items for better wrapping
Multiline items should now be clearly distinguishable from new
single-line items. On, like, mobile, or something. Not truly insane
pages I never should have created in the first place.

Change-Id: Ia0ea69519da865b76299b62ee94b33d3b0b60a94
6 years ago
Isarra c576c68a1f Add TimelessFileModule and $wgTimelessBackdropImage configuration
option to set configurable background image for the skin as a whole

Defaults to the cat, but can ideally be set to anything appropriate
to the wiki in question. Recommendation is a 20-50% opacity black/
white background image, where the alpha values of the b/w parts are
likewise around 10-50/255.

Bug: T193330
Change-Id: Ica3e2ce2568557ef157d06d1b7127b030f3c38f0
6 years ago
jenkins-bot 64ed4a2639 Merge "Redo cat with only black and white and lose png version" 6 years ago
Isarra 6f43b4a328 Move indicators up slightly
Hello, I'm Mr. Competent, reporting in for competency training.

Change-Id: I403c34bcd6322aeb9f319dca0944030a5050992d
6 years ago
Isarra 5d4b4c8249 Redo cat with only black and white and lose png version
Also made slightly bigger.

Change-Id: I91d41378d30ccb2439d44ccdc2caad646fcb9c37
6 years ago