Commit Graph

222 Commits (49a2ab341755f3f63b5f034334f6e69890b8c493)

Author SHA1 Message Date
Isarra 41afd6e2b2 Fix close behaviour on click-toggle dropdowns
Change-Id: I0d70773918b048288ed278adb3df7f23c2d561cd
Fomafix 7f87813bc3 Simplify JavaScript code
* Reuse $() closure.
* Query jQuery selector only once.

Change-Id: Ic302427fe7d23808b3e6718fd23a6b5d492bfa88
jenkins-bot bde37bd025 Merge "Fix languages/variants stuff some more"
Isarra c16be2f4dd Fix languages/variants stuff some more
Messed up a couple of things:
* Nojs variants toggle
* Order of sorting out language/project stuff fixed so it should correctly occur

Fixed.

Change-Id: I9a55848ca50884594035949e5aa855d98ddff77c
Isarra 46bbcd9a0c Cleanup js clicky stuff a bit more
Change-Id: I5c4d6da26ca1c6b92c4aeabd47421567c3adc673
Isarra 54997f2dfb Use click to toggle for desktop dropdown menus
Still fall back to hover for nojs.

Bug: T211357
Change-Id: I9636a0e3c127173ffb7881c8760d39b715ae475f
Isarra a4900353b1 Use flex for logo container width and to show some username on small screens
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc

Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
Isarra cd71b68b6a Fix weird lines appearing in IE with Extension:WikiEditor
IE doesn't like the box-shadow combined with whatever that's doing. And
that box shadow is frivolous enough that it's easier to just kill it
here than figure it out.

Bug: T190991
Change-Id: I46411c3c52db9d21a3df1e9931c78551f626e6c6
Isarra f0fc1a4362 Custom logo rendering, including text wordmark images
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.

For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
	'1x' => $wgLogo,
	'1.5x' => $wgLogoHD['1.5x']",
	'2x' => $wgLogoHD['2x'],
	'width' => 160,
	'height' => 160
];

Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';

And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.

Fallback behaviour remains unchanged, if just not using these.

Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
Isarra a8710c87cc Apply content padding to data-after-content on small resolutions
Doesn't matter on the large layouts because there's padding around content, but on
these it's only the content padding applying everywhere...

Also maybe kinda sorta included half this patch in the previous. Oops.

Change-Id: I7319ad49098fa6593cda498196ce2d89ca843537
Isarra 8bca35dec0 Put languages back in sidebar on desktop
Partially reverts I148707085059f458512d328c415ea0bf134163f3 plus some random
cleanup and stuff

Both of the following bugs involve wikibase stuff so I can't actually be entirely
sure this resolves them, but I thiiiink it does because it should be killing the
offending parts of the above change that caused this? Probably?

Bug: T231256
Bug: T231234
Change-Id: Id7c0d90a805450b577271a321572fcd552ecbc3e
Isarra e0d18e3298 Style datatables consistently with wikitables
Bug: T220232
Change-Id: Idd286a154f1b615502e0c1bee4db4f704d9bd176
Isarra 1c079f55d4 Better contrast on wikitable borders
Bug: T220255
Change-Id: If19024a9566e55078036d3429251f832099e30b1
Isarra 2cc41bbbff Make editsection icon part of first editsection link
It's sort of attached to it regardless; might as well make it clickable
(especially since the first one is going to be shorter usually regardless)

Change-Id: I40f02240c0c6e447a7042546a0392a52a0f4910c
Isarra fa969cf9df Better position notifications area (watchlist ajax, preferences changes,
etc) to account for fixed header

Change-Id: I2387866cbc1aef0fa4edb202b1af73659230045b
Isarra 8138b52ff8 Remove extra padding on thumbcaptions
Plenty of padding already in the thumb itself.

Change-Id: I063341cbfd3fd71ef272ebd8dcd3ff335b9678ca
Isarra 488be95b2a Kill weird table normalisation
Given all the special table stuff we do is onwiki junk largely targetted
at vector, making this randomly different probably doesn't add a whole lot.

Bug: T215608
Bug: T181184
Change-Id: Id5ad605d7179ac8c4b6766a110f98d44627c06ee
Isarra 9d76730e96 Add icons to desktop cactions and overhaul icon alignment and usage
throughout

* Still need to redo how we're using mixins, but whatever.
* Cleans up a bit from the edit/view source etc changes too, since now
  we have a little more context (oops)...
* Just hide 'view' in general because a, how much does it really add,
  and b, it doesn't fit in a lot of cases when we have the extra width
  from these icons regardless.
* Rename view and add section tabs to make more sense with icons/in
  context/whatever ('view' is now only targeted at screen readers, and
  we use a + for the new section icon, so saying 'add' is kinda...
  redundant)

Bug: T197520
Change-Id: I1ab12ccda60e51035c4adec43c42508ac297c00a
jenkins-bot 5c2c302430 Merge "Add custom WikiLove heart icon"
Isarra ed055b9487 Add custom WikiLove heart icon
Requires I7188a3ee318db80484037733ab058a5a0b42d732 for support for the
replacement with the icon on desktop, as otherwise we can't tell if we're
correctly heeding the configuration setting there.

Removing as a depends-on because we still need this for mobile regardless.

Bug: T173219
Change-Id: I6ee0b6d94d96ee359321b203f235b2d25f06cea6
Isarra 9206ada9b7 Fix text cropping issues in h1, h2 for tall scripts etc
We put overflow:hidden on headers so the underline doesn't undercut
thumbs weirdly; this results in actual stuff getting chopped off at
times as well. Main example is burmese, which does line heights a
bit differently, such that overlap is kind of expected.

Solution: move underline to its own pseudo-element. May fix some other
stuff (extensions?), or just as likely break them. Only bother with
parser output because I can't even think of anywhere else we use such
floating to begin with.

Bug: T195822
Change-Id: Ib17b444b2d8720ede860e42c72c8c69e62a9f4ac
Isarra 31daa2ed38 Better styles for category area on desktop-small layout
Change-Id: I634ca38d904c4a4d3496370370f84c3d70a42f81
jenkins-bot 9cf7eb04ef Merge "Better icons/handling for view source, VE edit links"
jenkins-bot d9e3a5d1ec Merge "Migrate backdrop image style generation to set a variable we use in the LESS instead of adding the styles prebaked"
Isarra 898ee0fdc1 Better icons/handling for view source, VE edit links
* New icon for edit source as variant of normal edit icon
* Use old brackets icon for view source instead
* Put icon for editsection links outside the links themselves and only use one
  for VE when there's two links

Bug: T173531
Bug: T229184
Change-Id: Ia178c487c8e6c175944868646d36064ebde8182c
Isarra 70128730f5 Fix offsets for CodeMirror in VE
Bug: T230756
Depends-On: Ia7168341bcadbc60e307b58b67afc1975a2424f9
Change-Id: Ic64b9786cb7186dba3eb2042a3238149c3bb44c6
Isarra b2519cb240 Fix a bunch of VE alignment issues
Bug: T205149
Change-Id: I7a839fa95b42cfd541da5880ad70a76be607c7d8
Isarra b1901210d9 Migrate backdrop image style generation to set a variable we use in
the LESS instead of adding the styles prebaked

Bug: T223112
Change-Id: I773dbd9bd6d318144685d691e72627a00906472b
Isarra c668fb91d7 Fix logo/sidebar alignment on two-column mode *properly*
Followup on Ib2a93fa0c24f693375fb8c959e77dd47c8087121

Change-Id: I166dc9c00bb8682735a15234d19eb5ca9151fe8a
Isarra 5e98906353 Make font smaller on OAuth approval dialog
Bug: T197910
Change-Id: I3f1c530b654d11a07f2d8715f8b8e69132aaf419
jenkins-bot 02e576ca43 Merge "Be more specific with form formatting"
jenkins-bot 89583faabd Merge "Prevent icon label overflow in focus state"
jenkins-bot 76b65f29c7 Merge "Slightly reduce header margins"
jenkins-bot 92dfb4d773 Merge "Add a margin for frameless images"
Isarra e217b0ace6 Prevent icon label overflow in focus state
...or something?

Bug: T174314
Change-Id: I3068cd1379ebbade93be784364101bad768a5dfc
Isarra 75a9284f16 Add a margin for frameless images
Might as well just reuse the thumb stuff, I guess.

Bug: T196356
Change-Id: Ic0497b2003bea9a5c739fd47858be545b16f2812
Isarra 01ab08e127 Be more specific with form formatting
Bug: T165928
Bug: T185193
Change-Id: Iedb5585554697796127895aa00c9b2f2c3216e17
Isarra 2c4196e5c1 Fix portlet layout for proper handling of non-ul content
For some reason the margin was on the ul, and I have no clue why.
Breaks stuff like wikibase, announcements, anything doing non-ul
portlet content, really.

Change-Id: I201a777547d8bd1b674c8c5d987ab77d4130bfcf
Isarra 133533a5dc Slightly reduce header margins
Slightly.

Bug: T197557
Change-Id: Ic222dd8588b701f34021aefa15b44108f26b477d
jenkins-bot ac37862646 Merge "Make personal menu header expand to show (more of) full usernames"
jenkins-bot 132deaf771 Merge "Fix logo/sidebar alignment on two-column mode"
jenkins-bot 3c317a8312 Merge "Fix fixed header scroll offset in supported browsers"
Isarra 2c526bfdbc Make personal menu header expand to show (more of) full usernames
* Lose the special casing replacement labels for long usernames and
  just truncate in CSS with '...' or whatever
* Fix weird padding on two-column mode
* Possibly cleaner Echo badge/whatever handling
* Alignment fixes in general

Note: Breaks two-column layout for IE9-. Probably easily fixed (don't
apply that one line to it), but I don't know how, and don't care.

Bug: T161282
Bug: T173215
Change-Id: I7d27e13265ee54767c509387baf6430bd7c4792d
Isarra d2fc86f919 Fix logo/sidebar alignment on two-column mode
(margins get lost/combined into larger one unless container... stuff;
on three-column flexbox takes care of this for us)

Change-Id: Ib2a93fa0c24f693375fb8c959e77dd47c8087121
jenkins-bot ad711f7b46 Merge "Fix positioning of dropdown icon for personal menu"
jenkins-bot 663c999fee Merge "Lose catlinks border on mobile"
Isarra e6b90747be Lose catlinks border on mobile
Just looks weird, yo.

Change-Id: I84308c7dde1961d8f2b821910cdd32c4462d5620
Isarra d844571796 Fix positioning of dropdown icon for personal menu
...why was that overflow:hidden even there?

Change-Id: I63a84acc9228baf214fc05c1e2896556d99398d1
Isarra 8a05fb1463 Fix fixed header scroll offset in supported browsers
Kill js solution even for other browsers because it doesn't even really
work to begin with. And I have no clue how to make it work, because I
can't find any examples that do, either.

Fixes current firefox and chrome. Users of old browsers/other
proprietary or whatever things can, uh, suffer, I guess.

Bug: T181484
Change-Id: Ic3415702eaa33cf56ed0b1fabf9ca607c88d1863
Isarra 2808c5c595 CSS-based pokeys
No more need to add in an html pokey element every potential dropdown menu.
Aaaaaagh that made it bigger, didn't it.

Change-Id: I5d3817aa026849a5304710a32a3585f3e698321d