It's called shitty js. Affordance to label overflow is slightly wrong
for current behaviour, as it basically presents as a toggle. Maybe it
should toggle something! Like popouts, that would be fun. I'unno.
Slightly more framing on wikitables etc, but apply to all tables,
because why not.
Rejig to come with actual popouts or stuff...
Bug: T179265
Bug: T265785
Change-Id: I607cb87687fcbcb481dc2fb7165c52b9e9c35873
For you consideration. We will be aiming to do this in all Wikimedia
deployed skins so it would be great to have Timeless consistent with
those.
Change-Id: I11a8e0c8ca01b2c7eb2acc0b84ea4ad9301d3d8f
* Stop images from overflowing on desktop as well as mobile (folks wanna
overflow, they can load it sans skin, dammit)
* Firefox's stupid scrollbar colours
* Merge js into single module for desktop and mobile so it doesn't
randomly break on the wrong devices, and something about too many
modules anyway
* Weird footer padding?
* Weird WikiEditor/CodeMirror fonts/sizing
Bug: T256105
Bug: T247325
Change-Id: I8142c505534869c2530a915cfe8cef56303be6ed
In I215ac0153e5652e7ac76b11dba23a05aa2d1f685 the new structure
of $wgValidSkinNames was added, but the required core version
number wasn't increased to match.
This is a breaking change, so the version number of Timeless is
updated as well.
Bug: T258290
Change-Id: I384cfbdf16224b5ba27bcbbdf49b8f53ccbdca8c
I6e69b482cdbc adds a viewport with the same value as Timeless.
Also remove the SkinTimeless::$skinname override, as it is now set in
Skin::__construct.
Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: I215ac0153e5652e7ac76b11dba23a05aa2d1f685
This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.
In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)
This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".
If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.
Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.
Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
Currently js-only due to the default (only) vector styles requiring js. Fixed in
Ifd8be387cef671b2aaa2a482c145bccf2e6d1543, with a followup to clean up a bit after
that assuming that doesn't mess up too much to be merged, but this works regardless.
Bug: T231250
Change-Id: I4cadcbc3e51672fb075c884b2d2cc1d799b1b1b0
(Cap at single column or single-sidebar instead of the default three-
column mode.)
Adds user preference options and a $wgTimelessDefaultLayout config to
change the default wiki-wide. Intended for people who hate change and
prefer the same navigation layout (sort of) as we've had forever, and
for people who are really bad at change and just keep getting confused
when everything keeps moving around across different sized devices, as
well as anyone else who just likes... options, I guess? Whatever the
case, this is seriously up there in the running for 'most requested
feature'.
Uses three separate modules to avoid sending all users the same styles
twice regardless of what they'll even use, as each set is mostly the
same, just with slightly different breakpoints. Not seeing any saner
ways to do this, however, as even with LESS we can only use mixins/
includes/& afters to avoid the duplication in terms of what we work on,
not what is generated.
Bug: T131803
Change-Id: I0538d36c2ed7a5009b2a0f75952671ac9447fd56
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.
For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
'1x' => $wgLogo,
'1.5x' => $wgLogoHD['1.5x']",
'2x' => $wgLogoHD['2x'],
'width' => 160,
'height' => 160
];
Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';
And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.
Fallback behaviour remains unchanged, if just not using these.
Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
Requires I7188a3ee318db80484037733ab058a5a0b42d732 for support for the
replacement with the icon on desktop, as otherwise we can't tell if we're
correctly heeding the configuration setting there.
Removing as a depends-on because we still need this for mobile regardless.
Bug: T173219
Change-Id: I6ee0b6d94d96ee359321b203f235b2d25f06cea6
Follows-up f450f7e13 and 1bb12ffaae which introduce and
explaine that module's need based on what I believe was a
misunderstanding.
Specifying an options object (e.g. with a "media" key) is optional
for a stylesheet, and a module can have any number of CSS or LESS
files that are packaged together. The syntax for this was designed
for PHP and unfortunately does not translate elegantly to JSON,
but it does work. In PHP, examples of this can be found that look
as follows:
'styles' => [
'foo.css',
'bar.css' => [ 'media' => 'print' ],
'quux.css',
],
Other examples of this in JSON can be found in Nostalgia.git
and ArticlePlaceholder.git.
Change-Id: Ie2a39a79c0892a1c5699a05071216eb5fe660bc1
option to set configurable background image for the skin as a whole
Defaults to the cat, but can ideally be set to anything appropriate
to the wiki in question. Recommendation is a 20-50% opacity black/
white background image, where the alpha values of the b/w parts are
likewise around 10-50/255.
Bug: T193330
Change-Id: Ica3e2ce2568557ef157d06d1b7127b030f3c38f0
Note that this wraps localNotice in a box and may mess up custom
sitenotice css that does not expect a box to already be there.
Bug: T182517
Change-Id: I7d25017ba89cb833317aea61f9ea5f8f0a145df8
I don't actually know if it's 1.31 that it requires, but it
definitely doesn't work in 1.27, the previous LTS. And we're on 1.32
anyway now.
Change-Id: I8bd8dcc8a58f605e79d4f0c92f58febcad834f6a
When using the Vector skin, and you load a page and press the tab
button on the keyboard once, the cursor focus on the search box,
this is handy and now available on the timeless skin too.
Also, removed target "mobile" as "jquery.tabIndex" dependency doesn't
use it.
Bug: T201424
Change-Id: I6e5d96371b5342ad2d3a207e980ec1fcf7e2de99
Does not appear to work, and is possibly breaking things elsewise as
well. In particular: chrome text selection in general, possibly iphone
support?
May or may not resolve the following; please test (does seem to
effectively resolve T183215, for now, at least, but dunno at all about
the other two.):
Bug: T161470
Bug: T183215
Bug: T188387
Change-Id: I2d4aae98fe47bce5a873bc44b6cea58f111f5086
SPDX released version 3 of their license list (<https://spdx.org/licenses/>),
which changed the FSF licenses to explicitly end in -only or -or-later
instead of relying on an easy to miss + symbol.
Bug: T183858
Change-Id: I1d56eb47773159c51782ff32ae4f52d2c99c8225
I'm giving you some attention on Extension:MobileFrontend page and
want to promote skins which look nice on mobile.
https://www.mediawiki.org/wiki/Extension:MobileFrontend#Setup_a_skin
The targets are needed to ensure code is loaded by the skin when
operating in mobile mode so currently that wiki page is lying.
Please let it be true :)
Change-Id: Ie9ba6beec172f7b499ae347652318fe54d258e39
Positioned toolbar properly for all modes.
Added icon to ve-edit, and new icon for edit source.
Yadda.
Toolbar does not work properly at low resolutions. This is a VE problem.
Cactions do not work with editor open. This is a VE problem.
bug: T161462
Change-Id: Ie5f4732f49f2dc365f5a3cc0c4b0e21444c21d1f
And some other stuff too just because I ran into it on the way:
* Added indicators
* Fixed js in general
* Bumped version number
* Added some stupid hacks
* Cleaned stuff up
* I don't actually know
Change-Id: Ifa557c6f0f8a972d8986c3bffdfe08ddb4b39664
Thanks to Skizzers for the catlist db query.
Thanks to HORROR for the tool parsing.
Lots of css and stuff.
Change-Id: I9b6b4c2e3a206d909972929ae32777c933d0be46
jdlrobson
Isarra
Sam Wilson
mainframe98
Jack Phoenix
Ammar Abdulhamid
Timo Tijhof
jenkins-bot
Alangi Derick
Kunal Mehta
Tulsi Bhagat
Bartosz Dziewoński
Umherirrender
Paladox