This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.
In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)
This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".
If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.
Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.
Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
* Remove Liberation Mono from font stack; comes out excessively light on
hidpi chrome, to the point of unreadability (and probably is not a local
config problem beyond merely having it installed at all, as chrome
overrides normal font rendering settings regardless)
* Kill double border on pre styles; doesn't match other such boxes (notice,
warning, whatever)
Change-Id: I7a95931bd6af4efc880c3ee8f37a91d61f3e6539
And put the position:relative on that. Keeps the sticky header out of
it, regardless, and let folks do their weird non-content voodoo on
stuff like the siteSub more consistently, I guess...
Bug: T231400
Change-Id: I7ac35f741210a0c54976f43d2294af8f123967a1
Currently js-only due to the default (only) vector styles requiring js. Fixed in
Ifd8be387cef671b2aaa2a482c145bccf2e6d1543, with a followup to clean up a bit after
that assuming that doesn't mess up too much to be merged, but this works regardless.
Bug: T231250
Change-Id: I4cadcbc3e51672fb075c884b2d2cc1d799b1b1b0
* svgo on everything
* Line up some pixel borders more
* Use transparent for the grey amount
* Fix a couple of overflows on icon css
Change-Id: Ic56b65d71ae08cf71048ad5efdfa7e65a749f680
Messed up a couple of things:
* Nojs variants toggle
* Order of sorting out language/project stuff fixed so it should correctly occur
Fixed.
Change-Id: I9a55848ca50884594035949e5aa855d98ddff77c
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc
Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
IE doesn't like the box-shadow combined with whatever that's doing. And
that box shadow is frivolous enough that it's easier to just kill it
here than figure it out.
Bug: T190991
Change-Id: I46411c3c52db9d21a3df1e9931c78551f626e6c6
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.
For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
'1x' => $wgLogo,
'1.5x' => $wgLogoHD['1.5x']",
'2x' => $wgLogoHD['2x'],
'width' => 160,
'height' => 160
];
Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';
And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.
Fallback behaviour remains unchanged, if just not using these.
Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
Doesn't matter on the large layouts because there's padding around content, but on
these it's only the content padding applying everywhere...
Also maybe kinda sorta included half this patch in the previous. Oops.
Change-Id: I7319ad49098fa6593cda498196ce2d89ca843537
Partially reverts I148707085059f458512d328c415ea0bf134163f3 plus some random
cleanup and stuff
Both of the following bugs involve wikibase stuff so I can't actually be entirely
sure this resolves them, but I thiiiink it does because it should be killing the
offending parts of the above change that caused this? Probably?
Bug: T231256
Bug: T231234
Change-Id: Id7c0d90a805450b577271a321572fcd552ecbc3e
It's sort of attached to it regardless; might as well make it clickable
(especially since the first one is going to be shorter usually regardless)
Change-Id: I40f02240c0c6e447a7042546a0392a52a0f4910c
Given all the special table stuff we do is onwiki junk largely targetted
at vector, making this randomly different probably doesn't add a whole lot.
Bug: T215608
Bug: T181184
Change-Id: Id5ad605d7179ac8c4b6766a110f98d44627c06ee
throughout
* Still need to redo how we're using mixins, but whatever.
* Cleans up a bit from the edit/view source etc changes too, since now
we have a little more context (oops)...
* Just hide 'view' in general because a, how much does it really add,
and b, it doesn't fit in a lot of cases when we have the extra width
from these icons regardless.
* Rename view and add section tabs to make more sense with icons/in
context/whatever ('view' is now only targeted at screen readers, and
we use a + for the new section icon, so saying 'add' is kinda...
redundant)
Bug: T197520
Change-Id: I1ab12ccda60e51035c4adec43c42508ac297c00a
Requires I7188a3ee318db80484037733ab058a5a0b42d732 for support for the
replacement with the icon on desktop, as otherwise we can't tell if we're
correctly heeding the configuration setting there.
Removing as a depends-on because we still need this for mobile regardless.
Bug: T173219
Change-Id: I6ee0b6d94d96ee359321b203f235b2d25f06cea6
We put overflow:hidden on headers so the underline doesn't undercut
thumbs weirdly; this results in actual stuff getting chopped off at
times as well. Main example is burmese, which does line heights a
bit differently, such that overlap is kind of expected.
Solution: move underline to its own pseudo-element. May fix some other
stuff (extensions?), or just as likely break them. Only bother with
parser output because I can't even think of anywhere else we use such
floating to begin with.
Bug: T195822
Change-Id: Ib17b444b2d8720ede860e42c72c8c69e62a9f4ac
* New icon for edit source as variant of normal edit icon
* Use old brackets icon for view source instead
* Put icon for editsection links outside the links themselves and only use one
for VE when there's two links
Bug: T173531
Bug: T229184
Change-Id: Ia178c487c8e6c175944868646d36064ebde8182c
RetroCraft
Kunal Mehta
Timo Tijhof
Isarra
jenkins-bot
Fomafix