253 Commits (193e4190a4d6b1bd64516f95e0b8e001b6669216)

Author SHA1 Message Date
Sam Wilson d2fa06a669 Add half-filled star for expiring watched pages
This will only work with recent versions of core, but will not
give an error for older versions that don't have the
'mw-watchlink-temp' class.

Bug: T258674
Change-Id: Ia3d7732160dd0d8358ed12bd2c7ad08db16aa773
4 years ago
jenkins-bot 3a8da90698 Merge "Use getFooterBlock instead of getFooter to avoid weird overflows on mobile" 5 years ago
Isarra b46ff19b3f Use getFooterBlock instead of getFooter to avoid weird overflows on mobile
Apparently getFooterBlock never actually made it into core, so copied
out of Example.

Bug: T254266
Change-Id: Id62319314937080b99f2b93fd7b7fa62527d8fe7
5 years ago
jenkins-bot f05aac7a58 Merge "Replace deprecated `background-image-svg()` mixin calls" 5 years ago
Volker E 3963c99c5d Replace deprecated `background-image-svg()` mixin calls
Use normal `background-image` properties with SVGs now
that IE 8 and Android 2.1 is removed from Grade C.
Also removing all PNG fallback images.

Bug: T248062
Change-Id: I27d95241b6512f36985f7269122802d7b0962042
5 years ago
Ed Sanders 9dba0e0329 build: Update eslint-config-wikimedia to 0.16.2
Change-Id: Ieaa2864ee76cef15941c6843d15cfd7e77fbc817
5 years ago
Jack Phoenix 84f03e5bb9 Define z-index property for the mw-json-schema-code-samples CSS class to ensure proper stacking
Said class is introduced and used by the EventLogging extension.

Bug: T249557
Change-Id: I5f45d4e5cac9b614f26b17f2507e1f72fc39035b
5 years ago
AronDemian 73388405c3 Add and use `.mw-footer` & `.mw-footer-container` CSS classes
Adding `.mw-footer` & `.mw-footer-container` CSS classes & replacing 
`#mw-footer`,`#mw-footer-container` selectors with them.

`#mw-footer` & `#mw-footer-container` ids are kept for JS, gadgets 
compatibility and backwards compatibility with user styles.

Bug: T248137
Change-Id: I6e262cb5fa1838a22c3c6de8866d0324e83f84b3
5 years ago
Isarra a9d8f63abb Make wikitext editor use fonts consistent with rest of content
Monospace, serif, and sans-serif font stacks should all have consistent
metrics, so actually use them in wikitext editor. (Which depends on user
preferences.)
Also reset core font sizes added per T182320; that was done for skins
using system fonts elsewhere as well, and thus isn't really relevant here.

Also define out sans and serif font family variables independent of main
stack variables so they won't accidentally get overridden to other
things, but not presently following new naming conventions because
frankly I don't understand them and don't know which I should be using
to begin with. And even if I did, they're extremely long and we're
already exceeding maximum line length guidelines...

Bug: T247325
Change-Id: Iab98cfacab7dbc2f752bd200ee82d6d1a58c19a6
5 years ago
AronDemian cb421b75b5 Remove `background:` rule from table cells to enable row background-color overrides in wikitext.
Row background falls back to table's background (same), consistent with Vector skin's behaviour.

Bug: T238482
Change-Id: I8bb955265f0ca189d1e6890065a5db510ceac612
5 years ago
RetroCraft e781898f1d Remove jsonlint, upgrade eslint-config-wikimedia
Bug: T220036
Change-Id: I0bcf085292921eda7fadec05eb4ebcef0ff99081
5 years ago
Kunal Mehta 7e8fe12c11 build: Updating npm dependencies
* grunt-stylelint: 0.10.1 → 0.13.0
* stylelint-config-wikimedia: 0.5.0 → 0.8.0

Additional changes:
* Committed package-lock.json (T179229) too.

Change-Id: I6e0066edb40ac0f027421d46f51d0c730503a04f
5 years ago
Timo Tijhof a907ac43b9 Remove use of 'jquery.tabIndex'
This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.

In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)

This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".

If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.

Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.

Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
5 years ago
Isarra 97850166de Normalise some pre styles that just look odd
* Remove Liberation Mono from font stack; comes out excessively light on
  hidpi chrome, to the point of unreadability (and probably is not a local
  config problem beyond merely having it installed at all, as chrome
  overrides normal font rendering settings regardless)
* Kill double border on pre styles; doesn't match other such boxes (notice,
  warning, whatever)

Change-Id: I7a95931bd6af4efc880c3ee8f37a91d61f3e6539
5 years ago
jenkins-bot 30505c31e5 Merge "Create wrapper for all junk below firstHeading, including nav stuff" 5 years ago
jenkins-bot 6ff15a1192 Merge "Prevent thumbnails from overflowing their backgrounds when coupled with random other floats where they don't fit" 5 years ago
jenkins-bot fce278717e Merge "Prevent edtisection icons from getting clipped" 5 years ago
Isarra 62c2eb0760 Create wrapper for all junk below firstHeading, including nav stuff
And put the position:relative on that. Keeps the sticky header out of
it, regardless, and let folks do their weird non-content voodoo on
stuff like the siteSub more consistently, I guess...

Bug: T231400
Change-Id: I7ac35f741210a0c54976f43d2294af8f123967a1
5 years ago
Isarra 359825a088 Prevent edtisection icons from getting clipped
Not an issue in most fonts, but some padding should prevent it more consistently regardless.

Change-Id: Ib8b8daeb8288044d3b85b0d6b4c9e86ea70993f9
5 years ago
Isarra e8824f4bd7 Prevent thumbnails from overflowing their backgrounds when coupled with random other floats where they don't fit
Example:
https://en.wikipedia.org/w/index.php?title=Goose_River_(Belfast_Bay)&oldid=893300681

Change-Id: I7b4c78304c57a32f9ac4684b21a6b70d3f61a7c8
5 years ago
Isarra 0af345adfe Prevent long sitenames from overflowing out of column and stuff
Missed some max-width stuff with the flex.

Bug: T232411
Change-Id: Idb1ebd8c33ade90b1a3d165c04c63e1dcfd7bb95
5 years ago
Isarra 91634606e7 Consolidate and make monospace styles more consistent
* Less stark borders
* Add font stack for monospace (ugh)

Change-Id: Ic3a1dc9ead32a30c95ff1573f2054cf68c8cd3bc
5 years ago
Isarra 321037f1c5 Increase filetoc contrast, make it stand out more
Why were we even killing the border to begin with?

Change-Id: I963f41c245f5911ddd7d8ddc5888402dee20fc57
5 years ago
Isarra 3cf24fa8ab Better padding for new messages yellow
Change-Id: I609fb1dbfce9c6cc3351509e79517c19eddd5d85
5 years ago
Isarra b5df43b3e2 Add a min-height to thumbcaptions so magnify icon doesn't overflow
Change-Id: Ic033553e26f3ae4fd330ba501ec6a886e108685c
5 years ago
jenkins-bot 1b4c4e7c58 Merge "Add arrows for extension:proofreadpage pages and sort tabs appropriately" 5 years ago
jenkins-bot c8a7d8dc40 Merge "Clean up and/or optimise icons a bit" 5 years ago
Isarra 649a9f133e Add arrows for extension:proofreadpage pages and sort tabs appropriately
Currently js-only due to the default (only) vector styles requiring js. Fixed in
Ifd8be387cef671b2aaa2a482c145bccf2e6d1543, with a followup to clean up a bit after
that assuming that doesn't mess up too much to be merged, but this works regardless.

Bug: T231250
Change-Id: I4cadcbc3e51672fb075c884b2d2cc1d799b1b1b0
5 years ago
jenkins-bot b77c5753f6 Merge "Align echo new messages yellow thing" 5 years ago
Isarra 41afd6e2b2 Fix close behaviour on click-toggle dropdowns
Change-Id: I0d70773918b048288ed278adb3df7f23c2d561cd
5 years ago
Isarra f3eea9d920 Align echo new messages yellow thing
Change-Id: I6d9c5e98d26ed21f31bbe75174ded6b9433a0b1b
5 years ago
Fomafix 7f87813bc3 Simplify JavaScript code
* Reuse $() closure.
* Query jQuery selector only once.

Change-Id: Ic302427fe7d23808b3e6718fd23a6b5d492bfa88
5 years ago
Isarra 808c317293 Clean up and/or optimise icons a bit
* svgo on everything
* Line up some pixel borders more
* Use transparent for the grey amount
* Fix a couple of overflows on icon css

Change-Id: Ic56b65d71ae08cf71048ad5efdfa7e65a749f680
5 years ago
jenkins-bot bde37bd025 Merge "Fix languages/variants stuff some more" 5 years ago
Isarra c16be2f4dd Fix languages/variants stuff some more
Messed up a couple of things:
* Nojs variants toggle
* Order of sorting out language/project stuff fixed so it should correctly occur

Fixed.

Change-Id: I9a55848ca50884594035949e5aa855d98ddff77c
5 years ago
Isarra 46bbcd9a0c Cleanup js clicky stuff a bit more
Change-Id: I5c4d6da26ca1c6b92c4aeabd47421567c3adc673
5 years ago
Isarra 54997f2dfb Use click to toggle for desktop dropdown menus
Still fall back to hover for nojs.

Bug: T211357
Change-Id: I9636a0e3c127173ffb7881c8760d39b715ae475f
5 years ago
Isarra a4900353b1 Use flex for logo container width and to show some username on small screens
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc

Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
5 years ago
Isarra cd71b68b6a Fix weird lines appearing in IE with Extension:WikiEditor
IE doesn't like the box-shadow combined with whatever that's doing. And
that box shadow is frivolous enough that it's easier to just kill it
here than figure it out.

Bug: T190991
Change-Id: I46411c3c52db9d21a3df1e9931c78551f626e6c6
5 years ago
Isarra f0fc1a4362 Custom logo rendering, including text wordmark images
Use a file upload onwiki for simplest approach, or specify srcset info in an
array if that's not an option or otherwise not desired.

For instance to just reuse a $wgLogo and $wgLogoHD already set for a 160x160px
logo, but where the HD versions actually come out the right size:
$wgTimelessLogo = [
	'1x' => $wgLogo,
	'1.5x' => $wgLogoHD['1.5x']",
	'2x' => $wgLogoHD['2x'],
	'width' => 160,
	'height' => 160
];

Or to use File:Cows.svg uploaded onwiki:
$wgTimelessLogo = 'Cows.svg';

And the same thing with $wgTimelessWordmark to replace the site title string
with an image version.

Fallback behaviour remains unchanged, if just not using these.

Bug: T132004
Bug: T230663
Change-Id: I0d7b398935045ba69462252d40832ed95ad2d5ed
5 years ago
Isarra a8710c87cc Apply content padding to data-after-content on small resolutions
Doesn't matter on the large layouts because there's padding around content, but on
these it's only the content padding applying everywhere...

Also maybe kinda sorta included half this patch in the previous. Oops.

Change-Id: I7319ad49098fa6593cda498196ce2d89ca843537
5 years ago
Isarra 8bca35dec0 Put languages back in sidebar on desktop
Partially reverts I148707085059f458512d328c415ea0bf134163f3 plus some random
cleanup and stuff

Both of the following bugs involve wikibase stuff so I can't actually be entirely
sure this resolves them, but I thiiiink it does because it should be killing the
offending parts of the above change that caused this? Probably?

Bug: T231256
Bug: T231234
Change-Id: Id7c0d90a805450b577271a321572fcd552ecbc3e
5 years ago
Isarra e0d18e3298 Style datatables consistently with wikitables
Bug: T220232
Change-Id: Idd286a154f1b615502e0c1bee4db4f704d9bd176
5 years ago
Isarra 1c079f55d4 Better contrast on wikitable borders
Bug: T220255
Change-Id: If19024a9566e55078036d3429251f832099e30b1
5 years ago
Isarra 2cc41bbbff Make editsection icon part of first editsection link
It's sort of attached to it regardless; might as well make it clickable
(especially since the first one is going to be shorter usually regardless)

Change-Id: I40f02240c0c6e447a7042546a0392a52a0f4910c
5 years ago
Isarra fa969cf9df Better position notifications area (watchlist ajax, preferences changes,
etc) to account for fixed header

Change-Id: I2387866cbc1aef0fa4edb202b1af73659230045b
5 years ago
Isarra 8138b52ff8 Remove extra padding on thumbcaptions
Plenty of padding already in the thumb itself.

Change-Id: I063341cbfd3fd71ef272ebd8dcd3ff335b9678ca
5 years ago
Isarra 488be95b2a Kill weird table normalisation
Given all the special table stuff we do is onwiki junk largely targetted
at vector, making this randomly different probably doesn't add a whole lot.

Bug: T215608
Bug: T181184
Change-Id: Id5ad605d7179ac8c4b6766a110f98d44627c06ee
5 years ago
Isarra 9d76730e96 Add icons to desktop cactions and overhaul icon alignment and usage
throughout

* Still need to redo how we're using mixins, but whatever.
* Cleans up a bit from the edit/view source etc changes too, since now
  we have a little more context (oops)...
* Just hide 'view' in general because a, how much does it really add,
  and b, it doesn't fit in a lot of cases when we have the extra width
  from these icons regardless.
* Rename view and add section tabs to make more sense with icons/in
  context/whatever ('view' is now only targeted at screen readers, and
  we use a + for the new section icon, so saying 'add' is kinda...
  redundant)

Bug: T197520
Change-Id: I1ab12ccda60e51035c4adec43c42508ac297c00a
5 years ago
jenkins-bot 5c2c302430 Merge "Add custom WikiLove heart icon" 5 years ago