12 Commits (174ef87ede3dc3c640185504a36fbabaa00badb2)

Author SHA1 Message Date
jdlrobson f804f27167 Restore Timeless 1.35 support
Change-Id: I882f4d76df4c437ad6cc5883c243ec08a40f34fb
4 years ago
jdlrobson 84202757e2 Declare skin styles and scripts in the skin manifest as options
For you consideration. We will be aiming to do this in all Wikimedia
deployed skins so it would be great to have Timeless consistent with
those.

Change-Id: I11a8e0c8ca01b2c7eb2acc0b84ea4ad9301d3d8f
4 years ago
Isarra 5e2291df6d Fix some annoying things
* Stop images from overflowing on desktop as well as mobile (folks wanna
  overflow, they can load it sans skin, dammit)
* Firefox's stupid scrollbar colours
* Merge js into single module for desktop and mobile so it doesn't
  randomly break on the wrong devices, and something about too many
  modules anyway
* Weird footer padding?
* Weird WikiEditor/CodeMirror fonts/sizing

Bug: T256105
Bug: T247325
Change-Id: I8142c505534869c2530a915cfe8cef56303be6ed
4 years ago
Ammar Abdulhamid d911273c3a Remove Skin::setupSkinUserCss call
Method only calls parent and the parent is no-op

Bug: T257990
Change-Id: I44675efc351f74ba38e7d86b03aca48c15e0573e
5 years ago
mainframe98 b517e795a8 Specify the responsive option rather than manually specifying viewport
I6e69b482cdbc adds a viewport with the same value as Timeless.

Also remove the SkinTimeless::$skinname override, as it is now set in
Skin::__construct.

Bug: T258290
Depends-On: I6e69b482cdbc49c09adc6f7cee54f5e17b7c92c4
Change-Id: I215ac0153e5652e7ac76b11dba23a05aa2d1f685
5 years ago
Krinkle ee5a9fc043 Revert "Add settings to use a particular layout even at higher resolutions"
This reverts commit 49a2ab3417.

Change-Id: I78c0c7e6c0ae46e24e076752b07b1370b0f2bc29
5 years ago
Isarra 49a2ab3417 Add settings to use a particular layout even at higher resolutions
(Cap at single column or single-sidebar instead of the default three-
column mode.)

Adds user preference options and a $wgTimelessDefaultLayout config to
change the default wiki-wide. Intended for people who hate change and
prefer the same navigation layout (sort of) as we've had forever, and
for people who are really bad at change and just keep getting confused
when everything keeps moving around across different sized devices, as
well as anyone else who just likes... options, I guess? Whatever the
case, this is seriously up there in the running for 'most requested
feature'.

Uses three separate modules to avoid sending all users the same styles
twice regardless of what they'll even use, as each set is mostly the
same, just with slightly different breakpoints. Not seeing any saner
ways to do this, however, as even with LESS we can only use mixins/
includes/& afters to avoid the duplication in terms of what we work on,
not what is generated.

Bug: T131803
Change-Id: I0538d36c2ed7a5009b2a0f75952671ac9447fd56
6 years ago
Isarra a4900353b1 Use flex for logo container width and to show some username on small screens
* No columns, so no point aligning anything to column-widths here.
* Add some IE9 fallbacks because the entire header is now flex.
* Clean up, consolidate same styles, etc

Bug: T184998
Change-Id: Iecf99d093a689d3c32932b2603f16939127ce7bd
6 years ago
Timo Tijhof 8ddbd36d25 Merge 'skins.timeless.misc' back into 'skins.timeless'
Follows-up f450f7e13 and 1bb12ffaae which introduce and
explaine that module's need based on what I believe was a
misunderstanding.

Specifying an options object (e.g. with a "media" key) is optional
for a stylesheet, and a module can have any number of CSS or LESS
files that are packaged together. The syntax for this was designed
for PHP and unfortunately does not translate elegantly to JSON,
but it does work. In PHP, examples of this can be found that look
as follows:

 'styles' => [
   'foo.css',
   'bar.css' => [ 'media' => 'print' ],
   'quux.css',
 ],

Other examples of this in JSON can be found in Nostalgia.git
and ArticlePlaceholder.git.

Change-Id: Ie2a39a79c0892a1c5699a05071216eb5fe660bc1
6 years ago
Derick Alangi 7c6f015167 Declare each class property on separate lines
It's easier to read and also type hint and do a lot of
things when class properties are declared this way. I think
this is the standard way and it's an improvement :)

Also, added soft type hint phpdoc for these class properties.

Change-Id: I6f2bee7d5cd771f25241abcaebfacd6eb540175f
6 years ago
Umherirrender f784b7064e Add method scope visibility
Change-Id: Ic2c07aa870100158441e1868303f5e382fad5d06
6 years ago
Isarra 24c7182ae8 Move classes to includes/
Change-Id: I77862f0a451d4b742e762a3caedf032edd06485a
7 years ago