10 Commits (1350ba30ffbe3c04f25d8d5b974f24a92e534e20)

Author SHA1 Message Date
Timo Tijhof a907ac43b9 Remove use of 'jquery.tabIndex'
This feature was copied from Vector where it was recently removed
in e5c837e3ebf8.

In a nut shell, HTML output from PHP generally either has no
tabindex, tabindex=0 or tabindex=-1, or sometimes numbers between
1-100 for custom tab ordering. In JavaScript we then used
lastTabIndex (returns highest+1) to get an input field to be at the
end of the tab order. Thus making it be the *first* thing that
gets focussed when pressing Tab on a page (I guess the browser
offset is at the end of the document by default?)

This JS-based approach wasn't very stable as it required only
other thing in JS to use it for other reasons (e.g. genuinely
minting normal-use tab indexes for something) to break it as
we can't use the same logic for both "the lowest next number"
and "the highest possible number".

If we want to preserve this feature, it should probably do
something like attr('tabindex', '99999') which, while ugly,
would be a more sustainable way to implement this this.

Per Jack Phoenix in code review on this patch, match Vector
behaviour for now, where it was removed per T226148 for
being contrary to accessibility best practies.

Bug: T234581
Change-Id: I24777bdb6655f21d2f4896d5f887a125b36ab584
5 years ago
Isarra 41afd6e2b2 Fix close behaviour on click-toggle dropdowns
Change-Id: I0d70773918b048288ed278adb3df7f23c2d561cd
6 years ago
Fomafix 7f87813bc3 Simplify JavaScript code
* Reuse $() closure.
* Query jQuery selector only once.

Change-Id: Ic302427fe7d23808b3e6718fd23a6b5d492bfa88
6 years ago
Isarra 46bbcd9a0c Cleanup js clicky stuff a bit more
Change-Id: I5c4d6da26ca1c6b92c4aeabd47421567c3adc673
6 years ago
Isarra 54997f2dfb Use click to toggle for desktop dropdown menus
Still fall back to hover for nojs.

Bug: T211357
Change-Id: I9636a0e3c127173ffb7881c8760d39b715ae475f
6 years ago
Isarra 8a05fb1463 Fix fixed header scroll offset in supported browsers
Kill js solution even for other browsers because it doesn't even really
work to begin with. And I have no clue how to make it work, because I
can't find any examples that do, either.

Fixes current firefox and chrome. Users of old browsers/other
proprietary or whatever things can, uh, suffer, I guess.

Bug: T181484
Change-Id: Ic3415702eaa33cf56ed0b1fabf9ca607c88d1863
6 years ago
Isarra 5d52d91a61 Add offset for # links to work around fixed header on desktop
Prevent anchors from putting headers, cite notes, etc behind fixed
header when jumping around. Use js to avoid previous issue of mucked
up highlighting... (T162649)

bug: T181484, T162649
Change-Id: I6bdb450b24df50f39e14bc2b254c6adb6cc7f7d7
6 years ago
Ed Sanders d1b54f2b70 Remove obsolete aliases from closures
Bug: T208951
Change-Id: I0949da208d4df1d2fd1f85541f55f092da527400
6 years ago
Alangi Derick 734a7f7222 Set tabindex to 1 for the search box in Timeless skin
When using the Vector skin, and you load a page and press the tab
button on the keyboard once, the cursor focus on the search box,
this is handy and now available on the timeless skin too.

Also, removed target "mobile" as "jquery.tabIndex" dependency doesn't
use it.

Bug: T201424
Change-Id: I6e5d96371b5342ad2d3a207e980ec1fcf7e2de99
7 years ago
Isarra 3a1bc368de Initial skin from skin:Example; just renamed
Change-Id: Ic60e93eff08abe541635e135faf04e60a756f44c
9 years ago