From c9e9bb97e2bd5ebfc3bf4c5e2b8bb6b2bbb8a198 Mon Sep 17 00:00:00 2001 From: Simon Legner Date: Thu, 15 Aug 2019 16:15:25 +0200 Subject: [PATCH] Drop `redundant` attribute from `a` elements Holdover from SkinTemplate assumptions about link assembly. Bug: T214202 Change-Id: Idfa033bcfd100d031d31449228316206ff124aae --- includes/TimelessTemplate.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/includes/TimelessTemplate.php b/includes/TimelessTemplate.php index 300cec3..c2b9c8a 100644 --- a/includes/TimelessTemplate.php +++ b/includes/TimelessTemplate.php @@ -892,4 +892,16 @@ class TimelessTemplate extends BaseTemplate { return $html; } + + /** + * Extra cleanup: because we're not using SkinTemplate::buildContentActionUrls(), + * some junk gets left in the tab list items unless we remove it ourselves. + * (T214202) + * + * @inheritDoc + */ + public function makeListItem( $key, $item, $options = [] ) { + unset( $item['redundant'] ); + return parent::makeListItem( $key, $item, $options ); + } }