From 7c170141c6b7d4774bc5dad32048e0bbca03c060 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sun, 26 Nov 2017 12:01:02 +0100 Subject: [PATCH] Let Html::element do the HTML escaping Change-Id: I83a738babed5cb0a68651e4d67753bce0b72c796 --- TimelessTemplate.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/TimelessTemplate.php b/TimelessTemplate.php index 21a09be..318839a 100644 --- a/TimelessTemplate.php +++ b/TimelessTemplate.php @@ -229,8 +229,8 @@ class TimelessTemplate extends BaseTemplate { 'div', [ 'id' => Sanitizer::escapeId( $id ), 'class' => 'sidebar-chunk' ], Html::rawElement( 'h2', [], - Html::rawElement( 'span', [], - $this->getMsg( $headerMessage )->escaped() + Html::element( 'span', [], + $this->getMsg( $headerMessage )->text() ) . Html::element( 'div', [ 'class' => 'pokey' ] ) ) . @@ -462,20 +462,20 @@ class TimelessTemplate extends BaseTemplate { // Make sure it fits first (numbers slightly made up, may need adjusting) $fit = empty( $extraTools ) ? 13 : 9; if ( mb_strlen( $userName ) < $fit ) { - $dropdownHeader = htmlspecialchars( $userName, ENT_QUOTES ); + $dropdownHeader = $userName; } else { - $dropdownHeader = wfMessage( 'timeless-loggedin' )->escaped(); + $dropdownHeader = wfMessage( 'timeless-loggedin' )->text(); } $headerMsg = [ 'timeless-loggedinas', $user->getName() ]; } else { - $dropdownHeader = wfMessage( 'timeless-anonymous' )->escaped(); + $dropdownHeader = wfMessage( 'timeless-anonymous' )->text(); $headerMsg = 'timeless-notloggedin'; } $html .= Html::openElement( 'div', [ 'id' => 'user-tools' ] ); $html .= Html::rawElement( 'div', [ 'id' => 'personal' ], Html::rawElement( 'h2', [], - Html::rawElement( 'span', [], $dropdownHeader ) . + Html::element( 'span', [], $dropdownHeader ) . Html::element( 'div', [ 'class' => 'pokey' ] ) ) . Html::rawElement( 'div', [ 'id' => 'personal-inner', 'class' => 'dropdown' ],