From 84202757e2898e033740bab4f744edb5de5326c1 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Thu, 8 Oct 2020 16:28:13 -0700 Subject: [PATCH] Declare skin styles and scripts in the skin manifest as options For you consideration. We will be aiming to do this in all Wikimedia deployed skins so it would be great to have Timeless consistent with those. Change-Id: I11a8e0c8ca01b2c7eb2acc0b84ea4ad9301d3d8f --- includes/SkinTimeless.php | 4 ---- skin.json | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/SkinTimeless.php b/includes/SkinTimeless.php index f0b9f4c..4bd1287 100644 --- a/includes/SkinTimeless.php +++ b/includes/SkinTimeless.php @@ -17,10 +17,6 @@ class SkinTimeless extends SkinTemplate { public function initPage( OutputPage $out ) { parent::initPage( $out ); - $out->addModules( [ - 'skins.timeless.js' - ] ); - // Basic IE support without flexbox $out->addStyle( $this->stylename . '/resources/IE9fixes.css', 'screen', 'IE' ); } diff --git a/skin.json b/skin.json index 3d5d5cc..b16ceae 100644 --- a/skin.json +++ b/skin.json @@ -21,6 +21,9 @@ "styles": [ "mediawiki.skinning.content.externallinks", "skins.timeless" + ], + "scripts": [ + "skins.timeless.js" ] } ]