From 73388405c3895f83954655e947ccec42c0683269 Mon Sep 17 00:00:00 2001 From: AronDemian Date: Fri, 24 Apr 2020 00:47:06 +0200 Subject: [PATCH] Add and use `.mw-footer` & `.mw-footer-container` CSS classes Adding `.mw-footer` & `.mw-footer-container` CSS classes & replacing `#mw-footer`,`#mw-footer-container` selectors with them. `#mw-footer` & `#mw-footer-container` ids are kept for JS, gadgets compatibility and backwards compatibility with user styles. Bug: T248137 Change-Id: I6e262cb5fa1838a22c3c6de8866d0324e83f84b3 --- includes/TimelessTemplate.php | 5 +++-- resources/print.css | 2 +- resources/screen-common.less | 4 ++-- resources/screen-desktop-small.less | 2 +- resources/screen-mobile.less | 2 +- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/includes/TimelessTemplate.php b/includes/TimelessTemplate.php index e0b7861..5f9b021 100644 --- a/includes/TimelessTemplate.php +++ b/includes/TimelessTemplate.php @@ -87,8 +87,9 @@ class TimelessTemplate extends BaseTemplate { ) ); - $html .= Html::rawElement( 'div', [ 'id' => 'mw-footer-container', 'class' => 'ts-container' ], - Html::rawElement( 'div', [ 'id' => 'mw-footer', 'class' => 'ts-inner' ], + $html .= Html::rawElement( 'div', + [ 'id' => 'mw-footer-container', 'class' => 'mw-footer-container ts-container' ], + Html::rawElement( 'div', [ 'id' => 'mw-footer', 'class' => 'mw-footer ts-inner' ], $this->getFooter() ) ); diff --git a/resources/print.css b/resources/print.css index b57011c..4f53824 100644 --- a/resources/print.css +++ b/resources/print.css @@ -6,7 +6,7 @@ #mw-site-navigation, #mw-related-navigation, #mw-page-header-links, -#mw-footer, +.mw-footer, #catlinks { display: none; } diff --git a/resources/screen-common.less b/resources/screen-common.less index 19eacd8..03d38f2 100644 --- a/resources/screen-common.less +++ b/resources/screen-common.less @@ -32,7 +32,7 @@ body { word-wrap: break-word; } -#mw-footer-container { +.mw-footer-container { border-top: solid 1px @base20; box-shadow: inset 0 7px 2px -4px rgba( 0, 0, 0, 0.1 ); color: @base100; @@ -154,7 +154,7 @@ body { /* Footer */ -#mw-footer { +.mw-footer { padding-top: 0.5em; padding-bottom: 1em; diff --git a/resources/screen-desktop-small.less b/resources/screen-desktop-small.less index b5edd8f..3238c89 100644 --- a/resources/screen-desktop-small.less +++ b/resources/screen-desktop-small.less @@ -156,7 +156,7 @@ padding-right: 0.5em; } -#mw-footer { +.mw-footer { padding: 0 @content-padding; } diff --git a/resources/screen-mobile.less b/resources/screen-mobile.less index 059b6a0..52648c4 100644 --- a/resources/screen-mobile.less +++ b/resources/screen-mobile.less @@ -6,7 +6,7 @@ /* Layout */ #mw-data-after-content, -#mw-footer { +.mw-footer { padding: 0 @content-padding; }