diff --git a/composer.json b/composer.json index aa9556e..8bb8c56 100644 --- a/composer.json +++ b/composer.json @@ -2,9 +2,9 @@ "require-dev": { "jakub-onderka/php-parallel-lint": "1.0.0", "mediawiki/mediawiki-codesniffer": "28.0.0", - "jakub-onderka/php-console-highlighter": "0.3.2", - "mediawiki/minus-x": "0.3.1", - "mediawiki/mediawiki-phan-config": "0.8.0" + "jakub-onderka/php-console-highlighter": "0.4.0", + "mediawiki/minus-x": "0.3.2", + "mediawiki/mediawiki-phan-config": "0.9.0" }, "scripts": { "fix": [ diff --git a/includes/TimelessTemplate.php b/includes/TimelessTemplate.php index 8c3eaec..364b36f 100644 --- a/includes/TimelessTemplate.php +++ b/includes/TimelessTemplate.php @@ -460,7 +460,6 @@ class TimelessTemplate extends BaseTemplate { } // Numeric strings gets an integer when set as key, cast back - T73639 $name = (string)$name; - // @phan-suppress-next-line PhanTypeArraySuspiciousNullable $html .= $this->getPortlet( $name, $content['content'] ); } @@ -727,6 +726,7 @@ class TimelessTemplate extends BaseTemplate { 'id' => 'ca-more', 'class' => 'dropdown-toggle' ]; + // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset if ( $this->data['language_urls'] !== false || $sortedPileOfTools['variants'] || isset( $this->otherProjects ) ) { $pileOfTools['languages'] = [ @@ -1082,6 +1082,7 @@ class TimelessTemplate extends BaseTemplate { } else { // Okay, we really do want a 1x otherwise. If this throws an error or // something because there's nothing here, GOOD. + // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset $attribs['src'] = $logoData['1x']; // Throw the rest in a srcset diff --git a/package-lock.json b/package-lock.json index a0a55a1..dda6a20 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1827,9 +1827,9 @@ } }, "grunt-banana-checker": { - "version": "0.6.0", - "resolved": "https://registry.npmjs.org/grunt-banana-checker/-/grunt-banana-checker-0.6.0.tgz", - "integrity": "sha1-ZJpnd0AABJ4uwMSyrBSJFYZOsg8=", + "version": "0.8.1", + "resolved": "https://registry.npmjs.org/grunt-banana-checker/-/grunt-banana-checker-0.8.1.tgz", + "integrity": "sha512-fx3lqZZFL9EihNI4BpwNmcjsb5tCVfa/xWVXLT3fipSOrLr/BsWdAUTltscTx55/tSwSR8VbJOulI00e1WTtoA==", "dev": true }, "grunt-eslint": { diff --git a/package.json b/package.json index d6fc84e..0fca0b1 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "devDependencies": { "eslint-config-wikimedia": "0.9.0", "grunt": "1.0.4", - "grunt-banana-checker": "0.6.0", + "grunt-banana-checker": "0.8.1", "grunt-eslint": "21.0.0", "grunt-jsonlint": "1.1.0", "grunt-stylelint": "0.13.0",